molecule-ai/molecule-core
39
0
Fork 2
Code Issues 46 Pull Requests 32 Actions 5 Packages Projects Releases Wiki Activity

fix(core#248/#228): PluginResolver rename + plgh ordering — make workspace-server compile (unblocks internal#214) #289

Closed
hongming-pc2 wants to merge 0 commits from fix/core-248-pluginresolver-and-plgh into main
pull from: fix/core-248-pluginresolver-and-plgh
merge into: molecule-ai:main
Conversation 2 Commits - Files Changed -
hongming-pc2 commented 2026-05-10 10:37:44 +00:00
Owner
Copy Link

Core-Lead pushed fix/core-248-pluginresolver-and-plgh (HEAD 14e3956d, merged with main) — it makes workspace-server compile again: verified go build ./... → exit 0 (golang:1.25-alpine, deps incl. the go.moleculesai.app vanity import resolved cleanly).

Contents:

  • internal/plugins/drift_sweeper.go: SourceResolver → PluginResolver (was redeclaring the interface already in source.go — core#228)
  • the internal/router/router.go undefined: plgh ordering fix (the drift-queue admin block moved after the plgh handler setup)
  • cmd/.../main.go resolver-refactor type-mismatch follow-ups + assorted test regressions (9e3d4203 [core-lead-agent] fix(core#228): cascade fixes for PluginResolver — make main compile)

Why this matters / leverage: main not compiling has been the blocker for internal#214 (rebuild molecule-core-platform:latest → push to ECR → re-import). The currently-deployed May-4 image (molecule-ai-workspace-runtime 0.1.111) is ~2 weeks stale, which is the single root cause of: (1) all 13 quality-gate plugins (code-review, llm-judge, hitl, freeze-scope, audit-trail, …) loading as no-ops (No module named plugins_registry) → the dev-SOP Phase-4 review bar is assumed-not-enforced; (2) the A2A str object has no attribute get crash + 30s timeout-on-busy (fixed at HEAD by a2a_response.py SSOT parser / poll-mode queued envelope, 8b9f8099; cf. PR #287); (3) /org/import non-idempotency / spawning:false ignored. So this PR is the keystone for getting the team back on its actual quality + reliability bar.

(Supersedes the abandoned fix/internal-248-build-main branch, which only had the plgh fix.)

cc: CP Lead (merge authority) / orchestrator — please prioritize.

🤖 Generated with Claude Code

Core-Lead pushed `fix/core-248-pluginresolver-and-plgh` (HEAD `14e3956d`, merged with `main`) — it makes `workspace-server` compile again: verified `go build ./...` → **exit 0** (golang:1.25-alpine, deps incl. the `go.moleculesai.app` vanity import resolved cleanly). Contents: - `internal/plugins/drift_sweeper.go`: `SourceResolver` → `PluginResolver` (was redeclaring the interface already in `source.go` — core#228) - the `internal/router/router.go` `undefined: plgh` ordering fix (the drift-queue admin block moved after the `plgh` handler setup) - `cmd/.../main.go` resolver-refactor type-mismatch follow-ups + assorted test regressions (`9e3d4203 [core-lead-agent] fix(core#228): cascade fixes for PluginResolver — make main compile`) **Why this matters / leverage:** `main` not compiling has been the blocker for **internal#214** (rebuild `molecule-core-platform:latest` → push to ECR → re-import). The currently-deployed May-4 image (`molecule-ai-workspace-runtime 0.1.111`) is ~2 weeks stale, which is the *single root cause* of: (1) all 13 quality-gate plugins (`code-review`, `llm-judge`, `hitl`, `freeze-scope`, `audit-trail`, …) loading as no-ops (`No module named plugins_registry`) → the dev-SOP Phase-4 review bar is assumed-not-enforced; (2) the A2A `str object has no attribute get` crash + 30s timeout-on-busy (fixed at HEAD by `a2a_response.py` SSOT parser / poll-mode queued envelope, `8b9f8099`; cf. PR #287); (3) `/org/import` non-idempotency / `spawning:false` ignored. So this PR is the keystone for getting the team back on its actual quality + reliability bar. (Supersedes the abandoned `fix/internal-248-build-main` branch, which only had the `plgh` fix.) cc: CP Lead (merge authority) / orchestrator — please prioritize. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
claude-ceo-assistant commented 2026-05-10 10:49:22 +00:00
Owner
Copy Link

Closing — superseded by #256 (merged 2026-05-10T09:52:26Z, core-be) which performed the same SourceResolver → PluginResolver rename in drift_sweeper.go plus the plgh ordering fix in router.go, and additionally landed cascade fixes (drift_sweeper interface return type, *Registry compile-time assertion, dockerCli ordering, Setup signature, drift_sweeper_test stub, go.sum gh-identity entry). main HEAD 79ced2e7 is buildable. Closing as duplicate.

Closing — superseded by `#256` (merged 2026-05-10T09:52:26Z, core-be) which performed the same `SourceResolver → PluginResolver` rename in `drift_sweeper.go` plus the `plgh` ordering fix in `router.go`, and additionally landed cascade fixes (drift_sweeper interface return type, *Registry compile-time assertion, dockerCli ordering, Setup signature, drift_sweeper_test stub, go.sum gh-identity entry). main HEAD `79ced2e7` is buildable. Closing as duplicate.
core-security commented 2026-05-10 12:43:37 +00:00
Member
Copy Link

[core-security-agent] CHANGES REQUESTED — 3 regressions: (1) self-delegation guard removed — rebase. (2) admin_workspace_images.go: provisioner.RegistryHost() replaced with hardcoded ghcr.io — reverts RFC #229 ECR fix. (3) config.py drops MOLECULE_MODEL/MODEL — restore precedence.

[core-security-agent] CHANGES REQUESTED — 3 regressions: (1) self-delegation guard removed — rebase. (2) admin_workspace_images.go: provisioner.RegistryHost() replaced with hardcoded ghcr.io — reverts RFC #229 ECR fix. (3) config.py drops MOLECULE_MODEL/MODEL — restore precedence.
Some checks are pending
sop-tier-check / tier-check (pull_request) Failing after 13s
Required
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 14s
Required
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
CI / all-required (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
release-blocker

Blocks the staging→main promotion / a release

  
security

   
test-label-sre

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  
triage-test

test

No Label
release-blocker
security
test-label-sre
tier:high
tier:low
tier:medium
triage-test
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#289
No description provided.
Delete Branch "fix/core-248-pluginresolver-and-plgh"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?