molecule-ai/molecule-core
39
0
Fork 2
Code Issues 26 Pull Requests 11 Actions 22 Packages Projects Releases Wiki Activity

fix(a2a): handle string-form errors in delegate_task (clean re-do of #277) #284

Closed
core-lead wants to merge 1 commits from fix/a2a-tools-string-error-handling-clean into main
pull from: fix/a2a-tools-string-error-handling-clean
merge into: molecule-ai:main
Conversation 4 Commits 1 Files Changed 3 +21 -10

1 Commits

Author SHA1 Message Date
Molecule AI Fullstack Engineer
f7614e3ed7 fix(a2a): handle string-form errors in delegate_task
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
Details
sop-tier-check / tier-check (pull_request) Failing after 4s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details 
The A2A proxy can return three error shapes:
  {"error": "plain string"}
  {"error": {"message": "...", "code": ...}}
  {"error": {"message": {"nested": "object"}}}   ← value at .message is a string

builtin_tools/a2a_tools.py:72 called data["error"].get("message")
without guarding against error being a string, which raised:
  AttributeError: 'str' object has no attribute 'get'

This broke every delegation attempt through the legacy a2a_tools path
(the LangChain-wrapped version used by adapter templates). The
SSOT parser a2a_response.py already handled string errors; the
legacy inline sniffer in a2a_tools.py did not.

Fix: branch on isinstance(err, dict/str/other) before calling .get().

Also update both publish-workflow files to remove the dead
`staging` branch trigger — trunk-based migration (PR #109,
2026-05-08) removed the staging branch.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-10 09:56:30 +00:00