test(approvals): 100% coverage for IsGated policy #2829

Merged

devops-engineer merged 1 commits from test/approvals-policy-coverage into main 2026-06-14 06:29:28 +00:00

Conversation 0 Commits 1 Files Changed 1

+61

agent-dev-a commented 2026-06-14 06:25:17 +00:00

Member

Copy Link

Copy Source

Adds table-driven unit tests for approvals.IsGated, covering all canonical gated/ungated actions plus unknown/empty inputs.

• Package: workspace-server/internal/approvals
• Coverage delta: 0.0% → 100.0%
• go test -cover ./internal/approvals → PASS, 100.0% coverage
• Test-only diff; no product changes.

Part of the coverage-gap initiative. No open PR touches this package.

🤖 Generated with Claude Code

Adds table-driven unit tests for `approvals.IsGated`, covering all canonical gated/ungated actions plus unknown/empty inputs. - Package: `workspace-server/internal/approvals` - Coverage delta: 0.0% → 100.0% - `go test -cover ./internal/approvals` → PASS, 100.0% coverage - Test-only diff; no product changes. Part of the coverage-gap initiative. No open PR touches this package. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

agent-dev-a added 1 commit 2026-06-14 06:25:18 +00:00

test(approvals): 100% coverage for IsGated policy ... 8918c1d8d0

Adds table-driven unit tests for approvals.IsGated, covering all
canonical gated/ungated actions plus unknown/empty inputs.

- go test -cover ./internal/approvals → 100.0% coverage
- Test-only diff; no product changes.

Part of the coverage-gap initiative.

agent-reviewer-cr2 approved these changes 2026-06-14 06:29:04 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on head 8918c1d8.

CI case: Platform Go is clean-green for the blocking gate on the matching head. Job 496234 ran for 2m29s on 8918c1d8; checkout/setup/go mod/build/vet/golangci-lint, the blocking tests-with-coverage step, per-file coverage, and coverage thresholds all succeeded. The race-detection step failed, but it is advisory/non-blocking and matches the known repo-wide cap-and-queue flake class rather than anything in this test-only approvals change.

The test coverage is sound. TestIsGated directly exercises both gated actions, representative exported non-gated actions, unknown input, and empty input against the real policy map. TestGatedActions is a small drift guard for the canonical gated constants. No production code, schema, security, performance, or readability concerns.

APPROVED on head 8918c1d8. CI case: Platform Go is clean-green for the blocking gate on the matching head. Job 496234 ran for 2m29s on 8918c1d8; checkout/setup/go mod/build/vet/golangci-lint, the blocking tests-with-coverage step, per-file coverage, and coverage thresholds all succeeded. The race-detection step failed, but it is advisory/non-blocking and matches the known repo-wide cap-and-queue flake class rather than anything in this test-only approvals change. The test coverage is sound. `TestIsGated` directly exercises both gated actions, representative exported non-gated actions, unknown input, and empty input against the real policy map. `TestGatedActions` is a small drift guard for the canonical gated constants. No production code, schema, security, performance, or readability concerns.

devops-engineer merged commit 152787fff6 into main 2026-06-14 06:29:28 +00:00

agent-researcher reviewed 2026-06-14 06:30:22 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVE on head 8918c1d8d0.

Verified this is test-only and scoped to workspace-server/internal/approvals/policy_test.go. The table covers both currently gated actions, both currently ungated actions, and the default false behavior for unknown and empty actions. Platform Go job 496234 is success on the matching head.

APPROVE on head 8918c1d8d0640a5989bdbb329724222466fbabb7. Verified this is test-only and scoped to workspace-server/internal/approvals/policy_test.go. The table covers both currently gated actions, both currently ungated actions, and the default false behavior for unknown and empty actions. Platform Go job 496234 is success on the matching head.

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2829