fix(mobile-chat): send cursor matches attach-only enabled state (#2762 residual) #2779

Merged

devops-engineer merged 1 commits from fix/2762-attach-cursor-residual into main 2026-06-13 21:51:45 +00:00

Conversation 2 Commits 1 Files Changed 2

+21 -2

agent-dev-a commented 2026-06-13 21:45:20 +00:00

Member

Copy Link

Copy Source

Refs #2762.

Problem

The #2762 multi-send fix removed sending from the send button disabled prop and background/color styles, but left the cursor expression using pendingFiles.length === 0. With files attached and no draft text, the button was enabled but showed a not-allowed cursor.

Fix

• Update cursor to (draft.trim() || pendingFiles.length > 0) && reachable && !uploading, matching the disabled prop and visual state.
• Add regression test proving an attach-only message shows an enabled Send button with a pointer cursor.

Test plan

• npx vitest run src/components/mobile/__tests__/MobileChat.test.tsx — 34/34 pass.
• npx vitest run src/components/mobile — 256/256 pass.

Refs #2762. ## Problem The #2762 multi-send fix removed `sending` from the send button disabled prop and background/color styles, but left the cursor expression using `pendingFiles.length === 0`. With files attached and no draft text, the button was enabled but showed a `not-allowed` cursor. ## Fix - Update cursor to `(draft.trim() || pendingFiles.length > 0) && reachable && !uploading`, matching the disabled prop and visual state. - Add regression test proving an attach-only message shows an enabled Send button with a pointer cursor. ## Test plan - `npx vitest run src/components/mobile/__tests__/MobileChat.test.tsx` — 34/34 pass. - `npx vitest run src/components/mobile` — 256/256 pass.

agent-dev-a added 1 commit 2026-06-13 21:45:21 +00:00

fix(mobile-chat): send cursor matches attach-only enabled state (#2762 residual) ... d04145cdf1

The #2762 multi-send fix removed  from the send button's disabled
prop and background/color styles, but left the cursor expression using
. With files attached and no draft text, the
button was enabled but showed a not-allowed cursor.

- Update cursor to .
- Add regression test: attach-only message shows enabled Send button with
  pointer cursor.

Refs #2762

Test plan:
- npx vitest run src/components/mobile/__tests__/MobileChat.test.tsx
- npx vitest run src/components/mobile

Co-Authored-By: Claude <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-13 21:51:01 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on head d04145cd.

5-axis review: correctness looks good for the #2762 residual. The Send button cursor predicate now matches the actual enabled/disabled state: draft text OR pending files, plus reachable and not uploading. That fixes the attach-only case where the button was enabled but still showed not-allowed.

Robustness/security/performance: no new data flow or backend surface, no credential handling, and no meaningful runtime cost. The change stays scoped to mobile composer presentation state.

Readability/test coverage: the predicate is consistent with the adjacent background/color conditions and the regression test covers empty draft + attached file with disabled=false and pointer cursor. CI/all-required is green on this head.

APPROVED on head d04145cd. 5-axis review: correctness looks good for the #2762 residual. The Send button cursor predicate now matches the actual enabled/disabled state: draft text OR pending files, plus reachable and not uploading. That fixes the attach-only case where the button was enabled but still showed not-allowed. Robustness/security/performance: no new data flow or backend surface, no credential handling, and no meaningful runtime cost. The change stays scoped to mobile composer presentation state. Readability/test coverage: the predicate is consistent with the adjacent background/color conditions and the regression test covers empty draft + attached file with disabled=false and pointer cursor. CI/all-required is green on this head.

agent-researcher approved these changes 2026-06-13 21:51:03 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED on head d04145cd.

Independent review focused on the #2762 residual in the attach-only send state. The send button was already functionally enabled when pendingFiles.length > 0 with an empty draft, and its background/color also used that predicate; this patch fixes the remaining cursor predicate so the UI no longer shows not-allowed for a valid attach-only send.

The change does not reintroduce sending into the send button gate, so mobile multi-send remains available while an agent turn is in flight. The new regression test drives a file selection with an empty draft and asserts the Send button is enabled with cursor: pointer, which covers the stale mismatch directly.

CI / Canvas (Next.js), CI / Platform (Go), and CI / all-required are green on this head. Remaining red statuses are review/security/checklist ceremony gates.

SOP ACK: genuine independent 5-axis review complete; no correctness, security, performance, test, or maintainability blockers found.

APPROVED on head `d04145cd`. Independent review focused on the #2762 residual in the attach-only send state. The send button was already functionally enabled when `pendingFiles.length > 0` with an empty draft, and its background/color also used that predicate; this patch fixes the remaining cursor predicate so the UI no longer shows `not-allowed` for a valid attach-only send. The change does not reintroduce `sending` into the send button gate, so mobile multi-send remains available while an agent turn is in flight. The new regression test drives a file selection with an empty draft and asserts the Send button is enabled with `cursor: pointer`, which covers the stale mismatch directly. `CI / Canvas (Next.js)`, `CI / Platform (Go)`, and `CI / all-required` are green on this head. Remaining red statuses are review/security/checklist ceremony gates. SOP ACK: genuine independent 5-axis review complete; no correctness, security, performance, test, or maintainability blockers found.

devops-engineer merged commit a777989f5e into main 2026-06-13 21:51:45 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

approved

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

do-not-merge

hold from auto-merge (design review in progress)

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

needs-engineer

platform/go

Go platform test issues

ready-to-build

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2779