molecule-ai/molecule-core
52
0
Fork 2
Code Issues 178 Pull Requests 50 Actions Packages Projects Releases Wiki Activity

fix(chat): reuse optimistic message id as A2A messageId to prevent origin duplicate bubble (core#2713) #2716

Closed
agent-dev-a wants to merge 1 commits from fix/2713-origin-duplicate-message-id into main
pull from: fix/2713-origin-duplicate-message-id
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 2
+93 -1
agent-dev-a commented 2026-06-13 06:28:49 +00:00
Member
Copy Link
Copy Source

useChatSend created the optimistic user message with one id, then sent a fresh crypto.randomUUID() as the A2A params.message.messageId. The server echoes USER_MESSAGE with the A2A id, and appendMessageDedupedById could not collapse the two bubbles on the origin device, so the E2E Chat assertion at canvas/e2e/chat-desktop.spec.ts:70-77 resolved to two elements.

  • Use userMsg.id for the outbound message.messageId.
  • Add regression test asserting the optimistic and A2A ids match.

Fixes #2713.

Co-Authored-By: Claude noreply@anthropic.com

Test plan

  • npm test -- src/components/tabs/chat/hooks/__tests__/useChatSend --run passes (13/13)
  • New regression test useChatSend.originMessageId.test.tsx passes (2/2)
`useChatSend` created the optimistic user message with one id, then sent a fresh `crypto.randomUUID()` as the A2A `params.message.messageId`. The server echoes `USER_MESSAGE` with the A2A id, and `appendMessageDedupedById` could not collapse the two bubbles on the origin device, so the E2E Chat assertion at `canvas/e2e/chat-desktop.spec.ts:70-77` resolved to two elements. - Use `userMsg.id` for the outbound `message.messageId`. - Add regression test asserting the optimistic and A2A ids match. Fixes #2713. Co-Authored-By: Claude <noreply@anthropic.com> ## Test plan - `npm test -- src/components/tabs/chat/hooks/__tests__/useChatSend --run` passes (13/13) - New regression test `useChatSend.originMessageId.test.tsx` passes (2/2)
agent-dev-a added 1 commit 2026-06-13 06:29:22 +00:00
fix(chat): reuse optimistic message id as A2A messageId to prevent origin duplicate bubble (core#2713)
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
CI / Python Lint & Test (pull_request) Successful in 5s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 7s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
E2E Peer Visibility (literal MCP list_peers) / detect-changes (pull_request) Successful in 11s
Details
qa-review / approved (pull_request_target) Failing after 7s
Details
reserved-path-review / reserved-path-review (pull_request_target) Successful in 8s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
security-review / approved (pull_request_target) Failing after 7s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 13s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
E2E Chat / detect-changes (pull_request) Successful in 15s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 9s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 15s
Details
CI / Detect changes (pull_request) Successful in 17s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Details
gate-check-v3 / gate-check (pull_request_target) Failing after 14s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 15s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 4s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 19s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 1m26s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Successful in 24s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3m34s
Details
CI / Canvas Deploy Status (pull_request) Successful in 1s
Details
CI / all-required (pull_request) Successful in 4s
Details
3b57983d65 
useChatSend created the optimistic user message with one id, then sent
a fresh crypto.randomUUID() as the A2A params.message.messageId. The
server echoes USER_MESSAGE with the A2A id, and appendMessageDedupedById
could not collapse the two bubbles on the origin device.

- Use userMsg.id for the outbound message.messageId.
- Add regression test asserting the optimistic and A2A ids match.

Fixes #2713.

Co-Authored-By: Claude <noreply@anthropic.com>
agent-dev-a force-pushed fix/2713-origin-duplicate-message-id from 27a8431261 to 3b57983d65 2026-06-13 06:29:22 +00:00 Compare
agent-dev-a closed this pull request 2026-06-13 06:30:03 +00:00
Some optional checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
CI / Python Lint & Test (pull_request) Successful in 5s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 7s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
E2E Peer Visibility (literal MCP list_peers) / detect-changes (pull_request) Successful in 11s
Details
qa-review / approved (pull_request_target) Failing after 7s
Details
reserved-path-review / reserved-path-review (pull_request_target) Successful in 8s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
security-review / approved (pull_request_target) Failing after 7s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 13s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
E2E Chat / detect-changes (pull_request) Successful in 15s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 9s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 15s
Details
CI / Detect changes (pull_request) Successful in 17s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Required
Details
gate-check-v3 / gate-check (pull_request_target) Failing after 14s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 15s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 4s
Required
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Required
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 19s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 1m26s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Successful in 24s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3m34s
Details
CI / Canvas Deploy Status (pull_request) Successful in 1s
Details
CI / all-required (pull_request) Successful in 4s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2716
Delete Branch "fix/2713-origin-duplicate-message-id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?