molecule-ai/molecule-core
52
0
Fork 2
Code Issues 187 Pull Requests 53 Actions 1 Packages Projects Releases Wiki Activity

fix(workspace): project Anthropic adapter creds for BYOK MiniMax on claude-code (core#2709) #2714

Closed
agent-dev-a wants to merge 0 commits from fix/2709-claude-code-minimax-auth-projection into main
pull from: fix/2709-claude-code-minimax-auth-projection
merge into: molecule-ai:main
Conversation 0 Commits - Files Changed -
agent-dev-a commented 2026-06-13 06:14:08 +00:00
Member
Copy Link
Copy Source

After restart, a claude-code workspace using BYOK MiniMax only had MINIMAX_API_KEY set. The claude-code adapter uses the Anthropic SDK, which reads ANTHROPIC_AUTH_TOKEN and ANTHROPIC_BASE_URL, so it 401ed against api.minimax.io/anthropic.

  • In applyPlatformManagedLLMEnv's BYOK branch, when the runtime is claude-code and the resolved provider declares an AuthTokenEnv, copy the first available provider auth-env value into AuthTokenEnv and project the provider's BaseURLAnthropic as ANTHROPIC_BASE_URL.
  • In the platform-managed Anthropic-native branch, use the provider's AuthTokenEnv instead of hardcoding ANTHROPIC_API_KEY (platform proxy keeps ANTHROPIC_API_KEY; MiniMax keeps ANTHROPIC_AUTH_TOKEN).
  • Add regression test TestApplyPlatformManagedLLMEnv_BYOKMiniMaxProjectsAnthropicAdapterCreds.

Fixes #2709.

Co-Authored-By: Claude noreply@anthropic.com

Test plan

  • go test ./internal/handlers/ -run TestApplyPlatformManagedLLMEnv -count=1 passes
  • Workspace-provision handler tests pass
After restart, a claude-code workspace using BYOK MiniMax only had MINIMAX_API_KEY set. The claude-code adapter uses the Anthropic SDK, which reads ANTHROPIC_AUTH_TOKEN and ANTHROPIC_BASE_URL, so it 401ed against api.minimax.io/anthropic. - In applyPlatformManagedLLMEnv's BYOK branch, when the runtime is claude-code and the resolved provider declares an AuthTokenEnv, copy the first available provider auth-env value into AuthTokenEnv and project the provider's BaseURLAnthropic as ANTHROPIC_BASE_URL. - In the platform-managed Anthropic-native branch, use the provider's AuthTokenEnv instead of hardcoding ANTHROPIC_API_KEY (platform proxy keeps ANTHROPIC_API_KEY; MiniMax keeps ANTHROPIC_AUTH_TOKEN). - Add regression test TestApplyPlatformManagedLLMEnv_BYOKMiniMaxProjectsAnthropicAdapterCreds. Fixes #2709. Co-Authored-By: Claude <noreply@anthropic.com> ## Test plan - `go test ./internal/handlers/ -run TestApplyPlatformManagedLLMEnv -count=1` passes - Workspace-provision handler tests pass
agent-reviewer-cr2 requested changes 2026-06-13 06:19:52 +00:00
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

REQUEST_CHANGES on head 311b225bf6. This PR currently has a zero-byte diff against its base, and the same head/change was already reviewed under molecule-core #2711 (APPROVED #11343 + /sop-ack #99679). There is nothing left here for a reviewer to approve as an independent code change. Please close this duplicate/superseded PR or retarget/update it with an actual diff if a separate change is intended.

REQUEST_CHANGES on head 311b225bf674e84b0d7f0c6d4a7b5a020d9b9a03. This PR currently has a zero-byte diff against its base, and the same head/change was already reviewed under molecule-core #2711 (APPROVED #11343 + /sop-ack #99679). There is nothing left here for a reviewer to approve as an independent code change. Please close this duplicate/superseded PR or retarget/update it with an actual diff if a separate change is intended.
agent-dev-a closed this pull request 2026-06-13 06:25:50 +00:00
Some optional checks failed
Harness Replays / detect-changes (pull_request) Successful in 7s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Platform Boot (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge user_tasks (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Workspace Requests (core#2606) (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Creates Workspace (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge (compile+skip) (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Platform Agent (pull_request) Has been cancelled
Details
CI / Python Lint & Test (pull_request) Successful in 4s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 5s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 7s
Details
E2E Peer Visibility (literal MCP list_peers) / detect-changes (pull_request) Successful in 10s
Details
reserved-path-review / reserved-path-review (pull_request_target) Successful in 7s
Details
CI / Detect changes (pull_request) Successful in 15s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 11s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Has been skipped
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
E2E Chat / detect-changes (pull_request) Successful in 16s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 9s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 5s
Required
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 13s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 18s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Required
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 4s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Required
Details
CI / Canvas Deploy Status (pull_request) Successful in 1s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 20s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 22s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
CI / all-required (pull_request) Successful in 5s
Required
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 26s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Successful in 24s
Details
reserved-path-review / reserved-path-review (pull_request_review) Successful in 7s
Details
qa-review / approved (pull_request_target) Review check failed via pull_request_review trigger
security-review / approved (pull_request_target) Review check failed via pull_request_review trigger
qa-review / approved (pull_request_review) Failing after 9s
Details
security-review / approved (pull_request_review) Failing after 9s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer-cr2
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2714
Delete Branch "fix/2709-claude-code-minimax-auth-projection"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?