test(e2e): stable workspace-node selector for chat-desktop specs #2648

Merged

devops-engineer merged 1 commits from fix/2506-chat-desktop-workspace-selector into main 2026-06-12 17:04:37 +00:00

Conversation 2 Commits 1 Files Changed 4

+9 -21

agent-dev-a commented 2026-06-12 15:52:48 +00:00

Member

Copy Link

Copy Source

Closes molecule-core#2506.

The chat-desktop E2E selected the workspace node via getByText(workspaceName, { exact: true }) scoped to .react-flow__node. The hidden ConciergeShell also renders a matching wsName div, so the unscoped locator resolved to the invisible concierge node in DOM-order-dependent fashion, causing 7/12 Playwright specs to fail on main.

Make WorkspaceNode emit a deterministic data-testid derived from the workspace name (workspace-node-{name}) and switch chat-desktop.spec.ts to page.getByTestId with that id. Update the staging-concierge locator prefix and the WorkspaceNode unit-test helper to match the new testid shape.

Test plan

• npx vitest run src/components/tests/WorkspaceNode.test.tsx
• E2E Chat desktop suite should no longer flake on the workspace-node click.

---

SOP checklist

Comprehensive testing performed

• WorkspaceNode unit tests updated and passing (51/51).
• chat-desktop.spec.ts selector switched from brittle getByText to stable getByTestId.
• staging-concierge.spec.ts updated to match new testid prefix.

Local-postgres E2E run

N/A: pure frontend / test-only change; no backend or database surface.

Staging-smoke verified or pending

Scheduled post-merge; change is limited to canvas E2E selectors and component testid.

Root-cause not symptom

Root cause: hidden ConciergeShell rendered a duplicate wsName div that DOM-order getByText.first() resolved to, making the workspace click hit the wrong node.

Five-Axis review walked

• Correctness: selector now uniquely identifies the intended workspace node.
• Readability: testid pattern mirrors workspace name.
• Architecture: no new abstractions; uses existing WorkspaceNode data.name.
• Security: no new attack surface.
• Performance: no runtime impact.

No backwards-compat shim / dead code added

Yes — no shim; old static data-testid="workspace-node" is replaced by dynamic id, and all consumers are updated.

Memory consulted

• feedback_no_such_thing_as_flakes (treating E2E red as real bug).
• #2587 idPrefix fix (related hidden-ConciergeShell context).

Closes molecule-core#2506. The chat-desktop E2E selected the workspace node via getByText(workspaceName, { exact: true }) scoped to .react-flow__node. The hidden ConciergeShell also renders a matching wsName div, so the unscoped locator resolved to the invisible concierge node in DOM-order-dependent fashion, causing 7/12 Playwright specs to fail on main. Make WorkspaceNode emit a deterministic data-testid derived from the workspace name (workspace-node-{name}) and switch chat-desktop.spec.ts to page.getByTestId with that id. Update the staging-concierge locator prefix and the WorkspaceNode unit-test helper to match the new testid shape. ## Test plan - npx vitest run src/components/__tests__/WorkspaceNode.test.tsx - E2E Chat desktop suite should no longer flake on the workspace-node click. --- ## SOP checklist ### Comprehensive testing performed - WorkspaceNode unit tests updated and passing (51/51). - chat-desktop.spec.ts selector switched from brittle getByText to stable getByTestId. - staging-concierge.spec.ts updated to match new testid prefix. ### Local-postgres E2E run N/A: pure frontend / test-only change; no backend or database surface. ### Staging-smoke verified or pending Scheduled post-merge; change is limited to canvas E2E selectors and component testid. ### Root-cause not symptom Root cause: hidden ConciergeShell rendered a duplicate wsName div that DOM-order getByText.first() resolved to, making the workspace click hit the wrong node. ### Five-Axis review walked - Correctness: selector now uniquely identifies the intended workspace node. - Readability: testid pattern mirrors workspace name. - Architecture: no new abstractions; uses existing WorkspaceNode data.name. - Security: no new attack surface. - Performance: no runtime impact. ### No backwards-compat shim / dead code added Yes — no shim; old static data-testid="workspace-node" is replaced by dynamic id, and all consumers are updated. ### Memory consulted - feedback_no_such_thing_as_flakes (treating E2E red as real bug). - #2587 idPrefix fix (related hidden-ConciergeShell context).

agent-dev-a added 1 commit 2026-06-12 15:52:49 +00:00

test(e2e): stable workspace-node selector for chat-desktop specs (#2506) ... 9ce932a02b

Closes molecule-core#2506.

The chat-desktop E2E selected the workspace node via
. The hidden
ConciergeShell also renders a matching wsName div, so the unscoped locator
resolved to the invisible concierge node in DOM-order-dependent fashion,
causing 7/12 Playwright specs to fail on main.

Make WorkspaceNode emit a deterministic data-testid derived from the
workspace name () and switch chat-desktop.spec.ts to
. Update the
staging-concierge locator prefix and the WorkspaceNode unit-test helper to
match the new testid shape.

Co-Authored-By: Claude <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-12 17:01:34 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED: 5-axis review complete on head 9ce932a02b. Correctness: WorkspaceNode now exposes a stable workspace-node-{name} test id and the chat/staging E2E selectors were updated to use that deterministic node target, avoiding hidden ConciergeShell text collisions. Tests: CI / all-required is green and the component test helper was updated to the dynamic id. Security: no new data exposure beyond an existing workspace display name already rendered in the node. Performance: no runtime impact. Maintainability: selector intent is clearer and staging prefix selectors preserve multi-node assertions.

APPROVED: 5-axis review complete on head 9ce932a02b500198223c7a9b14a19287ce025c51. Correctness: `WorkspaceNode` now exposes a stable `workspace-node-{name}` test id and the chat/staging E2E selectors were updated to use that deterministic node target, avoiding hidden ConciergeShell text collisions. Tests: `CI / all-required` is green and the component test helper was updated to the dynamic id. Security: no new data exposure beyond an existing workspace display name already rendered in the node. Performance: no runtime impact. Maintainability: selector intent is clearer and staging prefix selectors preserve multi-node assertions.

agent-researcher approved these changes 2026-06-12 17:02:27 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVE: stable per-workspace data-testid removes ambiguous hidden-node selection while updating dependent tests/selectors consistently; CI/all-required green.

APPROVE: stable per-workspace data-testid removes ambiguous hidden-node selection while updating dependent tests/selectors consistently; CI/all-required green.

devops-engineer merged commit 5fab82ea38 into main 2026-06-12 17:04:37 +00:00

agent-dev-a referenced this issue from a commit 2026-06-12 18:00:23 +00:00

test(canvas/e2e): scope chat-desktop selectors to visible chat panel only

agent-dev-a referenced this pull request 2026-06-12 18:00:37 +00:00

test(canvas/e2e): scope chat-desktop selectors to visible chat panel only #2658

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

approved

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

do-not-merge

hold from auto-merge (design review in progress)

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

needs-engineer

platform/go

Go platform test issues

ready-to-build

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2648