feat(chat): persist agent tool-chain across reload + nudge requester ack into My Chat (core#2636) #2637

Merged

devops-engineer merged 1 commits from feat/2636-decision-visible-and-tooltrace-persist into main 2026-06-12 10:57:13 +00:00

Conversation 1 Commits 1 Files Changed 9

+180 -33

core-devops commented 2026-06-12 10:52:29 +00:00

Member

Copy Link

Copy Source

Resolves both user-reported gaps from the request/approval flow.

1. Tool-chain progress survives refresh. The live feed is ephemeral; the agent reply's metadata.tool_trace was stored on the a2a_receive row but chat-history never selected it. Now the message store reads tool_trace and emits it on the agent ChatMessage; the canvas maps it to toolTrace and renders a collapsible "N tools used" chain under the agent bubble (ToolTraceChips). A reload re-shows the same steps.

2. Decisions are no longer silent. Respond/notification rides a background A2A turn that never renders in My Chat — so the agent woke, get_request'd, and ended its turn invisibly. The notification text now instructs the agent to acknowledge via send_message_to_user (which DOES render) when the outcome changes what it owes the user. The canvas decision-chip half stays tracked in #2636.

Tests: messagestore tool_trace carry + 5-col wire-order mock; ToolTraceChips collapse/expand/singular; full handlers + messagestore Go suites + canvas build + chat vitest all green.

Refs core#2636, #2614.

🤖 Generated with Claude Code

Resolves both user-reported gaps from the request/approval flow. **1. Tool-chain progress survives refresh.** The live feed is ephemeral; the agent reply's `metadata.tool_trace` was stored on the a2a_receive row but chat-history never selected it. Now the message store reads `tool_trace` and emits it on the agent ChatMessage; the canvas maps it to `toolTrace` and renders a collapsible "N tools used" chain under the agent bubble (ToolTraceChips). A reload re-shows the same steps. **2. Decisions are no longer silent.** Respond/notification rides a background A2A turn that never renders in My Chat — so the agent woke, `get_request`'d, and ended its turn invisibly. The notification text now instructs the agent to acknowledge via `send_message_to_user` (which DOES render) when the outcome changes what it owes the user. The canvas decision-chip half stays tracked in #2636. Tests: messagestore tool_trace carry + 5-col wire-order mock; ToolTraceChips collapse/expand/singular; full handlers + messagestore Go suites + canvas build + chat vitest all green. Refs core#2636, #2614. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

core-devops added 1 commit 2026-06-12 10:52:29 +00:00

feat(chat): persist+rehydrate agent tool-chain across reload; nudge requester ack into My Chat (core#2636) ... 3af3d3d121

Two user-reported gaps, both about request/agent activity being
invisible to the user:

1. Tool-chain progress vanished on refresh. The live progress feed
   (activityLog) is ephemeral local state; the agent reply persisted via
   the a2a_receive row carries metadata.tool_trace, but chat-history
   never SELECTed it. Now the message store reads tool_trace and emits
   it on the AGENT ChatMessage; the canvas maps tool_trace->toolTrace and
   renders a collapsible "N tools used" chain under the agent bubble
   (ToolTraceChips), so a reload re-shows the same steps.

2. Decisions felt silent. A respond/notification rides a background A2A
   turn that never renders in My Chat, so the agent woke, get_request'd,
   and ended its turn with nothing visible to the user. The notification
   text now tells the agent: if the outcome changes what you owe the
   user, acknowledge briefly with send_message_to_user (which DOES render
   in chat). The canvas decision-chip half is tracked separately in #2636.

Tests: messagestore tool_trace carry + wire-order (5-col mock);
ToolTraceChips collapse/expand/singular; full handlers + messagestore
green; canvas build + chat vitest green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-12 10:56:58 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on current head 3af3d3d121.

Full SOP / 5-axis review:

• Correctness: messagestore now selects and scans tool_trace, carries it only on the agent ChatMessage, and the canvas history hook maps server tool_trace into toolTrace so tool-chain progress survives reload. The notification copy also explicitly tells the requester agent when to use send_message_to_user, addressing the My Chat visibility gap without changing request state semantics.
• Robustness: null/empty tool_trace is omitted; existing chat-history pagination/order tests were updated and a focused agent-message trace test was added. Frontend component handles empty, singular, and expanded traces.
• Security: no new secret-bearing transport beyond the already persisted trace preview; React text rendering escapes the displayed tool/input strings. The notification wording avoids exposing hidden background turns to the user and instructs explicit user-visible acknowledgement only when owed.
• Performance: bounded per-message rendering; collapsed by default, so long traces do not expand the chat by default.
• Readability/QA: code is localized and tests cover backend carry-through plus canvas rendering. Required implementation CI is green (Platform (Go), Canvas, E2E API Smoke, Handlers Postgres, secret scan). Governance/security contexts are expected to clear with review approval.

APPROVED on current head 3af3d3d121efc1365521f5f772f104fc27c763ac. Full SOP / 5-axis review: - Correctness: `messagestore` now selects and scans `tool_trace`, carries it only on the agent `ChatMessage`, and the canvas history hook maps server `tool_trace` into `toolTrace` so tool-chain progress survives reload. The notification copy also explicitly tells the requester agent when to use `send_message_to_user`, addressing the My Chat visibility gap without changing request state semantics. - Robustness: null/empty `tool_trace` is omitted; existing chat-history pagination/order tests were updated and a focused agent-message trace test was added. Frontend component handles empty, singular, and expanded traces. - Security: no new secret-bearing transport beyond the already persisted trace preview; React text rendering escapes the displayed tool/input strings. The notification wording avoids exposing hidden background turns to the user and instructs explicit user-visible acknowledgement only when owed. - Performance: bounded per-message rendering; collapsed by default, so long traces do not expand the chat by default. - Readability/QA: code is localized and tests cover backend carry-through plus canvas rendering. Required implementation CI is green (`Platform (Go)`, `Canvas`, `E2E API Smoke`, `Handlers Postgres`, secret scan). Governance/security contexts are expected to clear with review approval.

devops-engineer merged commit b22a0854eb into main 2026-06-12 10:57:13 +00:00

core-devops referenced this issue from a commit 2026-06-12 11:14:25 +00:00

fix(chat): reconstruct agent tool-chain from agent_log rows when tool_trace is empty (core#2636 follow-up)

core-devops referenced this pull request 2026-06-12 11:14:38 +00:00

fix(chat): reconstruct agent tool-chain from agent_log rows when tool_trace empty (core#2636 follow-up) #2639

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

Labels

Clear labels

approved

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

do-not-merge

hold from auto-merge (design review in progress)

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

needs-engineer

platform/go

Go platform test issues

ready-to-build

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2637