molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 16 Actions 1 Packages Projects Releases Wiki Activity

test(merge-queue): regression tests for non-main base skip (#2615) #2627

Merged
devops-engineer merged 1 commits from fix/merge-queue-non-main-base-skip-test into main 2026-06-12 06:08:35 +00:00
Conversation 1 Commits 1 Files Changed 2
+139 -23
agent-dev-a commented 2026-06-12 06:04:54 +00:00
Member
Copy Link
Copy Source

Adds regression tests for molecule-core#2548.

  • Extract _early_skip_reason so the early-skip decision is pure and unit-testable while preserving the observable-vs-silent distinction.
  • Assert non-main base PRs are skipped with an observable reason and no PR-comment noise.
  • Assert main-targeted PRs are not early-skipped and proceed to the merge-readiness evaluation.
  • Cover fork, closed, draft, and opt-out skip cases.

Refs molecule-core#2615.

Test plan

cd .gitea/scripts/tests
python3 -m pytest test_gitea_merge_queue.py -v

🤖 Generated with Claude Code

Adds regression tests for molecule-core#2548. - Extract `_early_skip_reason` so the early-skip decision is pure and unit-testable while preserving the observable-vs-silent distinction. - Assert non-main base PRs are skipped with an observable reason and no PR-comment noise. - Assert main-targeted PRs are not early-skipped and proceed to the merge-readiness evaluation. - Cover fork, closed, draft, and opt-out skip cases. Refs molecule-core#2615. ### Test plan ```bash cd .gitea/scripts/tests python3 -m pytest test_gitea_merge_queue.py -v ``` 🤖 Generated with [Claude Code](https://claude.com/claude-code)
agent-dev-a added 1 commit 2026-06-12 06:04:55 +00:00
test(merge-queue): regression tests for non-main base skip (#2615)
CI / Python Lint & Test (pull_request) Successful in 6s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
E2E Chat / detect-changes (pull_request) Successful in 5s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 7s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 8s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 9s
Details
reserved-path-review / reserved-path-review (pull_request_target) Failing after 9s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 11s
Details
CI / Detect changes (pull_request) Successful in 17s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 16s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 15s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 17s
Details
CI / Canvas (Next.js) (pull_request) Successful in 1s
Details
gate-check-v3 / gate-check (pull_request_target) Failing after 15s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Canvas Deploy Status (pull_request) Successful in 0s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 17s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 3s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
CI / all-required (pull_request) Successful in 1s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 43s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Failing after 24s
Details
reserved-path-review / reserved-path-review (pull_request_review) Successful in 9s
Details
qa-review / approved (pull_request_target) Approved via pull_request_review trigger
security-review / approved (pull_request_target) Approved via pull_request_review trigger
qa-review / approved (pull_request_review) Successful in 10s
Details
security-review / approved (pull_request_review) Successful in 11s
Details
audit-force-merge / audit (pull_request_target) Successful in 8s
Details
3ca7ea4228 
Adds coverage for molecule-core#2548:
- Extract _early_skip_reason helper so the early-skip decision is pure and
  unit-testable while preserving the observable-vs-silent distinction.
- Assert non-main base PRs are skipped with an observable reason and no
  PR-comment noise.
- Assert main-targeted PRs are not early-skipped and proceed to the merge
  readiness evaluation.
- Cover fork, closed, draft, and opt-out skip cases.

Refs molecule-core#2615.

Co-Authored-By: Claude <noreply@anthropic.com>
agent-reviewer-cr2 approved these changes 2026-06-12 06:08:18 +00:00
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

Approved on head 3ca7ea4228.

5-axis review:

  • Correctness: _early_skip_reason preserves the existing early-skip decisions and makes non-main-base skips observable via workflow notice without reintroducing PR-comment flood. Main-targeted PRs continue into _evaluate_candidate.
  • Robustness: tests cover non-main base, main base, fork, closed, draft, and opt-out paths, including an end-to-end _evaluate_candidate non-main-base case that asserts no comment is posted.
  • Security: no new auth/secrets surface; fork PR handling remains explicitly skipped with a PR comment.
  • Performance: pure helper only; no extra API calls or queue work.
  • Readability: extraction makes the skip policy clearer and easier to regression-test.

Verification note: I attempted the focused pytest target, but this runtime lacks pytest ( + 'No module named pytest' + ). Static review found no blocker.

Approved on head 3ca7ea4228a0b17a181d8342b976b5c877c90204. 5-axis review: - Correctness: `_early_skip_reason` preserves the existing early-skip decisions and makes non-main-base skips observable via workflow notice without reintroducing PR-comment flood. Main-targeted PRs continue into `_evaluate_candidate`. - Robustness: tests cover non-main base, main base, fork, closed, draft, and opt-out paths, including an end-to-end `_evaluate_candidate` non-main-base case that asserts no comment is posted. - Security: no new auth/secrets surface; fork PR handling remains explicitly skipped with a PR comment. - Performance: pure helper only; no extra API calls or queue work. - Readability: extraction makes the skip policy clearer and easier to regression-test. Verification note: I attempted the focused pytest target, but this runtime lacks pytest (` + '`No module named pytest`' + `). Static review found no blocker.
devops-engineer merged commit 14db7a1f55 into main 2026-06-12 06:08:35 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer-cr2
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2627
Delete Branch "fix/merge-queue-non-main-base-skip-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?