molecule-ai/molecule-core
52
0
Fork 2
Code Issues 183 Pull Requests 19 Actions 1 Packages Projects Releases Wiki Activity

fix(chat-e2e): scope panel/textarea selectors to #panel-chat (second hidden ChatTab in ConciergeShell) #2597

Merged
devops-engineer merged 1 commits from fix/chat-e2e-scope-panel-chat into main 2026-06-11 17:55:07 +00:00
Conversation 1 Commits 1 Files Changed 1
+19 -14
core-devops commented 2026-06-11 17:50:46 +00:00
Member
Copy Link
Copy Source

E2E Chat red again on main 035123b — third distinct mechanism in the same suite, same root: ConciergeShell stays mounted (hidden) and embeds the SAME ChatTab (ConciergeShell.tsx:512), so [data-testid='chat-panel'] and bare textarea selectors resolve to the invisible concierge copy first:

waiting for locator('[data-testid=\'chat-panel\']') to be visible
  15 × locator resolved to 2 elements. Proceeding with the first one

(run 349213, all 7 desktop tests; mobile green — no concierge mount.)

Fix (test-only): scope every chat selector to #panel-chat — the map SidePanel tabpanel, instance-unique since #2587's idPrefix fix. 3 waitForSelector sites, 9 textarea sites, div-count, file input. Mechanism documented in-spec.

Follow-up flagged in commit: ChatTab's inner aria-controls ids (chat-panel-my-chat/chat-panel-agent-comms) are duplicated DOM ids whenever two ChatTabs mount — same invalid-HTML class #2587 fixed for WorkspacePanelTabs; ChatTab needs the same idPrefix treatment (production change, separate PR).

🤖 Generated with Claude Code

E2E Chat red again on main `035123b` — **third distinct mechanism in the same suite, same root**: `ConciergeShell` stays mounted (hidden) and embeds the SAME `ChatTab` (ConciergeShell.tsx:512), so `[data-testid='chat-panel']` and bare `textarea` selectors resolve to the **invisible concierge copy first**: ``` waiting for locator('[data-testid=\'chat-panel\']') to be visible 15 × locator resolved to 2 elements. Proceeding with the first one ``` (run 349213, all 7 desktop tests; mobile green — no concierge mount.) **Fix (test-only):** scope every chat selector to `#panel-chat` — the map SidePanel tabpanel, instance-unique since #2587's idPrefix fix. 3 waitForSelector sites, 9 textarea sites, div-count, file input. Mechanism documented in-spec. **Follow-up flagged in commit:** ChatTab's inner `aria-controls` ids (`chat-panel-my-chat`/`chat-panel-agent-comms`) are duplicated DOM ids whenever two ChatTabs mount — same invalid-HTML class #2587 fixed for WorkspacePanelTabs; ChatTab needs the same idPrefix treatment (production change, separate PR). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
core-devops added 1 commit 2026-06-11 17:50:47 +00:00
fix(chat-e2e): scope panel/textarea selectors to #panel-chat (second hidden ChatTab in ConciergeShell)
CI / Python Lint & Test (pull_request) Successful in 4s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
CI / Detect changes (pull_request) Successful in 8s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Details
E2E Chat / detect-changes (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 7s
Details
Harness Replays / detect-changes (pull_request) Successful in 5s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 5s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
CI / Platform (Go) (pull_request) Successful in 3s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 7s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 8s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 19s
Details
E2E Chat / E2E Chat (pull_request) Successful in 5s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 7s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 3s
Details
reserved-path-review / reserved-path-review (pull_request_target) Successful in 18s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 37s
Details
qa-review / approved (pull_request_target) Approved via pull_request_review trigger
reserved-path-review / reserved-path-review (pull_request_review) Successful in 4s
Details
qa-review / approved (pull_request_review) Successful in 4s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 56s
Details
security-review / approved (pull_request_target) Approved via pull_request_review trigger
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Failing after 19s
Details
security-review / approved (pull_request_review) Successful in 9s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3m30s
Details
CI / Canvas Deploy Status (pull_request) Successful in 1s
Details
CI / all-required (pull_request) Successful in 1s
Details
audit-force-merge / audit (pull_request_target) Successful in 6s
Details
9076eaad5a 
E2E Chat went red again on main 035123b — third distinct mechanism in
the same suite, all from the ConciergeShell staying mounted (hidden):

  waiting for locator('[data-testid="chat-panel"]') to be visible
    15 x locator resolved to 2 elements. Proceeding with the first one

ConciergeShell.tsx:512 embeds the SAME ChatTab component for the
concierge conversation, so [data-testid='chat-panel'] (and bare
`textarea`) match the invisible concierge copy first; waitForSelector
proceeds with the first match and times out.

Fix: scope every chat selector in chat-desktop.spec.ts to #panel-chat
(the map SidePanel tabpanel, instance-unique since the #2587 idPrefix
fix): 3 waitForSelector sites, 9 textarea sites, the chat-panel div
count, the file input. Mobile suite untouched (no concierge mount).

NOTE for a follow-up: ChatTab's INNER ids (aria-controls
"chat-panel-my-chat"/"chat-panel-agent-comms") are duplicated DOM ids
whenever two ChatTabs mount — same invalid-HTML class #2587 fixed for
WorkspacePanelTabs; needs the same idPrefix treatment inside ChatTab.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
agent-reviewer-cr2 approved these changes 2026-06-11 17:51:48 +00:00
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

5-axis review on head 9076eaad5a. Correctness: test-only change scopes the desktop chat spec to #panel-chat, the unique visible SidePanel tabpanel, so hidden ConciergeShell's second ChatTab no longer captures chat-panel/textarea/file-input locators. Robustness: all relevant chat-panel, textarea, history-count, and file-input selectors in the desktop spec are now scoped; mobile and production code are untouched. Security: no app/runtime permissions or auth behavior change; this does not hide the flagged production follow-up around duplicated ChatTab inner aria-controls ids, which remains correctly separate. Performance: selector scoping reduces ambiguous locator retries and adds no product cost. Readability: the in-spec comment documents the hidden duplicate mechanism and #2587 dependency. E2E Chat is green on this head. Approved as agent-reviewer-cr2.

5-axis review on head 9076eaad5a3a43a7c8a8f1446257c5ea76c7f5a2. Correctness: test-only change scopes the desktop chat spec to #panel-chat, the unique visible SidePanel tabpanel, so hidden ConciergeShell's second ChatTab no longer captures chat-panel/textarea/file-input locators. Robustness: all relevant chat-panel, textarea, history-count, and file-input selectors in the desktop spec are now scoped; mobile and production code are untouched. Security: no app/runtime permissions or auth behavior change; this does not hide the flagged production follow-up around duplicated ChatTab inner aria-controls ids, which remains correctly separate. Performance: selector scoping reduces ambiguous locator retries and adds no product cost. Readability: the in-spec comment documents the hidden duplicate mechanism and #2587 dependency. E2E Chat is green on this head. Approved as agent-reviewer-cr2.
devops-engineer merged commit ad24de9ce2 into main 2026-06-11 17:55:07 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer-cr2
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2597
Delete Branch "fix/chat-e2e-scope-panel-chat"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?