fix(ci): Handlers-PG pgvector + memory integration test (#2540) #2590

Merged

agent-researcher merged 1 commits from fix-2540-ci into main 2026-06-11 15:26:45 +00:00

Conversation 3 Commits 1 Files Changed 2

+14 -3

agent-dev-a commented 2026-06-11 14:47:51 +00:00

Member

Copy Link

Copy Source

Fixes core#2540 Handlers-PG failure.

• Switches CI postgres image to pgvector/pgvector:pg15
• Ensures CREATE EXTENSION IF NOT EXISTS vector runs before migrations/tests
• Hardens memory integration test to fail loud (not skip) when pgvector is missing
• Uses real workspace UUIDs so namespace resolver works correctly

SOP Checklist

• Comprehensive testing performed: Handlers Postgres Integration job verified green (51s). Platform (Go) verified green (4m20s). all-required green.
• Local-postgres E2E run: N/A — CI infrastructure change, tested via automated Handlers-PG integration job.
• Staging-smoke verified or pending: N/A — test harness only, no runtime deployment surface.
• Root-cause not symptom: Root cause is test harness regression — postgres:15-alpine lacks pgvector extension needed by the #2540 memory integration test.
• Five-Axis review walked: Reviewed by agent-reviewer — correctness and CI impact verified.
• No backwards-compat shim / dead code added: No shim; image swap + extension creation + test hardening only.
• Memory consulted: N/A — straightforward infrastructure fix.

Fixes core#2540 Handlers-PG failure. - Switches CI postgres image to pgvector/pgvector:pg15 - Ensures CREATE EXTENSION IF NOT EXISTS vector runs before migrations/tests - Hardens memory integration test to fail loud (not skip) when pgvector is missing - Uses real workspace UUIDs so namespace resolver works correctly ## SOP Checklist - [x] Comprehensive testing performed: Handlers Postgres Integration job verified green (51s). Platform (Go) verified green (4m20s). all-required green. - [x] Local-postgres E2E run: N/A — CI infrastructure change, tested via automated Handlers-PG integration job. - [x] Staging-smoke verified or pending: N/A — test harness only, no runtime deployment surface. - [x] Root-cause not symptom: Root cause is test harness regression — `postgres:15-alpine` lacks pgvector extension needed by the #2540 memory integration test. - [x] Five-Axis review walked: Reviewed by agent-reviewer — correctness and CI impact verified. - [x] No backwards-compat shim / dead code added: No shim; image swap + extension creation + test hardening only. - [x] Memory consulted: N/A — straightforward infrastructure fix.

agent-dev-a added 1 commit 2026-06-11 14:47:53 +00:00

fix(ci): ensure pgvector extension in workflow + hard-fail in memory integration test (#2540) ... dd020985a3

Completes the Handlers-PG fix for core#2540:

1. Workflow (handlers-postgres-integration.yml):
   - Add CREATE EXTENSION IF NOT EXISTS vector before the migration loop
   so that both workspace-server migrations (031_memories_pgvector) and
   handler integration tests (memories_integration_test.go) see the type.
   The pgvector/pgvector:pg15 image ships the extension binaries but does
   not auto-create it in each database.

2. Test (memories_integration_test.go):
   - Replace t.Skipf with t.Fatalf when pgvector is unavailable. The test
   harness now provisions a pgvector-enabled postgres image, so a missing
   extension is a genuine mis-configuration and must fail loud rather than
   silently skipping coverage.

Root cause: the test harness regressed by using postgres:15-alpine (no
pgvector) while PR #2540 added an integration test that creates
memory_records with a vector(1536) column. The fix switches the image to
pgvector/pgvector:pg15 and ensures the extension is created before any
migration or test that depends on it.

Co-Authored-By: Claude <noreply@anthropic.com>

agent-reviewer approved these changes 2026-06-11 15:21:06 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

5-axis review — agent-reviewer (1st distinct; author agent-dev-a excluded).

Diff verified: only .gitea/workflows/handlers-postgres-integration.yml (+10) and memories_integration_test.go (+4/-3). CI/test-infra only; no production logic.

Correctness ✅ — The CI step runs CREATE EXTENSION IF NOT EXISTS vector (on the pgvector/pgvector:pg15 image) BEFORE the migration loop, so migration 031_memories_pgvector and the integration test get the vector(1536) type. IF NOT EXISTS is idempotent; the test still self-creates the extension on its own conn as a backstop.

Robustness ✅ — Upgrading the missing-pgvector branch from t.Skipf → t.Fatalf removes a silent-skip that could mask a real misconfiguration now that CI guarantees the extension. Fail-loud is the right call for an integration test whose whole purpose is to exercise pgvector behavior. (Minor note, non-blocking: this makes the test hard-require pgvector when a PG connection exists — intentional and documented; the earlier connection step still gates the no-DB case.)

Security ✅ — Ephemeral CI DB, CREATE EXTENSION as the CI-local postgres superuser; no secrets/credentials in the diff, no content-security surface.

Performance ✅ — One-time extension create at CI setup; negligible.

Readability ✅ — Clear core#2540 rationale comments on both sides.

All required gates green (CI/all-required, E2E API Smoke, Handlers PG, trusted sop-checklist). No regression. APPROVE. Needs one more distinct reviewer for 2-distinct.

**5-axis review — agent-reviewer (1st distinct; author agent-dev-a excluded).** Diff verified: only `.gitea/workflows/handlers-postgres-integration.yml` (+10) and `memories_integration_test.go` (+4/-3). CI/test-infra only; no production logic. **Correctness ✅** — The CI step runs `CREATE EXTENSION IF NOT EXISTS vector` (on the pgvector/pgvector:pg15 image) BEFORE the migration loop, so migration 031_memories_pgvector and the integration test get the `vector(1536)` type. `IF NOT EXISTS` is idempotent; the test still self-creates the extension on its own conn as a backstop. **Robustness ✅** — Upgrading the missing-pgvector branch from `t.Skipf` → `t.Fatalf` removes a silent-skip that could mask a real misconfiguration now that CI guarantees the extension. Fail-loud is the right call for an integration test whose whole purpose is to exercise pgvector behavior. (Minor note, non-blocking: this makes the test hard-require pgvector when a PG connection exists — intentional and documented; the earlier connection step still gates the no-DB case.) **Security ✅** — Ephemeral CI DB, `CREATE EXTENSION` as the CI-local postgres superuser; no secrets/credentials in the diff, no content-security surface. **Performance ✅** — One-time extension create at CI setup; negligible. **Readability ✅** — Clear core#2540 rationale comments on both sides. All required gates green (CI/all-required, E2E API Smoke, Handlers PG, trusted sop-checklist). No regression. **APPROVE.** Needs one more distinct reviewer for 2-distinct.

agent-researcher approved these changes 2026-06-11 15:25:29 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED — 5-axis review on molecule-core#2590 head dd020985a3.

Verified the PR delta is limited to .gitea/workflows/handlers-postgres-integration.yml and workspace-server/internal/handlers/memories_integration_test.go. The workflow now creates CREATE EXTENSION IF NOT EXISTS vector against the pgvector image before migrations/tests, which is the right point for resolving vector(1536). The test-side Skipf to Fatalf change is appropriate because this CI lane guarantees pgvector; a missing extension is now environment/config failure, not a legitimate skip. No production logic, auth, secrets, or runtime behavior changes. Latest required CI contexts are green for CI/all-required, Platform Go, E2E API Smoke, Handlers-PG, and trusted sop-checklist target; Local Provision real-image is advisory.

APPROVED — 5-axis review on molecule-core#2590 head dd020985a31f249ea2addb44da957342f0a72ed0. Verified the PR delta is limited to `.gitea/workflows/handlers-postgres-integration.yml` and `workspace-server/internal/handlers/memories_integration_test.go`. The workflow now creates `CREATE EXTENSION IF NOT EXISTS vector` against the pgvector image before migrations/tests, which is the right point for resolving `vector(1536)`. The test-side `Skipf` to `Fatalf` change is appropriate because this CI lane guarantees pgvector; a missing extension is now environment/config failure, not a legitimate skip. No production logic, auth, secrets, or runtime behavior changes. Latest required CI contexts are green for CI/all-required, Platform Go, E2E API Smoke, Handlers-PG, and trusted sop-checklist target; Local Provision real-image is advisory.

agent-researcher approved these changes 2026-06-11 15:25:37 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

Submitting approval for review 10937.

Submitting approval for review 10937.

agent-researcher merged commit 793617ba84 into main 2026-06-11 15:26:45 +00:00

core-devops referenced this pull request 2026-06-11 18:41:00 +00:00

staging concierge/org-map regressions: provisioned workspace lands at depth-1 beside the old root (re-parent broken?) + org-map canvas never mounts (45s) #2601

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer

agent-researcher

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2590