molecule-ai/molecule-core
52
0
Fork 2
Code Issues 181 Pull Requests 51 Actions Packages Projects Releases Wiki Activity

test(provisioner): assert VolumeRemove NOT called on failed copy (data-loss guard #2490) #2558

Closed
agent-dev-a wants to merge 1 commits from fix/2490-add-volumeRemove-assertion into main
pull from: fix/2490-add-volumeRemove-assertion
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 1
+8
agent-dev-a commented 2026-06-10 23:01:53 +00:00
Member
Copy Link
Copy Source

Adds the explicit VolumeRemove(legacyName) not-called assertion to TestMigrateVolumeIfNeeded_CopyFails_PreservesLegacy. The existing test checked the volume survived via the fake client map, but did not verify the removal API was never invoked. This pins the data-loss guard against regression.

Refs #2490

Full module gate (all clean):

  • go build ./... ✅
  • go vet ./... ✅
  • go test ./... ✅
  • golangci-lint run ./... → 0 issues ✅
Adds the explicit VolumeRemove(legacyName) not-called assertion to TestMigrateVolumeIfNeeded_CopyFails_PreservesLegacy. The existing test checked the volume survived via the fake client map, but did not verify the removal API was never invoked. This pins the data-loss guard against regression. Refs #2490 **Full module gate (all clean):** - `go build ./...` ✅ - `go vet ./...` ✅ - `go test ./...` ✅ - `golangci-lint run ./...` → 0 issues ✅
agent-dev-a added 1 commit 2026-06-10 23:01:54 +00:00
test(provisioner): assert VolumeRemove NOT called on failed copy (data-loss guard #2490)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 11s
Details
CI / Python Lint & Test (pull_request) Successful in 9s
Details
CI / Detect changes (pull_request) Successful in 11s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 10s
Details
CI / Canvas Deploy Status (pull_request) Successful in 2s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 19s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 4s
Details
Harness Replays / detect-changes (pull_request) Successful in 9s
Details
E2E Chat / detect-changes (pull_request) Successful in 20s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 11s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 8s
Details
E2E Chat / E2E Chat (pull_request) Successful in 5s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 3s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 15s
Details
qa-review / approved (pull_request_target) Failing after 12s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 15s
Details
security-review / approved (pull_request_target) Failing after 11s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 11s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m4s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge user_tasks (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Creates Workspace (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Platform Agent (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 28s
Details
CI / Platform (Go) (pull_request) Successful in 2m16s
Details
CI / all-required (pull_request) Successful in 2s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 2m28s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge (compile+skip) (pull_request) Successful in 2m24s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 5m25s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Platform Boot (pull_request) Failing after 5m21s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Failing after 7m42s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Failing after 8m15s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
df53131871 
The existing TestMigrateVolumeIfNeeded_CopyFails_PreservesLegacy checked
that the legacy volume still exists in the fake client's map, but did not
explicitly verify that VolumeRemove(legacyName) was never invoked. Add
that assertion to pin the guard against regression: a non-zero copy exit
must leave the legacy volume intact for retry.

Refs #2490
agent-dev-a closed this pull request 2026-06-10 23:14:49 +00:00
Some checks are pending
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 11s
Details
CI / Python Lint & Test (pull_request) Successful in 9s
Details
CI / Detect changes (pull_request) Successful in 11s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 10s
Details
CI / Canvas Deploy Status (pull_request) Successful in 2s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 19s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 4s
Details
Harness Replays / detect-changes (pull_request) Successful in 9s
Details
E2E Chat / detect-changes (pull_request) Successful in 20s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 11s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 8s
Details
E2E Chat / E2E Chat (pull_request) Successful in 5s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 3s
Required
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 15s
Details
qa-review / approved (pull_request_target) Failing after 12s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 15s
Details
security-review / approved (pull_request_target) Failing after 11s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 11s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m4s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge user_tasks (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Creates Workspace (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Platform Agent (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 28s
Details
CI / Platform (Go) (pull_request) Successful in 2m16s
Details
CI / all-required (pull_request) Successful in 2s
Required
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 2m28s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge (compile+skip) (pull_request) Successful in 2m24s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 5m25s
Required
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Platform Boot (pull_request) Failing after 5m21s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Failing after 7m42s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Failing after 8m15s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request)
Required

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2558
Delete Branch "fix/2490-add-volumeRemove-assertion"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?