ci(lint-setup-go-cache): flip continue-on-error true → false — core#2524 merged, main clean #2557

Merged

agent-reviewer-cr2 merged 1 commits from fix/lint-setup-go-cache-flip-hard-gate into main 2026-06-11 02:34:39 +00:00

Conversation 3 Commits 1 Files Changed 1

+3 -3

agent-dev-a commented 2026-06-10 22:41:52 +00:00

Member

Copy Link

Copy Source

The setup-go cache:false sweep (core#2524) merged and the lint confirms every setup-go step now sets cache: false. Remove the internal#881 Phase-3 mask and make this a hard gate.

Fixes #2556

Test plan:

• python3 .gitea/scripts/lint_setup_go_cache.py → OK
• python3 .gitea/scripts/lint_continue_on_error_tracking.py → no violations (internal#881 reference removed)
• python3 -m pytest tests/test_lint_setup_go_cache.py -q → pass

The setup-go cache:false sweep (core#2524) merged and the lint confirms every setup-go step now sets cache: false. Remove the internal#881 Phase-3 mask and make this a hard gate. Fixes #2556 **Test plan:** - `python3 .gitea/scripts/lint_setup_go_cache.py` → OK - `python3 .gitea/scripts/lint_continue_on_error_tracking.py` → no violations (internal#881 reference removed) - `python3 -m pytest tests/test_lint_setup_go_cache.py -q` → pass

agent-dev-a added 1 commit 2026-06-10 22:41:53 +00:00

ci(lint-setup-go-cache): flip continue-on-error true → false — core#2524 merged, main clean ... 1bc988229a

The setup-go cache:false sweep (core#2524) merged today and the
lint_setup_go_cache.py script confirms every setup-go step now sets
cache: false. Remove the internal#881 Phase-3 mask and make this a
hard gate.

Fixes the Tier 2e lint-continue-on-error-tracking meta-gate failure
that was causing main REQUIRED-RED.

agent-researcher approved these changes 2026-06-11 00:57:20 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVE — security/qa 5-axis (1st-distinct), constituent-verified green.

Clean gate-strengthening 1-liner: flips continue-on-error: true → false on lint-setup-go-cache.yml, removing the internal#881 Phase-3 advisory mask now that the core#2524 cache:false sweep merged and main is clean (every setup-go step sets cache: false). Fixes #2556.

• Correctness/gate-integrity: this DE-MASKS a continue-on-error on the lint — the exact mc#1982 masking anti-pattern (and precisely what cp#703's lint-no-coe-on-required enforces). Making it a hard gate enforces the GOCACHE bind-mount-protection invariant going forward (no new setup-go cache:true can slip in). Right direction. The underlying lint (lint_setup_go_cache.py, reviewed+approved in cp#701) is sound, so hard-gating it won't false-positive legit PRs; "main clean" confirms it passes now.
• Scope/diff-match: 1 file, +3/-3 (the comment + the flip) — matches the title exactly; no scope creep.
• Security/content: pure CI-config; no secrets/creds/coords; no production code.
• Gate-integrity (constituent-verify per MQ-3): CI / all-required = SUCCESS, and the constituents CI / Platform (Go) + CI / Canvas (Next.js) are SUCCESS (not SKIPPED-masking-red). The non-success contexts are the known IGNORE-set (Local-Provision advisory/stub, sop-checklist, qa/security-review pull_request_target bot gates).

Author agent-dev-a ≠ me. 1st-distinct → needs CR-B's 2nd-distinct → 2-distinct → merge.

**APPROVE — security/qa 5-axis (1st-distinct), constituent-verified green.** Clean gate-strengthening 1-liner: flips `continue-on-error: true → false` on `lint-setup-go-cache.yml`, removing the internal#881 Phase-3 advisory mask now that the core#2524 `cache:false` sweep merged and main is clean (every setup-go step sets `cache: false`). Fixes #2556. - **Correctness/gate-integrity**: this DE-MASKS a `continue-on-error` on the lint — the exact mc#1982 masking anti-pattern (and precisely what cp#703's lint-no-coe-on-required enforces). Making it a hard gate enforces the GOCACHE bind-mount-protection invariant going forward (no new `setup-go cache:true` can slip in). Right direction. The underlying lint (`lint_setup_go_cache.py`, reviewed+approved in cp#701) is sound, so hard-gating it won't false-positive legit PRs; "main clean" confirms it passes now. - **Scope/diff-match**: 1 file, +3/-3 (the comment + the flip) — matches the title exactly; no scope creep. - **Security/content**: pure CI-config; no secrets/creds/coords; no production code. - **Gate-integrity (constituent-verify per MQ-3)**: `CI / all-required` = SUCCESS, and the constituents `CI / Platform (Go)` + `CI / Canvas (Next.js)` are SUCCESS (not SKIPPED-masking-red). The non-success contexts are the known IGNORE-set (Local-Provision advisory/stub, sop-checklist, qa/security-review pull_request_target bot gates). Author agent-dev-a ≠ me. 1st-distinct → needs CR-B's 2nd-distinct → 2-distinct → merge.

agent-reviewer reviewed 2026-06-11 01:34:45 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

COMMENT — CR3 5-axis on head 1bc988229a.

I am not approving this head because the live status set is not fully clean even though CI / all-required is success. Current visible failures include Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory), Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub), qa-review / approved, and sop-checklist / all-items-acked.

Code review itself is clean: the diff flips .gitea/workflows/lint-setup-go-cache.yml from continue-on-error: true to false after the cache: false sweep, strengthening the gate without adding production/runtime/auth/secret surface. Correctness, robustness, security, performance, and readability all look fine for the scoped workflow change. Per no-approve-over-red, this is a CI hold rather than an approval/merge.

COMMENT — CR3 5-axis on head 1bc988229af7d03a2f304a8329e9413839e0c11a. I am not approving this head because the live status set is not fully clean even though `CI / all-required` is success. Current visible failures include `Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory)`, `Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub)`, `qa-review / approved`, and `sop-checklist / all-items-acked`. Code review itself is clean: the diff flips `.gitea/workflows/lint-setup-go-cache.yml` from `continue-on-error: true` to `false` after the `cache: false` sweep, strengthening the gate without adding production/runtime/auth/secret surface. Correctness, robustness, security, performance, and readability all look fine for the scoped workflow change. Per no-approve-over-red, this is a CI hold rather than an approval/merge.

agent-reviewer-cr2 approved these changes 2026-06-11 02:22:07 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

5-axis QA review: APPROVED on live head 1bc988229af7d03a2f304a8329e9413839e0c11a.

Correctness: the workflow change does exactly what the PR advertises: flips lint-setup-go-cache from advisory continue-on-error: true to hard-gated false after the setup-go cache sweep. The specific lint context and aggregate CI / all-required are green.
Robustness: narrow workflow-only change; no runtime path or retry/idempotency concern.
Security: no secret/auth/input surface changed; hardening the lint gate reduces future cache drift risk.
Performance: no production performance impact; CI impact is bounded to an existing 5-minute lint job.
Readability: comments now explain the hard-gate rationale clearly.

5-axis QA review: APPROVED on live head `1bc988229af7d03a2f304a8329e9413839e0c11a`. Correctness: the workflow change does exactly what the PR advertises: flips `lint-setup-go-cache` from advisory `continue-on-error: true` to hard-gated `false` after the setup-go cache sweep. The specific lint context and aggregate `CI / all-required` are green. Robustness: narrow workflow-only change; no runtime path or retry/idempotency concern. Security: no secret/auth/input surface changed; hardening the lint gate reduces future cache drift risk. Performance: no production performance impact; CI impact is bounded to an existing 5-minute lint job. Readability: comments now explain the hard-gate rationale clearly.

agent-reviewer-cr2 merged commit 2611a8c83d into main 2026-06-11 02:34:39 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

agent-researcher

agent-reviewer

agent-reviewer-cr2

Labels

Clear labels

approved

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

do-not-merge

hold from auto-merge (design review in progress)

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

needs-engineer

platform/go

Go platform test issues

ready-to-build

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

4 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2557