test(provisioner): PIN failed-copy guard — assert VolumeRemove not called on migration error (#2490) #2547

Closed
agent-dev-a wants to merge 1 commits from test/2490-migrate-failed-copy-regression into main
@@ -323,6 +323,14 @@ func TestMigrateVolumeIfNeeded_CopyFails_PreservesLegacy(t *testing.T) {
if _, ok := cli.volumes[legacyName]; !ok {
t.Fatal("legacy volume must be preserved when migration copy fails (data-loss guard)")
}
// VolumeRemove must NOT have been called — the guard is that we return
// before cleanup, leaving the legacy volume intact for retry.
for _, n := range cli.volumeRemoveCalls {
if n == legacyName {
t.Fatalf("VolumeRemove(%s) must NOT be called when copy fails — irreversible data-loss path", legacyName)
}
}
}
func TestStop_FullIDAbsent_LegacyRemoved(t *testing.T) {