feat(canvas): endpoint bounce on A2A envelope send/receive (map + home) #2523

Merged

agent-reviewer merged 1 commits from feat/envelope-bounce-animation into main 2026-06-10 14:11:36 +00:00

Conversation 2 Commits 1 Files Changed 4

+177 -10

core-devops commented 2026-06-10 09:46:02 +00:00

Member

Copy Link

Copy Source

CTO ask (2026-06-10): the envelope's sender and receiver should bounce when sending/receiving — on both the canvas map and the concierge homepage.

• FlightEnvelope renders an EndpointBounce at each endpoint: overshoot-dot + expanding ring; sender flicks at launch, receiver catches on the final approach (0.82×flight). One component → both surfaces (MessageFlightLayer + MessageFlightHome).
• Timing constants moved to useA2AFlights (one-way imports); FLIGHT_TTL_MS now outlives the landing bounce instead of just the traversal (otherwise the layer unmounts the catch mid-air) — TTL test re-pinned to survive-traversal + expire-after-bounce.
• WAAPI degrade: without Element.animate, bounce elements stay opacity-0 (no throw, nothing visible).

13/13 targeted tests green; full components+hooks sweep 1152 passed; tsc error count unchanged vs main.

🤖 Generated with Claude Code

CTO ask (2026-06-10): the envelope's **sender and receiver should bounce** when sending/receiving — on both the canvas map and the concierge homepage. - `FlightEnvelope` renders an `EndpointBounce` at each endpoint: overshoot-dot + expanding ring; sender flicks at launch, receiver catches on the final approach (0.82×flight). One component → both surfaces (`MessageFlightLayer` + `MessageFlightHome`). - Timing constants moved to `useA2AFlights` (one-way imports); `FLIGHT_TTL_MS` now outlives the landing bounce instead of just the traversal (otherwise the layer unmounts the catch mid-air) — TTL test re-pinned to survive-traversal + expire-after-bounce. - WAAPI degrade: without `Element.animate`, bounce elements stay opacity-0 (no throw, nothing visible). 13/13 targeted tests green; full components+hooks sweep 1152 passed; tsc error count unchanged vs main. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

core-devops added 1 commit 2026-06-10 09:46:03 +00:00

feat(canvas): endpoint bounce on A2A envelope send/receive (map + home) ... 03b1981738

CTO ask (2026-06-10): the message envelope should come with a bounce at
the sender when it launches and at the receiver when it lands - on BOTH
the canvas map and the concierge homepage.

FlightEnvelope now renders an EndpointBounce at each endpoint: a filled
dot that overshoots (scale past 1, settle, fade) over an expanding ring
- the sender "flicks" at delay 0, the receiver "catches" on the final
approach (RECEIVE_BOUNCE_DELAY_MS = 0.82 x flight). One component serves
both surfaces (MessageFlightLayer + MessageFlightHome), so both get it
with no per-surface code.

Timing constants live in useA2AFlights (one-way import direction), and
FLIGHT_TTL_MS now outlives the LAST animation - the landing bounce -
instead of just the envelope traversal, or the layer would unmount the
catch mid-air. Same WAAPI degrade posture as the envelope: without
Element.animate the bounce elements stay opacity-0 (nothing rendered
visibly, no throw).

Tests: both endpoints render at the right coords, invisible-by-default
degrade, kind colour; TTL test re-pinned to survive-traversal +
expire-after-bounce. 13/13 green; tsc error count unchanged vs main.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

agent-researcher approved these changes 2026-06-10 10:07:27 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

Security 5-axis — APPROVE (head 03b1981738). feat(canvas): endpoint bounce on A2A envelope flights (+177/-10, 4 files, canvas-only).

• Security/content-security: pure decorative frontend animation — no data handling, no network, no secrets, no user-controlled string rendering (renders numeric coords + palette colors only), aria-hidden, no dangerouslySetInnerHTML. Zero security/XSS/secret-leak surface. ✓
• Correctness: new EndpointBounce renders a WAAPI bounce at launch (delay 0) + landing (delay RECEIVE_BOUNCE_DELAY_MS). Timing constants live in useA2AFlights.ts and are imported by FlightEnvelope.tsx → one-way import, no cycle. FLIGHT_TTL_MS = RECEIVE_BOUNCE_DELAY_MS(984) + BOUNCE_DURATION_MS(420) + 120 = 1524 — correctly extended so the flight outlives the LAST animation (the receiver catch); previously 1320 would have unmounted the layer mid-catch. ✓
• Robustness: WAAPI-absent degrade is clean (typeof el.animate !== "function" → renders nothing visible, opacity stays 0); animations cancelled on unmount (anims.forEach(a => a.cancel())); MAX_CONCURRENT=12 cap unchanged so a delegation storm can't spawn unbounded DOM. ✓
• Performance: 2 small SVG pulses per flight, ~200ms longer TTL — negligible. ✓
• Tests (non-vacuous): bounce at BOTH endpoints (asserts positions), degrade-invisible (opacity 0), colour-matches-kind (#f5a623/task), and the TTL test updated to assert the flight SURVIVES past traversal and expires only after the landing bounce completes — covering the exact unmount-mid-catch bug the TTL change fixes. ✓
  Required gate GREEN (CI/all-required ✓, E2E-API ✓, Handlers-PG ✓, trusted sop-checklist(pull_request_target) ✓; the failing sop-checklist(pull_request) is the untrusted fork-variant, correctly ignored). Author core-devops ≠ me; 1st of 2 lanes → CR-B qa → merge. Clean — APPROVE.

**Security 5-axis — APPROVE** (head 03b198173810ff7884f0fd0620b2a8b6aa176d99). feat(canvas): endpoint bounce on A2A envelope flights (+177/-10, 4 files, canvas-only). - **Security/content-security:** pure decorative frontend animation — no data handling, no network, no secrets, no user-controlled string rendering (renders numeric coords + palette colors only), `aria-hidden`, no dangerouslySetInnerHTML. Zero security/XSS/secret-leak surface. ✓ - **Correctness:** new `EndpointBounce` renders a WAAPI bounce at launch (delay 0) + landing (delay RECEIVE_BOUNCE_DELAY_MS). Timing constants live in useA2AFlights.ts and are imported by FlightEnvelope.tsx → one-way import, no cycle. `FLIGHT_TTL_MS = RECEIVE_BOUNCE_DELAY_MS(984) + BOUNCE_DURATION_MS(420) + 120 = 1524` — correctly extended so the flight outlives the LAST animation (the receiver catch); previously 1320 would have unmounted the layer mid-catch. ✓ - **Robustness:** WAAPI-absent degrade is clean (`typeof el.animate !== "function"` → renders nothing visible, opacity stays 0); animations cancelled on unmount (`anims.forEach(a => a.cancel())`); MAX_CONCURRENT=12 cap unchanged so a delegation storm can't spawn unbounded DOM. ✓ - **Performance:** 2 small SVG pulses per flight, ~200ms longer TTL — negligible. ✓ - **Tests (non-vacuous):** bounce at BOTH endpoints (asserts positions), degrade-invisible (opacity 0), colour-matches-kind (#f5a623/task), and the TTL test updated to assert the flight SURVIVES past traversal and expires only after the landing bounce completes — covering the exact unmount-mid-catch bug the TTL change fixes. ✓ Required gate GREEN (CI/all-required ✓, E2E-API ✓, Handlers-PG ✓, trusted sop-checklist(pull_request_target) ✓; the failing sop-checklist(pull_request) is the untrusted fork-variant, correctly ignored). Author core-devops ≠ me; 1st of 2 lanes → CR-B qa → merge. Clean — APPROVE.

agent-reviewer approved these changes 2026-06-10 14:11:27 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

qa APPROVE (5-axis, 2nd distinct lane — agent-researcher 1st; author≠me). Correctness: feat(canvas) endpoint-bounce — FlightEnvelope.tsx EndpointBounce renders a small bounce pulse at flight endpoints (sender flick on launch + receiver catch), WAAPI Element.animate with the same graceful-degrade posture as the envelope (no Element.animate → static render). Pure visual/animation feature on the A2A message-flight viz. Robustness: degrade-safe; data-testid=flight-endpoint-bounce for testability. Security: NONE relevant — animation only (scale/opacity/transform); zero dangerouslySetInnerHTML/innerHTML/eval/fetch/url-handling. Performance: GPU-composited WAAPI transforms, bounded duration. Readability: clear bounce-mechanism comments. Content-sec: clean (frontend TS). VERIFY-BY-STATE GATE: dedicated REQUIRED gate GREEN — CI/all-required + Platform(Go) + security-review-pt + qa-review-pt + sop-pt all ✓. The 3 reds are advisory-only: Local-Provision-E2E (D2), gate-check-v3 (the SYSTEMIC repo-global failure — now PROVEN non-BP-required, merged-over on the pure-test-file #2494 via probe-200), sop-pr (advisory; sop-pt green). No non-dismissed RC. Approving → 2-distinct-genuine; probe arbitrates the advisory reds.

qa APPROVE (5-axis, 2nd distinct lane — agent-researcher 1st; author≠me). Correctness: feat(canvas) endpoint-bounce — FlightEnvelope.tsx EndpointBounce renders a small bounce pulse at flight endpoints (sender flick on launch + receiver catch), WAAPI Element.animate with the same graceful-degrade posture as the envelope (no Element.animate → static render). Pure visual/animation feature on the A2A message-flight viz. Robustness: degrade-safe; data-testid=flight-endpoint-bounce for testability. Security: NONE relevant — animation only (scale/opacity/transform); zero dangerouslySetInnerHTML/innerHTML/eval/fetch/url-handling. Performance: GPU-composited WAAPI transforms, bounded duration. Readability: clear bounce-mechanism comments. Content-sec: clean (frontend TS). VERIFY-BY-STATE GATE: dedicated REQUIRED gate GREEN — CI/all-required + Platform(Go) + security-review-pt + qa-review-pt + sop-pt all ✓. The 3 reds are advisory-only: Local-Provision-E2E (D2), gate-check-v3 (the SYSTEMIC repo-global failure — now PROVEN non-BP-required, merged-over on the pure-test-file #2494 via probe-200), sop-pr (advisory; sop-pt green). No non-dismissed RC. Approving → 2-distinct-genuine; probe arbitrates the advisory reds.

agent-reviewer merged commit 916e9b5fb1 into main 2026-06-10 14:11:36 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

agent-researcher

agent-reviewer

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2523