molecule-ai/molecule-core
51
0
Fork 2
Code Issues 163 Pull Requests 161 Actions 6 Packages Projects Releases Wiki Activity

fix(e2e): add model field to peer-visibility workspace creates (closes #2212) #2462

Closed
agent-dev-a wants to merge 1 commits from fix/2212-peer-visibility-missing-model into main
pull from: fix/2212-peer-visibility-missing-model
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 1
+6 -2
agent-dev-a commented 2026-06-09 00:55:56 +00:00
Member
Copy Link
Copy Source

The E2E Peer Visibility test creates parent + sibling workspaces with runtime but no model. Staging now enforces MODEL_REQUIRED at workspace create (no platform-side default for claude-code), causing the test to fail before any peer-visibility assertion runs.

Fix:

  • Source tests/e2e/lib/model_slug.sh to get per-runtime model slugs.
  • Add explicit model= to parent (claude-code) and each sibling create payload, using pick_model_slug for auth-aware dispatch.

Single file: tests/e2e/test_peer_visibility_mcp_staging.sh (+6/-2).
Reuses existing model_slug.sh library (16/16 unit tests pass).

The E2E Peer Visibility test creates parent + sibling workspaces with runtime but no model. Staging now enforces MODEL_REQUIRED at workspace create (no platform-side default for claude-code), causing the test to fail before any peer-visibility assertion runs. Fix: - Source tests/e2e/lib/model_slug.sh to get per-runtime model slugs. - Add explicit model= to parent (claude-code) and each sibling create payload, using pick_model_slug for auth-aware dispatch. Single file: tests/e2e/test_peer_visibility_mcp_staging.sh (+6/-2). Reuses existing model_slug.sh library (16/16 unit tests pass).
agent-dev-a added 1 commit 2026-06-09 00:55:56 +00:00
fix(e2e): add model field to peer-visibility workspace creates (closes #2212)
sop-tier-check / tier-check (pull_request_target) Successful in 5s
Details
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 15s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
Details
E2E Chat / detect-changes (pull_request) Successful in 14s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 13s
Details
qa-review / approved (pull_request_target) Failing after 6s
Details
E2E Chat / E2E Chat (pull_request) Successful in 4s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 10s
Details
security-review / approved (pull_request_target) Failing after 5s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 5s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 12s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 13s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
Details
CI / all-required (pull_request) Successful in 3s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Successful in 32s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 10s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m2s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m30s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
5651e2def9 
The E2E Peer Visibility test creates parent + sibling workspaces with
runtime but no model. Staging now enforces MODEL_REQUIRED at workspace
create (no platform-side default for claude-code), causing the test to
fail before any peer-visibility assertion runs.

Fix:
- Source tests/e2e/lib/model_slug.sh (already used by
  test_staging_full_saas.sh) to get per-runtime model slugs.
- Add explicit model= to parent (claude-code) and each sibling create
  payload, using pick_model_slug for auth-aware dispatch.

This reuses the existing model-slug unit-tested library; no new
abstractions. The literal MCP list_peers assertions are unchanged.

SOP: /sop-ack engineer-ack as fullstack-engineer
Tested: bash syntax check + model_slug.sh unit suite (16/16 pass)
agent-dev-a closed this pull request 2026-06-09 00:59:33 +00:00
Some optional checks failed
sop-tier-check / tier-check (pull_request_target) Successful in 5s
Details
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 15s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
Details
E2E Chat / detect-changes (pull_request) Successful in 14s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 13s
Details
qa-review / approved (pull_request_target) Failing after 6s
Details
E2E Chat / E2E Chat (pull_request) Successful in 4s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Required
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 10s
Details
security-review / approved (pull_request_target) Failing after 5s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 5s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 12s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 13s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
Details
CI / all-required (pull_request) Successful in 3s
Required
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Successful in 32s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 10s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m2s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m30s
Required
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2462
Delete Branch "fix/2212-peer-visibility-missing-model"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?