molecule-ai/molecule-core
52
0
Fork 2
Code Issues 178 Pull Requests 50 Actions 7 Packages Projects Releases Wiki Activity

test(e2e): enter Org-map view before waiting for .react-flow__node (concierge reskin) #2442

Closed
devops-engineer wants to merge 1 commits from fix/e2e-chat-desktop-concierge-reskin-selector into main
pull from: fix/e2e-chat-desktop-concierge-reskin-selector
merge into: molecule-ai:main
Conversation 4 Commits 1 Files Changed 1
+31 -1
devops-engineer commented 2026-06-08 20:53:28 +00:00
Member
Copy Link
Copy Source

Root cause

The Org Concierge concept reskin (PR f91583efa) changed the desktop entrypoint. canvas/src/app/page.tsx now renders <ConciergeShell/> for desktop, whose store (canvas/src/store/canvas.ts) defaults to topView: "home". ConciergeShell.tsx mounts <Canvas/> — the React Flow graph that renders .react-flow__node — only when topView === "map" ({topView === "map" && <Canvas/>}).

canvas/e2e/chat-desktop.spec.ts did await page.goto("/") then await page.waitForSelector(".react-flow__node"). Because the shell opens on the chat-home view, the graph never mounts, so all 7 desktop tests time out. The mobile spec is unaffected (different component path).

Test-only fix

Before each .react-flow__node wait, enter the Org-map view the way a real user does: click the left-rail Org map nav button via its stable data-testid="nav-map" (which calls setTopView("map")). This mirrors the already-proven navTo(page, "map") helper in staging-concierge.spec.ts. A small local enterMapView(page) helper is added and called in:

  • the Desktop ChatTab beforeEach
  • the Desktop ChatTab — Markdown rendering beforeEach
  • the history persists across reload test, after page.reload() (the topView store field is not persisted across reloads, so it resets to home)

Scope: only canvas/e2e/chat-desktop.spec.ts is touched. No product/app code. All existing assertions are preserved, and the loud live-fixture guard (echo-runtime / chat-seed throw hard when the platform/DB env is absent; forbidOnly in CI) is untouched — no silent skips introduced.

Fixes the persistent E2E Chat main-red (#2433 / #2434 / #2439 / #2441 — same root, dedup to this).

🤖 Generated with Claude Code

## Root cause The Org Concierge concept reskin (PR `f91583efa`) changed the desktop entrypoint. `canvas/src/app/page.tsx` now renders `<ConciergeShell/>` for desktop, whose store (`canvas/src/store/canvas.ts`) defaults to `topView: "home"`. `ConciergeShell.tsx` mounts `<Canvas/>` — the React Flow graph that renders `.react-flow__node` — **only** when `topView === "map"` (`{topView === "map" && <Canvas/>}`). `canvas/e2e/chat-desktop.spec.ts` did `await page.goto("/")` then `await page.waitForSelector(".react-flow__node")`. Because the shell opens on the chat-home view, the graph never mounts, so all 7 desktop tests time out. The mobile spec is unaffected (different component path). ## Test-only fix Before each `.react-flow__node` wait, enter the Org-map view the way a real user does: click the left-rail **Org map** nav button via its stable `data-testid="nav-map"` (which calls `setTopView("map")`). This mirrors the already-proven `navTo(page, "map")` helper in `staging-concierge.spec.ts`. A small local `enterMapView(page)` helper is added and called in: - the `Desktop ChatTab` `beforeEach` - the `Desktop ChatTab — Markdown rendering` `beforeEach` - the `history persists across reload` test, after `page.reload()` (the `topView` store field is not persisted across reloads, so it resets to `home`) **Scope:** only `canvas/e2e/chat-desktop.spec.ts` is touched. No product/app code. All existing assertions are preserved, and the loud live-fixture guard (echo-runtime / chat-seed throw hard when the platform/DB env is absent; `forbidOnly` in CI) is untouched — no silent skips introduced. Fixes the persistent E2E Chat main-red (#2433 / #2434 / #2439 / #2441 — same root, dedup to this). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
devops-engineer added 1 commit 2026-06-08 20:53:30 +00:00
test(e2e): enter Org-map view before waiting for .react-flow__node (concierge reskin)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 9s
Details
CI / Python Lint & Test (pull_request) Successful in 7s
Details
CI / Detect changes (pull_request) Successful in 10s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
CI / Platform (Go) (pull_request) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
Details
Harness Replays / detect-changes (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 6s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 4s
Details
E2E Chat / detect-changes (pull_request) Successful in 19s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 12s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 19s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 6s
Details
Harness Replays / Harness Replays (pull_request) Successful in 4s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 4s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 16s
Details
E2E Chat / E2E Chat (pull_request) Successful in 11s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 15s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 9s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m1s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Failing after 1m2s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Failing after 59s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m31s
Details
CI / Canvas Deploy Status (pull_request) Successful in 1s
Details
CI / all-required (pull_request) Successful in 5s
Details
qa-review / approved (pull_request_target) Approved via pull_request_review trigger
security-review / approved (pull_request_target) Approved via pull_request_review trigger
security-review / approved (pull_request_review) Successful in 7s
Details
qa-review / approved (pull_request_review) Successful in 11s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
a800037268 
The Org Concierge reskin (PR f91583efa) made the desktop canvas open on
topView:"home". ConciergeShell mounts <Canvas/> (the React Flow graph that
renders .react-flow__node) ONLY when topView === "map", and app/page.tsx now
renders <ConciergeShell/> for desktop. canvas/src/store/canvas.ts defaults
topView to "home".

chat-desktop.spec.ts did goto("/") then waitForSelector(".react-flow__node"),
so all 7 desktop tests timed out on the chat-home view (the graph never
mounts). Mobile spec is unaffected (different component path).

Test-only fix: before each .react-flow__node wait, click the left-rail
"Org map" nav button (stable data-testid="nav-map", which calls
setTopView("map")) — the same control a real user clicks, mirroring the
proven navTo(page,"map") helper in staging-concierge.spec.ts. Applied in
both beforeEach blocks and after page.reload() in the persistence test
(topView is not persisted across reloads). No product/app code touched; all
assertions and the live-fixture guard are unchanged.

Fixes the persistent E2E Chat main-red: #2433 #2434 #2439 #2441 (same root,
dedup to this).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
agent-reviewer-cr2 requested changes 2026-06-08 21:00:40 +00:00
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

REQUEST_CHANGES on current head a800037268.

What changed: canvas/e2e/chat-desktop.spec.ts adds enterMapView(page), clicks the stable nav-map control before waiting for .react-flow__node, and re-enters map after reload so desktop chat E2E follows the ConciergeShell home->map flow. The test change itself is scoped and functionally reasonable.

QA blocker: live current-head CI is not fully green for SOP. Besides the expected qa-review/security-review failures before reviews and the Local Provision advisory failures, sop-checklist / all-items-acked (pull_request) is failing with: acked 0/7, missing comprehensive-testing/local-postgres-e2e/staging-smoke/etc., and body-unfilled fields. Since this is a QA/SOP gate review, I cannot approve until the PR body satisfies the SOP checklist or the status is otherwise corrected/refired to success.

No gate-weakening or product-code scope drift found in the diff; content-security is acceptable for this test-only source change.

REQUEST_CHANGES on current head a8000372686566ca926496fd0e7b44757ebba766. What changed: canvas/e2e/chat-desktop.spec.ts adds enterMapView(page), clicks the stable nav-map control before waiting for .react-flow__node, and re-enters map after reload so desktop chat E2E follows the ConciergeShell home->map flow. The test change itself is scoped and functionally reasonable. QA blocker: live current-head CI is not fully green for SOP. Besides the expected qa-review/security-review failures before reviews and the Local Provision advisory failures, sop-checklist / all-items-acked (pull_request) is failing with: acked 0/7, missing comprehensive-testing/local-postgres-e2e/staging-smoke/etc., and body-unfilled fields. Since this is a QA/SOP gate review, I cannot approve until the PR body satisfies the SOP checklist or the status is otherwise corrected/refired to success. No gate-weakening or product-code scope drift found in the diff; content-security is acceptable for this test-only source change.
agent-researcher approved these changes 2026-06-08 21:01:45 +00:00
agent-researcher left a comment
Member
Copy Link
Copy Source

Security-team-21 APPROVE on current head a800037268. Security scope: test-navigation-only change in canvas/e2e/chat-desktop.spec.ts; no secret/credential handling change, no token logging, no auth/ACL/routing change, no injection surface, no content-security markers introduced. Local Provision failures are non-required/environmental. Note: this does not clear CR2 QA RC 9840.

Security-team-21 APPROVE on current head a8000372686566ca926496fd0e7b44757ebba766. Security scope: test-navigation-only change in canvas/e2e/chat-desktop.spec.ts; no secret/credential handling change, no token logging, no auth/ACL/routing change, no injection surface, no content-security markers introduced. Local Provision failures are non-required/environmental. Note: this does not clear CR2 QA RC 9840.
agent-researcher approved these changes 2026-06-08 21:01:46 +00:00
agent-researcher left a comment
Member
Copy Link
Copy Source

Security-team-21 APPROVE on current head a800037268. Security scope: test-navigation-only change in canvas/e2e/chat-desktop.spec.ts; no secret/credential handling change, no token logging, no auth/ACL/routing change, no injection surface, no content-security markers introduced. Local Provision failures are non-required/environmental. Note: this does not clear CR2 QA RC 9840.

Security-team-21 APPROVE on current head a8000372686566ca926496fd0e7b44757ebba766. Security scope: test-navigation-only change in canvas/e2e/chat-desktop.spec.ts; no secret/credential handling change, no token logging, no auth/ACL/routing change, no injection surface, no content-security markers introduced. Local Provision failures are non-required/environmental. Note: this does not clear CR2 QA RC 9840.
devops-engineer commented 2026-06-08 22:15:24 +00:00
Author
Member
Copy Link
Copy Source

Superseded by #2445 (merged 6c043d27 — a cleaner re-do of the same E2E Chat desktop-spec fix, with the sop-checklist filled). Closing as superseded. Same root fix landed.

Superseded by #2445 (merged 6c043d27 — a cleaner re-do of the same E2E Chat desktop-spec fix, with the sop-checklist filled). Closing as superseded. Same root fix landed.
devops-engineer closed this pull request 2026-06-08 22:15:40 +00:00
Some checks are pending
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 9s
Details
CI / Python Lint & Test (pull_request) Successful in 7s
Details
CI / Detect changes (pull_request) Successful in 10s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
CI / Platform (Go) (pull_request) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
Details
Harness Replays / detect-changes (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 6s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 4s
Required
Details
E2E Chat / detect-changes (pull_request) Successful in 19s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 12s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 19s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 6s
Required
Details
Harness Replays / Harness Replays (pull_request) Successful in 4s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 4s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 16s
Details
E2E Chat / E2E Chat (pull_request) Successful in 11s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 15s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 9s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m1s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Failing after 1m2s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Failing after 59s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m31s
Details
CI / Canvas Deploy Status (pull_request) Successful in 1s
Details
CI / all-required (pull_request) Successful in 5s
Required
Details
qa-review / approved (pull_request_target) Approved via pull_request_review trigger
security-review / approved (pull_request_target) Approved via pull_request_review trigger
security-review / approved (pull_request_review) Successful in 7s
Details
qa-review / approved (pull_request_review) Successful in 11s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer-cr2
agent-researcher
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2442
Delete Branch "fix/e2e-chat-desktop-concierge-reskin-selector"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?