PR #225 introduced the AND-composition clause evaluator. PR #231
patched the per-team case-pattern matching but did NOT fix the
underlying clause-splitter bug. This PR fixes the actual root cause
behind issue #229.
Root cause (.gitea/scripts/sop-tier-check.sh ~line 289):
_clause=$(echo "$_raw_clause" \
| tr -d '()' \
| tr ',' '\n' \
| tr -d '[:space:]' \
| grep -v '^$')
`tr -d '[:space:]'` strips the newlines that `tr ',' '\n'` just
inserted. For tier:low (expression "engineers,managers,ceo") the
intermediate value is:
engineers\nmanagers\nceo
then `tr -d '[:space:]'` flattens it to:
engineersmanagersceo
The for-loop iterates ONCE over this single bogus token. The case
pattern `*engineersmanagersceo*` never matches APPROVER_TEAMS values
like " managers ", so EVERY tier:low PR fails:
::error::clause [engineers/managers/ceo]: FAIL — no approving
reviewer belongs to any of these teamsengineersmanagersceo
::error::sop-tier-check FAILED for tier:low
(Note: the missing separators in the error string `teamsengineersmanagersceo`
were a SECOND, masked bug — `_clause_names="${_clause_names:+, }${_t}"`
overwrites the variable on every iteration instead of appending. With
the splitter bug, the inner loop only ran once so the overwrite was
invisible. Fixing the splitter unmasks the accumulator bug, so we fix
both atomically.)
Fix:
_no_parens=${_raw_clause//[()]/}
_clause=${_no_parens//,/ } # comma -> space, bash word-split iterates
# Append, don't overwrite:
_clause_names="${_clause_names}${_clause_names:+, }${_t}"
_passed_clauses="${_passed_clauses}${_passed_clauses:+, }$_label"
_failed_clauses="${_failed_clauses}${_failed_clauses:+, }$_label"
Per-tier policy is UNCHANGED — this is a parser fix, not a policy
relaxation:
tier:low — engineers,managers,ceo (OR-set, ANY ONE suffices)
tier:medium — managers AND engineers AND qa???,security???
tier:high — ceo
Test: .gitea/scripts/tests/test_sop_tier_check_clause_split.sh
asserts the splitter, accumulators, and end-to-end OR-gate matching
against APPROVER_TEAMS=" managers " (the exact shape PRs #233-238 hit).
7/7 pass on the new logic.
Refs: #229, supersedes attempted fix in #231 for the same root cause.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
