fix(registry): allow pending-DNS platform tunnel URL at register (#36 register half) #2425

Merged

devops-engineer merged 1 commits from fix/validate-agent-url-pending-tunnel into main 2026-06-08 04:44:04 +00:00

Conversation 2 Commits 1 Files Changed 2

+76 -3

devops-engineer commented 2026-06-08 04:31:34 +00:00

Member

Copy Link

Copy Source

The REGISTER half of #36 (provision half = Hetzner location-failover, cp#619). Cross-cloud workspaces register advertising their per-workspace Cloudflare tunnel hostname (ws-.); the DNS record is eventually-consistent and a FAST-booting box (Hetzner ~1s) registers before it propagates -> validateAgentURL net.LookupIP fails -> 400 -> the runtime does NOT retry a 4xx -> agent_card never lands. AWS/GCP boot slow enough to miss the race (only the fast cloud broke). Diagnosed live: faithful Hetzner repro boxes 400 against a WARM tenant with 'hostname ... cannot be resolved (DNS error)'. Fix: on DNS failure, allow the hostname in SaaS mode IFF it is a platform-tunnel hostname (ws- prefix under the platform domain, MOLECULE_APP_DOMAIN default moleculesai.app) -- not an SSRF vector (only the platform controls that domain; metadata/loopback blocks still apply once it resolves). Self-hosted keeps the strict block. SECURITY-sensitive (SSRF validator) -- see the scoped rationale + tests. Generated with Claude Code

The REGISTER half of #36 (provision half = Hetzner location-failover, cp#619). Cross-cloud workspaces register advertising their per-workspace Cloudflare tunnel hostname (ws-<id>.<appDomain>); the DNS record is eventually-consistent and a FAST-booting box (Hetzner ~1s) registers before it propagates -> validateAgentURL net.LookupIP fails -> 400 -> the runtime does NOT retry a 4xx -> agent_card never lands. AWS/GCP boot slow enough to miss the race (only the fast cloud broke). Diagnosed live: faithful Hetzner repro boxes 400 against a WARM tenant with 'hostname ... cannot be resolved (DNS error)'. Fix: on DNS failure, allow the hostname in SaaS mode IFF it is a platform-tunnel hostname (ws- prefix under the platform domain, MOLECULE_APP_DOMAIN default moleculesai.app) -- not an SSRF vector (only the platform controls that domain; metadata/loopback blocks still apply once it resolves). Self-hosted keeps the strict block. SECURITY-sensitive (SSRF validator) -- see the scoped rationale + tests. Generated with Claude Code

devops-engineer added 1 commit 2026-06-08 04:31:36 +00:00

fix(registry): allow pending-DNS platform tunnel URL at register (#36/#2421) ... 644734bb7c

Cross-cloud workspaces (e.g. Hetzner under a GCP tenant) register
advertising their per-workspace Cloudflare tunnel hostname
ws-<id>.<appDomain>. That DNS record is eventually-consistent, and a
FAST-booting box (a Hetzner cpx reports 'workspace ready after ~1s')
registers BEFORE it propagates → validateAgentURL's net.LookupIP fails →
the handler returns 400 → and the runtime does NOT retry a 4xx → so
agent_card never lands and the agent never comes online. AWS/GCP boot
slowly enough to miss the race, which is why ONLY the fast cloud broke.

Diagnosed live: faithful Hetzner repro boxes register against a warm
tenant and still 400 with
  {"error":"hostname \"ws-...\" cannot be resolved (DNS error)..."}

Fix: when DNS resolution fails, allow the hostname through in SaaS mode iff
it is a platform-tunnel hostname (ws-<id> under the platform's own domain,
MOLECULE_APP_DOMAIN default moleculesai.app). Such a hostname is NOT an
SSRF vector — only the platform controls DNS there, so an attacker cannot
point it at 169.254/127/private space, and the unconditional metadata/
loopback blocks still apply once it resolves. Restores the pre-#1130
'let an unresolvable platform URL through' behaviour, scoped to the
trusted tunnel domain. Self-hosted keeps the strict block.

This is the register half of #36; the provision half (Hetzner location
capacity failover) shipped in cp#619.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

devops-engineer added the tier:low label 2026-06-08 04:35:50 +00:00

devops-engineer commented 2026-06-08 04:35:52 +00:00

Author

Member

Copy Link

Copy Source

/qa-recheck

/qa-recheck

devops-engineer commented 2026-06-08 04:37:38 +00:00

Author

Member

Copy Link

Copy Source

/security-recheck

/security-recheck

devops-engineer merged commit dbdced6aa9 into main 2026-06-08 04:44:04 +00:00

devops-engineer referenced this issue from a commit 2026-06-08 05:53:24 +00:00

fix(registry): case-fold + trim-dot in isPlatformTunnelHostname (#2425 follow-up)

devops-engineer referenced this pull request 2026-06-08 05:53:24 +00:00

fix(registry): case-fold + trim-dot in isPlatformTunnelHostname (#2425 follow-up) #2429

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label tier:low

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2425