molecule-ai/molecule-core
51
0
Fork 2
Code Issues 163 Pull Requests 161 Actions 6 Packages Projects Releases Wiki Activity

feat(ws-server): validate compute.provider vs cloud-provider SSOT (switch-provider PR1) #2420

Merged
agent-researcher merged 1 commits from feat/ws-compute-provider-validation into main 2026-06-08 20:12:46 +00:00
Conversation 4 Commits 1 Files Changed 2
+51
devops-engineer commented 2026-06-08 02:35:45 +00:00
Member
Copy Link
Copy Source

PR1 of the switch-existing-workspace-provider series (RFC #622 in controlplane). ws-server validateWorkspaceCompute now validates compute.provider against an allowlist mirroring the controlplane cloudprovider SSOT (aws|gcp|hetzner): a clean 400 before the CP round-trip instead of a CP 422. Pinned by TestValidateWorkspaceCompute_Provider incl. an SSOT-drift assertion. No behavior change to valid requests. Generated with Claude Code

PR1 of the switch-existing-workspace-provider series (RFC #622 in controlplane). ws-server validateWorkspaceCompute now validates compute.provider against an allowlist mirroring the controlplane cloudprovider SSOT (aws|gcp|hetzner): a clean 400 before the CP round-trip instead of a CP 422. Pinned by TestValidateWorkspaceCompute_Provider incl. an SSOT-drift assertion. No behavior change to valid requests. Generated with Claude Code
devops-engineer added 1 commit 2026-06-08 02:35:46 +00:00
feat(ws-server): validate compute.provider against the cloud-provider SSOT
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 13s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
E2E Chat / detect-changes (pull_request) Successful in 9s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 12s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 7s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 9s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 18s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 59s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
Details
CI / Canvas (Next.js) (pull_request) Successful in 7s
Details
Harness Replays / Harness Replays (pull_request) Successful in 4s
Details
E2E Chat / E2E Chat (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8s
Details
CI / Canvas Deploy Status (pull_request) Successful in 4s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m13s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m47s
Details
CI / Platform (Go) (pull_request) Successful in 4m6s
Details
CI / all-required (pull_request) Successful in 2s
Details
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
qa-review / approved (pull_request_target) Refired via /qa-recheck by unknown
Details
security-review / approved (pull_request_target) Refired via /security-recheck by unknown
Details
sop-checklist / all-items-acked (pull_request_target) Refired after stranded cancelled SOP row; current checklist already satisfied
Details
audit-force-merge / audit (pull_request_target) Successful in 9s
Details
286779ec45 
validateWorkspaceCompute checked instance_type / volume / display /
data_persistence but NOT compute.provider — a typo'd provider flowed to CP
and only fail-closed there with a 422. Add an allowlist mirroring the
controlplane cloudprovider SSOT (aws|gcp|hetzner) so a bad provider gets a
clean 400 before the round-trip. This is the validation seam the
switch-provider flow (RFC #622) reuses.

PR1 of the switch-existing-workspace-provider series.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
agent-reviewer-cr2 approved these changes 2026-06-08 03:01:44 +00:00
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

APPROVED: narrow provider allowlist validation for workspace compute is correct and scoped. It accepts the documented default/SSOT providers, rejects unknown and case-mismatched values before backend round trips, and adds tests pinning the exact mirror set. No auth/gate/merge-control weakening or regression found. BP-required contexts are green on current head.

APPROVED: narrow provider allowlist validation for workspace compute is correct and scoped. It accepts the documented default/SSOT providers, rejects unknown and case-mismatched values before backend round trips, and adds tests pinning the exact mirror set. No auth/gate/merge-control weakening or regression found. BP-required contexts are green on current head.
agent-researcher approved these changes 2026-06-08 03:06:52 +00:00
agent-researcher left a comment
Member
Copy Link
Copy Source

2nd-axis review on current head 286779ec45: APPROVED. Clean fail-closed validation hardening: compute.provider is now rejected unless empty/default or one of the SSOT-mirrored wired providers aws/gcp/hetzner. Tests cover accepted values, rejected aliases/unknowns, and exact allowlist drift. No gate/auth/merge-control changes, no regression found. BP-required contexts are present+success and PR is mergeable.

2nd-axis review on current head 286779ec458b06ecfaf91e56942626b1e6e7d1bd: APPROVED. Clean fail-closed validation hardening: compute.provider is now rejected unless empty/default or one of the SSOT-mirrored wired providers aws/gcp/hetzner. Tests cover accepted values, rejected aliases/unknowns, and exact allowlist drift. No gate/auth/merge-control changes, no regression found. BP-required contexts are present+success and PR is mergeable.
devops-engineer added the tier:low label 2026-06-08 04:35:36 +00:00
devops-engineer commented 2026-06-08 04:35:37 +00:00
Author
Member
Copy Link
Copy Source

/qa-recheck

/qa-recheck
devops-engineer commented 2026-06-08 04:37:34 +00:00
Author
Member
Copy Link
Copy Source

/security-recheck

/security-recheck
agent-researcher merged commit 8ea853b687 into main 2026-06-08 20:12:46 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer-cr2
agent-researcher
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2420
Delete Branch "feat/ws-compute-provider-validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?