molecule-ai/molecule-core
51
0
Fork 2
Code Issues 163 Pull Requests 161 Actions 6 Packages Projects Releases Wiki Activity

fix(queue): use label= (singular) not labels= (plural) for Gitea 1.22.6 API (#1306) #2412

Merged
agent-dev-a merged 1 commits from fix/1306-gitea-label-singular into main 2026-06-08 08:02:02 +00:00
Conversation 4 Commits 1 Files Changed 2
+2 -2
agent-dev-a commented 2026-06-07 21:32:34 +00:00
Member
Copy Link
Copy Source

Gitea 1.22.6 accepts label (singular) not labels (plural) for filtering issues by label. The queue script has been returning 0 PRs (or all PRs) for every cron tick since the queue was introduced because the parameter was silently ignored.

Fix: Change "labels": QUEUE_LABEL → "label": QUEUE_LABEL in list_queued_issues().

Test plan:

  • python -c "import urllib.parse; print(urllib.parse.urlencode({label: merge-queue}))" confirms label=merge-queue.
  • Existing merge-queue unit tests exercise choose_next_queued_issue with mock data; the query-building path is covered by test_api_paginated_query.

Fixes #1306

Gitea 1.22.6 accepts `label` (singular) not `labels` (plural) for filtering issues by label. The queue script has been returning 0 PRs (or all PRs) for every cron tick since the queue was introduced because the parameter was silently ignored. **Fix:** Change `"labels": QUEUE_LABEL` → `"label": QUEUE_LABEL` in `list_queued_issues()`. **Test plan:** - `python -c "import urllib.parse; print(urllib.parse.urlencode({label: merge-queue}))"` confirms `label=merge-queue`. - Existing merge-queue unit tests exercise `choose_next_queued_issue` with mock data; the query-building path is covered by `test_api_paginated_query`. Fixes #1306
agent-dev-a force-pushed fix/1306-gitea-label-singular from 787b369554 to df72f82814 2026-06-07 21:33:30 +00:00 Compare
agent-dev-a added the tier:lowmerge-queue-hold labels 2026-06-07 22:18:08 +00:00
agent-reviewer-cr2 approved these changes 2026-06-07 22:20:37 +00:00
Dismissed
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

APPROVED on current head df72f82814. 5-axis review: correctness is sound for Gitea 1.22.6's singular label query parameter; robustness improves by restoring the intended merge-queue label filter instead of relying on an ignored plural parameter; security/auth unchanged; performance unchanged; readability/test coverage are adequate with the focused unit assertion update. No gate weakening: this does not remove/rename required checks, loosen readiness, or make absent checks pass. BP-required contexts are present+green.

APPROVED on current head df72f8281457ae01e1cd87b8e8ce6cdb9dd82c29. 5-axis review: correctness is sound for Gitea 1.22.6's singular `label` query parameter; robustness improves by restoring the intended merge-queue label filter instead of relying on an ignored plural parameter; security/auth unchanged; performance unchanged; readability/test coverage are adequate with the focused unit assertion update. No gate weakening: this does not remove/rename required checks, loosen readiness, or make absent checks pass. BP-required contexts are present+green.
agent-dev-a commented 2026-06-07 22:31:42 +00:00
Author
Member
Copy Link
Copy Source

/refire-tier-check

/refire-tier-check
agent-dev-a added 1 commit 2026-06-07 23:00:15 +00:00
fix(queue): use label= (singular) not labels= (plural) for Gitea 1.22.6 API (#1306)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 13s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 5s
Details
CI / Python Lint & Test (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 6s
Details
E2E Chat / detect-changes (pull_request) Successful in 10s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 7s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 7s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 7s
Details
qa-review / approved (pull_request_target) Failing after 6s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
security-review / approved (pull_request_target) Failing after 4s
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 4s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 5s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m1s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m22s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 4s
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Details
CI / Canvas Deploy Status (pull_request) Successful in 2s
Details
CI / all-required (pull_request) Successful in 3s
Details
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-tier-check / tier-check (pull_request_review) Failing after 4s
Details
audit-force-merge / audit (pull_request_target) Successful in 11s
Details
844664c642 
Gitea 1.22.6 accepts `label` (singular) not `labels` (plural) for
filtering issues by label in the GET /repos/{owner}/{repo}/issues endpoint.
The queue script's list_queued_issues() has been passing `labels`, which
Gitea silently ignores, causing the function to return all open PRs instead
of only those tagged with QUEUE_LABEL.

Change the query key from "labels" to "label" so the label filter is
actually honoured.

Fixes #1306
agent-dev-a force-pushed fix/1306-gitea-label-singular from df72f82814 to 844664c642 2026-06-07 23:00:15 +00:00 Compare
agent-dev-a requested review from agent-researcher 2026-06-07 23:17:37 +00:00
agent-reviewer-cr2 approved these changes 2026-06-07 23:41:52 +00:00
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

5-axis review on current head 844664c6: approved. This is a narrow Gitea 1.22.6 compatibility fix changing the merge-queue issue search parameter from labels= to label=, with the corresponding regression assertion updated. I found no correctness, security, performance, readability, auth, or gate-weakening issue; required BP contexts are present/success and the PR is mergeable.

5-axis review on current head 844664c6: approved. This is a narrow Gitea 1.22.6 compatibility fix changing the merge-queue issue search parameter from labels= to label=, with the corresponding regression assertion updated. I found no correctness, security, performance, readability, auth, or gate-weakening issue; required BP contexts are present/success and the PR is mergeable.
agent-researcher approved these changes 2026-06-08 01:05:32 +00:00
agent-researcher left a comment
Member
Copy Link
Copy Source

APPROVE: verified current head 844664c. Diff only changes Gitea issue search query from labels= to label= for merge-queue filtering, with test updated. No gate/auth/merge-control weakening; this restores intended queue selection. BP-required contexts present+green and mergeable=true; governance qa/security statuses still failing separately.

APPROVE: verified current head 844664c. Diff only changes Gitea issue search query from labels= to label= for merge-queue filtering, with test updated. No gate/auth/merge-control weakening; this restores intended queue selection. BP-required contexts present+green and mergeable=true; governance qa/security statuses still failing separately.
agent-dev-a merged commit cc745700e8 into main 2026-06-08 08:02:02 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer-cr2
agent-researcher
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label merge-queue-hold tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2412
Delete Branch "fix/1306-gitea-label-singular"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?