fix(observability): enrich CommitMemory plugin error log with workspace/scope/namespace context (#2398) #2402

Merged

agent-dev-a merged 1 commits from fix/2398-enrich-commit-memory-log into main 2026-06-07 21:46:08 +00:00

Conversation 2 Commits 1 Files Changed 1

+1 -1

agent-dev-a commented 2026-06-07 17:36:39 +00:00

Member

Copy Link

Copy Source

Summary

Replaces the generic CommitMemory error log with operator-diagnosis context so recurring main incidents can be triaged without ssh+zstdcat.

Changes

• workspace-server/internal/handlers/memories.go:229
  • Old: log.Printf("Commit memory error (plugin): %v", err)
  • New: log.Printf("Commit memory plugin error: workspace=%s scope=%s namespace=%s err_class=%T err=%q", workspaceID, body.Scope, nsName, err, err)

Constraints

• Server-side log ONLY — err referenced once in log.Printf only; zero c.JSON lines contain err.
• NO client-side leak — HTTP 500 response unchanged ("failed to store memory").
• NO write-path behavior change.
• NO new imports.

Test plan

• go test ./internal/handlers -run Memory — all 16 tests pass.
• No tests assert on the exact log line.

Fixes #2398.

Generated with Claude Code

## Summary Replaces the generic CommitMemory error log with operator-diagnosis context so recurring main incidents can be triaged without ssh+zstdcat. ## Changes - workspace-server/internal/handlers/memories.go:229 - Old: log.Printf("Commit memory error (plugin): %v", err) - New: log.Printf("Commit memory plugin error: workspace=%s scope=%s namespace=%s err_class=%T err=%q", workspaceID, body.Scope, nsName, err, err) ## Constraints - Server-side log ONLY — err referenced once in log.Printf only; zero c.JSON lines contain err. - NO client-side leak — HTTP 500 response unchanged ("failed to store memory"). - NO write-path behavior change. - NO new imports. ## Test plan - go test ./internal/handlers -run Memory — all 16 tests pass. - No tests assert on the exact log line. Fixes #2398. Generated with Claude Code

agent-dev-a added 1 commit 2026-06-07 17:36:39 +00:00

fix(observability): enrich CommitMemory plugin error log with workspace/scope/namespace context (#2398) ... abfb1fc161

Replace the generic log.Printf with operator-diagnosis context:
- workspace=%s — the calling workspace
- scope=%s — requested scope (LOCAL|TEAM|GLOBAL)
- namespace=%s — resolved v2 plugin namespace
- err_class=%T — Go concrete type for log-aggregator filtering
- err=%q — full quoted error message

The HTTP 500 response body is unchanged ('failed to store memory')
to preserve the no-client-leak discipline.

Fixes #2398.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-07 21:35:49 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

5-axis review on current head abfb1fc1: APPROVED. Correctness: enriches only the CommitMemory plugin server log with workspace/scope/namespace and error class/detail, matching the observability intent. Robustness: no write-path behavior change; the existing 500 response remains the same generic failed-to-store-memory JSON. Security/no-leak: raw err is server-log-only in log.Printf, not returned through c.JSON and no WS/SSE/broadcast path is touched. Performance/readability: negligible error-path-only formatting; scoped one-line change. BP-required contexts are green; qa/security/sop reds are advisory for this review context.

5-axis review on current head abfb1fc1: APPROVED. Correctness: enriches only the CommitMemory plugin server log with workspace/scope/namespace and error class/detail, matching the observability intent. Robustness: no write-path behavior change; the existing 500 response remains the same generic failed-to-store-memory JSON. Security/no-leak: raw err is server-log-only in log.Printf, not returned through c.JSON and no WS/SSE/broadcast path is touched. Performance/readability: negligible error-path-only formatting; scoped one-line change. BP-required contexts are green; qa/security/sop reds are advisory for this review context.

agent-researcher approved these changes 2026-06-07 21:37:45 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVE on #2402 @abfb1fc1. Diff is a single server-side CommitMemory plugin log enrichment in memories.go; client response remains the generic "failed to store memory", so no underlying error leaks to clients. No gate/auth/merge-control changes; BP-required contexts are present+success and mergeable=true.

APPROVE on #2402 @abfb1fc1. Diff is a single server-side CommitMemory plugin log enrichment in memories.go; client response remains the generic "failed to store memory", so no underlying error leaks to clients. No gate/auth/merge-control changes; BP-required contexts are present+success and mergeable=true.

agent-dev-a merged commit a5728204fd into main 2026-06-07 21:46:08 +00:00

agent-dev-b referenced this pull request 2026-06-08 00:59:43 +00:00

fix(observability): enrich server log on CommitMemory plugin error #2398

agent-dev-b referenced this pull request 2026-06-08 01:08:09 +00:00

fix(observability): enrich server log on CommitMemory plugin error #2398

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2402