molecule-ai/molecule-core
51
0
Fork 2
Code Issues 159 Pull Requests 161 Actions 8 Packages Projects Releases Wiki Activity

fix(restart): guard sync Restart UPDATE against removed/paused/hibernated (#306) #2395

Closed
agent-dev-a wants to merge 1 commits from fix/restart-sync-update-status-guard into main
pull from: fix/restart-sync-update-status-guard
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 2
+97 -3
agent-dev-a commented 2026-06-07 09:36:07 +00:00
Member
Copy Link
Copy Source

The sync Restart UPDATE at :306 set status=provisioning with WHERE id = $2 only — no status guard. A workspace removed (or paused/hibernated) between the initial SELECT and the UPDATE could be resurrected to provisioning before the async runRestartCycle guard at :810 fired.

Fix:

  • Add AND status NOT IN (removed, paused, hibernated) to the UPDATE, mirroring the async guard.
  • Check RowsAffected; if 0 rows the workspace is terminal and we return 409 Conflict without broadcasting or provisioning.

Scope: workspace_restart.go + workspace_restart_test.go only.

Regression tests:

  • TestRestartHandler_RemovedWorkspaceBlocked — removed workspace + manual Restart → 409, no resurrection
  • TestRestartHandler_OfflineWorkspaceRestartsNormally — offline workspace → guard passes, proceeds normally

Fixes #306.

The sync Restart UPDATE at :306 set status=provisioning with `WHERE id = $2` only — no status guard. A workspace removed (or paused/hibernated) between the initial SELECT and the UPDATE could be resurrected to provisioning before the async `runRestartCycle` guard at :810 fired. **Fix:** - Add `AND status NOT IN (removed, paused, hibernated)` to the UPDATE, mirroring the async guard. - Check `RowsAffected`; if 0 rows the workspace is terminal and we return 409 Conflict without broadcasting or provisioning. **Scope:** `workspace_restart.go` + `workspace_restart_test.go` only. **Regression tests:** - `TestRestartHandler_RemovedWorkspaceBlocked` — removed workspace + manual Restart → 409, no resurrection - `TestRestartHandler_OfflineWorkspaceRestartsNormally` — offline workspace → guard passes, proceeds normally Fixes #306.
agent-dev-a added 1 commit 2026-06-07 09:36:07 +00:00
fix(restart): guard sync Restart UPDATE against removed/paused/hibernated (#306)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
E2E Workspace Lifecycle (staginge2e) / E2E Workspace Lifecycle (staging) (pull_request) Has been skipped
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Details
E2E Chat / detect-changes (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 9s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 11s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 11s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Harness Replays / detect-changes (pull_request) Successful in 11s
Details
qa-review / approved (pull_request_target) Failing after 5s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 4s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 5s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 1s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 15s
Details
security-review / approved (pull_request_target) Failing after 12s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 16s
Details
CI / Canvas (Next.js) (pull_request) Successful in 10s
Details
CI / Canvas Deploy Status (pull_request) Successful in 9s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 58s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m0s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m12s
Details
E2E Workspace Lifecycle (staginge2e) / E2E Workspace Lifecycle (compile+skip) (pull_request) Successful in 1m38s
Details
CI / Platform (Go) (pull_request) Failing after 7m10s
Details
CI / all-required (pull_request) Has been skipped
Details
audit-force-merge / audit (pull_request_target) Waiting to run
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Has been cancelled
Details
572b0d9c00 
The sync Restart UPDATE at :306 set status='provisioning' with WHERE id
only — no status guard. A workspace removed (or paused/hibernated) between
the initial SELECT and the UPDATE could be resurrected to provisioning
before the async runRestartCycle guard at :810 fired.

Fix: add AND status NOT IN ('removed', 'paused', 'hibernated') to the
UPDATE, mirroring the async guard. Check RowsAffected; if 0 rows the
workspace is terminal and we return 409 Conflict without broadcasting or
provisioning.

Scope: workspace_restart.go + workspace_restart_test.go only.

Regression tests:
- TestRestartHandler_RemovedWorkspaceBlocked: removed → 409, no resurrection
- TestRestartHandler_OfflineWorkspaceRestartsNormally: offline → guard
  passes, proceeds to broadcast + provision
agent-dev-a closed this pull request 2026-06-07 09:54:24 +00:00
Some optional checks failed
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
E2E Workspace Lifecycle (staginge2e) / E2E Workspace Lifecycle (staging) (pull_request) Has been skipped
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Details
E2E Chat / detect-changes (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 9s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 11s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 11s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Harness Replays / detect-changes (pull_request) Successful in 11s
Details
qa-review / approved (pull_request_target) Failing after 5s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 4s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 5s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 1s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 15s
Details
security-review / approved (pull_request_target) Failing after 12s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 16s
Details
CI / Canvas (Next.js) (pull_request) Successful in 10s
Details
CI / Canvas Deploy Status (pull_request) Successful in 9s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 58s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m0s
Required
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m12s
Required
Details
E2E Workspace Lifecycle (staginge2e) / E2E Workspace Lifecycle (compile+skip) (pull_request) Successful in 1m38s
Details
CI / Platform (Go) (pull_request) Failing after 7m10s
Details
CI / all-required (pull_request) Has been skipped
Required
Details
audit-force-merge / audit (pull_request_target) Waiting to run
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2395
Delete Branch "fix/restart-sync-update-status-guard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?