molecule-ai/molecule-core
51
0
Fork 2
Code Issues 182 Pull Requests 51 Actions Packages Projects Releases Wiki Activity

fix(security): remove SOP_FAIL_OPEN bypass branches from sop-tier-check.sh #2365

Closed
core-be wants to merge 1 commits from fix/sop-tier-remove-fail-open-dead-code into main
pull from: fix/sop-tier-remove-fail-open-dead-code
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 1
+2 -26
core-be commented 2026-06-06 12:42:33 +00:00
Member
Copy Link
Copy Source

Removes dead SOP_FAIL_OPEN bypass branches that remained in sop-tier-check.sh after the workflow stopped setting the env var on 2026-06-05.

Security issue: Any actor who could set SOP_FAIL_OPEN=1 in the environment could re-enable fail-open behavior, causing the SOP-6 tier gate to green on:

  • jq install failure
  • token/user resolution failure
  • PR head SHA fetch failure
  • org teams list fetch failure
  • reviews fetch failure

Fix: All five branches removed. Every infra fault now fails closed (exit 1 with ::error::).

Refs: bc7c45f3 (intended fix that missed the commit), fix/core-ci-fail-closed.

Removes dead SOP_FAIL_OPEN bypass branches that remained in sop-tier-check.sh after the workflow stopped setting the env var on 2026-06-05. **Security issue:** Any actor who could set `SOP_FAIL_OPEN=1` in the environment could re-enable fail-open behavior, causing the SOP-6 tier gate to green on: - jq install failure - token/user resolution failure - PR head SHA fetch failure - org teams list fetch failure - reviews fetch failure **Fix:** All five branches removed. Every infra fault now fails closed (exit 1 with `::error::`). Refs: bc7c45f3 (intended fix that missed the commit), fix/core-ci-fail-closed.
core-be added 1 commit 2026-06-06 12:42:34 +00:00
fix(security): remove SOP_FAIL_OPEN bypass branches from sop-tier-check.sh
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
E2E Chat / detect-changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 6s
Details
qa-review / approved (pull_request_target) Failing after 5s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
CI / Detect changes (pull_request) Successful in 19s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 15s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 15s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 17s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 12s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 4s
Details
security-review / approved (pull_request_target) Failing after 5s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 17s
Details
CI / Platform (Go) (pull_request) Successful in 5s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 7s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 1s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m2s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m1s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
347613a903 
The SOP_FAIL_OPEN env var was removed from the workflow on 2026-06-05
(fix/core-ci-fail-closed), but the dead bypass branches remained in the
script. Any actor who could set SOP_FAIL_OPEN=1 in the environment could
re-enable the fail-open behavior, causing the SOP-6 tier gate to green
on auth failures, network outages, or missing jq.

Removed 5 bypass branches:
- jq install failure (exit 0 instead of exit 1)
- token/user resolution failure
- PR head SHA fetch failure
- org teams list fetch failure
- reviews fetch failure

All five now fail closed (exit 1 with ::error::) per the mc#1982
protocol and the 2026-06-05 workflow change.

Refs: bc7c45f3 (intended fix that missed the commit), fix/core-ci-fail-closed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
core-be closed this pull request 2026-06-06 13:05:02 +00:00
Some checks are pending
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
E2E Chat / detect-changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Required
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 6s
Details
qa-review / approved (pull_request_target) Failing after 5s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
CI / Detect changes (pull_request) Successful in 19s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 15s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 15s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 17s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 12s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 4s
Details
security-review / approved (pull_request_target) Failing after 5s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 17s
Details
CI / Platform (Go) (pull_request) Successful in 5s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 7s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Required
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 1s
Required
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m2s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m1s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2365
Delete Branch "fix/sop-tier-remove-fail-open-dead-code"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?