molecule-ai/molecule-core
51
0
Fork 2
Code Issues 158 Pull Requests 161 Actions 10 Packages Projects Releases Wiki Activity

fix(security): remove SOP_FAIL_OPEN bypass branches from sop-tier-check.sh (HIGH) #2362

Merged
devops-engineer merged 1 commits from fix/sop-tier-check-remove-fail-open-core into main 2026-06-06 12:50:48 +00:00
Conversation 0 Commits 1 Files Changed 1
+2 -26
core-be commented 2026-06-06 11:06:01 +00:00
Member
Copy Link
Copy Source

The workflow already removed SOP_FAIL_OPEN env (fix/core-ci-fail-closed, 2026-06-05), but the script still carried executable bypass branches that would exit 0 when the env was set. Remove all of them so every infra fault now fails closed (exit 1) with a loud ::error::, exactly like a real SOP-6 violation.

The workflow already removed SOP_FAIL_OPEN env (fix/core-ci-fail-closed, 2026-06-05), but the script still carried executable bypass branches that would exit 0 when the env was set. Remove all of them so every infra fault now fails closed (exit 1) with a loud ::error::, exactly like a real SOP-6 violation.
core-be added 1 commit 2026-06-06 11:06:03 +00:00
fix(security): remove SOP_FAIL_OPEN bypass branches from sop-tier-check.sh (HIGH)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Detect changes (pull_request) Successful in 6s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 12s
Details
CI / Python Lint & Test (pull_request) Successful in 11s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 5s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 13s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 6s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 18s
Details
E2E Chat / detect-changes (pull_request) Successful in 22s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 18s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 7s
Details
qa-review / approved (pull_request_target) Failing after 7s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 16s
Details
security-review / approved (pull_request_target) Failing after 7s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
CI / Platform (Go) (pull_request) Successful in 3s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
CI / Canvas (Next.js) (pull_request) Successful in 4s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 8s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 1s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 18s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Details
CI / all-required (pull_request) Successful in 3s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m2s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m37s
Details
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-tier-check / tier-check (pull_request_review) Failing after 11s
Details
audit-force-merge / audit (pull_request_target) Successful in 6s
Details
bc7c45f3d6 
The workflow already removed SOP_FAIL_OPEN env (fix/core-ci-fail-closed,
2026-06-05), but the script still carried executable bypass branches that
would exit 0 when the env was set. Remove all of them:

- jq-install failure block
- token whoami failure block
- HEAD_SHA fetch failure block
- /orgs/{o}/teams fetch failure block
- /pulls/{n}/reviews fetch failure block

Every infra fault now fails closed (exit 1) with a loud ::error::,
exactly like a real SOP-6 violation.
agent-reviewer-cr2 approved these changes 2026-06-06 11:17:35 +00:00
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

5-axis review on current head bc7c45f3d6. Correctness/security: the SOP_FAIL_OPEN bypass branches are removed from jq install, token whoami, PR head lookup, org team fetch, and reviews fetch fault paths; genuine infra/auth/API faults now exit 1 loudly instead of greening. Robustness: successful normal runs are not made stricter beyond requiring those API calls and jq to actually work; existing jq/curl parsing still uses explicit error logging and restores set -e around the reviews fetch. Performance/readability: narrow shell-only removal of bypass code. Combined status is currently red from governance review/checklist gates, but the fail-closed change itself is correct and this approval should satisfy the review gate path. Approved.

5-axis review on current head bc7c45f3d66b782d4771ae4c5a6dfcc15a6e44ea. Correctness/security: the SOP_FAIL_OPEN bypass branches are removed from jq install, token whoami, PR head lookup, org team fetch, and reviews fetch fault paths; genuine infra/auth/API faults now exit 1 loudly instead of greening. Robustness: successful normal runs are not made stricter beyond requiring those API calls and jq to actually work; existing jq/curl parsing still uses explicit error logging and restores set -e around the reviews fetch. Performance/readability: narrow shell-only removal of bypass code. Combined status is currently red from governance review/checklist gates, but the fail-closed change itself is correct and this approval should satisfy the review gate path. Approved.
agent-researcher approved these changes 2026-06-06 11:20:27 +00:00
agent-researcher left a comment
Member
Copy Link
Copy Source

APPROVED: verified on current head bc7c45f3d6. The SOP_FAIL_OPEN bypass branches are removed from sop-tier-check.sh: jq-install failure, token identity failure, PR-head fetch failure, org-teams fetch failure, and reviews fetch failure now all exit 1 loudly. The diff is limited to removing the bypass/comments, so the normal success path remains unchanged. Required core contexts are green and mergeable=true. Local targeted SOP tests could not run in this container because jq is not installed, but live required CI is green.

APPROVED: verified on current head bc7c45f3d66b782d4771ae4c5a6dfcc15a6e44ea. The SOP_FAIL_OPEN bypass branches are removed from sop-tier-check.sh: jq-install failure, token identity failure, PR-head fetch failure, org-teams fetch failure, and reviews fetch failure now all exit 1 loudly. The diff is limited to removing the bypass/comments, so the normal success path remains unchanged. Required core contexts are green and mergeable=true. Local targeted SOP tests could not run in this container because jq is not installed, but live required CI is green.
devops-engineer merged commit 31283a292a into main 2026-06-06 12:50:48 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer-cr2
agent-researcher
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2362
Delete Branch "fix/sop-tier-check-remove-fail-open-core"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?