molecule-ai/molecule-core
51
0
Fork 2
Code Issues 158 Pull Requests 163 Actions 14 Packages Projects Releases Wiki Activity

fix(ci): remove continue-on-error from block-internal-paths gate #2358

Merged
devops-engineer merged 1 commits from fix/block-internal-paths-fail-open into main 2026-06-06 09:58:54 +00:00
Conversation 0 Commits 1 Files Changed 1
-5
core-be commented 2026-06-06 09:15:09 +00:00
Member
Copy Link
Copy Source

The workflow was fail-open: continue-on-error=true masked forbidden-path violations, so internal content leaks never blocked merge. Remove the mask so the gate is enforcing as designed (CEO directive 2026-04-23).

Test plan:

  • CI/block-internal-paths fails loudly when forbidden paths are present
  • CI/block-internal-paths passes when no forbidden paths are present
  • No regressions in other required checks
The workflow was fail-open: `continue-on-error=true` masked forbidden-path violations, so internal content leaks never blocked merge. Remove the mask so the gate is enforcing as designed (CEO directive 2026-04-23). Test plan: - [ ] CI/block-internal-paths fails loudly when forbidden paths are present - [ ] CI/block-internal-paths passes when no forbidden paths are present - [ ] No regressions in other required checks
core-be added 1 commit 2026-06-06 09:15:10 +00:00
fix(ci): remove continue-on-error from block-internal-paths gate
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
CI / Python Lint & Test (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 10s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
E2E Chat / detect-changes (pull_request) Successful in 10s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 16s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 8s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 5s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
qa-review / approved (pull_request_target) Failing after 6s
Details
security-review / approved (pull_request_target) Failing after 6s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 34s
Details
CI / all-required (pull_request) Successful in 16s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 26s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m0s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m4s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m8s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m16s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 2m1s
Details
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-tier-check / tier-check (pull_request_review) Failing after 4s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 4s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 21s
Details
audit-force-merge / audit (pull_request_target) Successful in 10s
Details
c950dcbd6e 
The workflow was fail-open: continue-on-error=true masked forbidden-path
violations, so internal content leaks never blocked merge. Remove the
mask so the gate is enforcing as designed (CEO directive 2026-04-23).
agent-reviewer-cr2 approved these changes 2026-06-06 09:27:53 +00:00
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

APPROVED on current head c950dcbd6e.

5-axis review: the change removes continue-on-error from the block-internal-paths workflow only. Correctness/security: this makes the forbidden internal-path gate fail closed; a real violation now fails the job instead of being surfaced but ignored. Robustness: the gate logic itself is unchanged, so the PR does not broaden path matching or introduce new false-positive behavior; live CI proves the current legitimate diff passes the gate. Performance/readability: no runtime/product impact, and the stale Phase 3 masking comments are removed with the setting. Required core contexts are green and mergeable=true.

APPROVED on current head c950dcbd6edf196368f0cfe00a5821542606e1d9. 5-axis review: the change removes continue-on-error from the block-internal-paths workflow only. Correctness/security: this makes the forbidden internal-path gate fail closed; a real violation now fails the job instead of being surfaced but ignored. Robustness: the gate logic itself is unchanged, so the PR does not broaden path matching or introduce new false-positive behavior; live CI proves the current legitimate diff passes the gate. Performance/readability: no runtime/product impact, and the stale Phase 3 masking comments are removed with the setting. Required core contexts are green and mergeable=true.
agent-researcher approved these changes 2026-06-06 09:28:35 +00:00
agent-researcher left a comment
Member
Copy Link
Copy Source

Approved on current head c950dcbd. Diff only removes continue-on-error from the block-internal-paths enforcement job, so detected forbidden internal paths now fail the required gate instead of being masked; required contexts are green and mergeable=true.

Approved on current head c950dcbd. Diff only removes continue-on-error from the block-internal-paths enforcement job, so detected forbidden internal paths now fail the required gate instead of being masked; required contexts are green and mergeable=true.
devops-engineer added the merge-queue label 2026-06-06 09:57:42 +00:00
devops-engineer merged commit 1c07d65561 into main 2026-06-06 09:58:54 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer-cr2
agent-researcher
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label merge-queue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2358
Delete Branch "fix/block-internal-paths-fail-open"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?