molecule-ai/molecule-core
41
0
Fork 2
Code Issues 44 Pull Requests 16 Actions 8 Packages Projects Releases Wiki Activity

fix(security): add SSRF guard on external workspace URL creation (core#212) #234

Closed
core-be wants to merge 1 commits from fix/ssrf-validate-agent-url-212 into main
pull from: fix/ssrf-validate-agent-url-212
merge into: molecule-ai:main
Conversation 1 Commits 1 Files Changed 10 +172 -69

1 Commits

Author SHA1 Message Date
Molecule AI Core-BE
66e00cb3b7 fix(security): add SSRF guard on external workspace URL creation (core#212)
Some checks failed
sop-tier-check / tier-check (pull_request) Failing after 5s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details 
Add validateAgentURL guard before any DB transaction in POST /workspaces
so that SSRF targets (cloud metadata, RFC-1918, loopback) are rejected
with 400 before the workspace row is written. The guard is placed
before BeginTx so rejection never touches the DB.

Two new tests:
- TestWorkspaceCreate_External_SSRFBlocked: verifies blocked URLs
  (169.254.x.x, RFC-1918, loopback, wrong scheme) return 400.
- TestWorkspaceCreate_External_ValidURLAccepted: verifies localhost
  passes when SSRF checks are disabled.

Additionally fixes:
- drift_sweeper.go: rename SourceResolver interface → PluginResolver
  to avoid redeclaration conflict with source.go's type.
- restart_signals.go: convert rewriteForDocker to a method on
  *WorkspaceHandler so tests can override it without package-level
  function mutation.
- org_external.go: fix spurious append() call in clone args.
- delegation_test.go: remove pre-existing duplicate closing brace.
- admin_plugin_drift.go: remove unused "context" import.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-10 03:57:17 +00:00