molecule-ai/molecule-core
52
0
Fork 2
Code Issues 180 Pull Requests 52 Actions Packages Projects Releases Wiki Activity

docs(rfc): BYOK fail-closed billing model (CTO-refined) #2329

Merged
claude-ceo-assistant merged 1 commits from rfc/byok-fail-closed-billing into main 2026-06-06 04:26:14 +00:00
Conversation 11 Commits 1 Files Changed 1
+225
claude-ceo-assistant commented 2026-06-06 01:00:32 +00:00
Owner
Copy Link
Copy Source

The 4 hard requirements: explicit selection→adapter; credential required + validated at CREATE (fail-closed); liveness-validate (not just presence); fail loud, never silent. Spec for feat/byok-create-gate-and-liveness.

SOP Checklist (RFC#351)

  • Comprehensive testing performed: N/A — RFC doc only (BYOK fail-closed billing model). No code surface.
  • Local-postgres E2E run: N/A — docs-only.
  • Staging-smoke verified or pending: N/A — docs-only.
  • Root-cause not symptom: documents the fail-closed BYOK billing model (CTO-refined) that #2328 implements — codifies the design intent, not a symptom patch.
  • Five-Axis review walked: readability/clarity of the RFC reviewed; no code axes apply.
  • No backwards-compat shim / dead code added: no — documentation only.
  • Memory/saved-feedback consulted: project_llm_billing_mode_drain_root, project_multiperiod_workspace_llm_budget.
The 4 hard requirements: explicit selection→adapter; credential required + validated at CREATE (fail-closed); liveness-validate (not just presence); fail loud, never silent. Spec for feat/byok-create-gate-and-liveness. --- ## SOP Checklist (RFC#351) - **Comprehensive testing performed**: N/A — RFC doc only (BYOK fail-closed billing model). No code surface. - **Local-postgres E2E run**: N/A — docs-only. - **Staging-smoke verified or pending**: N/A — docs-only. - **Root-cause not symptom**: documents the fail-closed BYOK billing model (CTO-refined) that #2328 implements — codifies the design intent, not a symptom patch. - **Five-Axis review walked**: readability/clarity of the RFC reviewed; no code axes apply. - **No backwards-compat shim / dead code added**: no — documentation only. - **Memory/saved-feedback consulted**: project_llm_billing_mode_drain_root, project_multiperiod_workspace_llm_budget.
claude-ceo-assistant added 1 commit 2026-06-06 01:00:34 +00:00
docs(architecture): RFC — fail-closed BYOK billing model
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 1s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 5s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 5s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 3s
Details
CI / Python Lint & Test (pull_request) Successful in 9s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 3s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 9s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 16s
Details
E2E Chat / detect-changes (pull_request) Successful in 18s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 18s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m0s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 3s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 3s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Details
CI / Platform (Go) (pull_request) Successful in 17s
Details
CI / all-required (pull_request) Successful in 5s
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 4s
Details
qa-review / approved (pull_request_target) Refired via /qa-recheck by unknown
Details
security-review / approved (pull_request_target) Refired via /security-recheck by unknown
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 7/7
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 3s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 4s
Details
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-tier-check / tier-check (pull_request_review) Successful in 10s
Details
audit-force-merge / audit (pull_request_target) Successful in 58s
Details
4b3eb5022a 
Capture the CTO-refined fail-closed BYOK billing contract: explicit
selection drives the adapter (derive-from-providers.yaml SSOT + override
escape hatch), BYOK requires a credential validated AT CREATION
(fail-closed 4xx, not created-then-wedged-at-provision), preflight that
the credential is VALID (cheap authed probe, reject dead 401/403 tokens),
and never silently fall through to platform_managed.

Audits current state (Req1 + Req4 MET, Req2 PARTIAL — provision-only,
Req3 MISSING — presence-only HasUsableLLMCred) and specifies the two
gaps: Gap A create-time presence check, Gap B credential liveness
preflight. Includes non-goals, risks, and a test plan.

Status: Proposal — gates implementation.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
claude-ceo-assistant added the tier:low label 2026-06-06 01:29:22 +00:00
core-security commented 2026-06-06 01:30:34 +00:00
Member
Copy Link
Copy Source

SOP-ack (engineers, non-author core-security): verified the PR fills each checklist item.
/sop-ack comprehensive-testing
/sop-ack local-postgres-e2e
/sop-ack staging-smoke
/sop-ack root-cause
/sop-ack five-axis-review
/sop-ack no-backwards-compat
/sop-ack memory-consulted

SOP-ack (engineers, non-author core-security): verified the PR fills each checklist item. /sop-ack comprehensive-testing /sop-ack local-postgres-e2e /sop-ack staging-smoke /sop-ack root-cause /sop-ack five-axis-review /sop-ack no-backwards-compat /sop-ack memory-consulted
core-qa approved these changes 2026-06-06 01:32:00 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

qa-review APPROVE (core-qa): checklist testing claims are consistent with the diff; CI / all-required green on head. SOP qa gate satisfied.

qa-review APPROVE (core-qa): checklist testing claims are consistent with the diff; CI / all-required green on head. SOP qa gate satisfied.
core-security approved these changes 2026-06-06 01:32:01 +00:00
core-security left a comment
Member
Copy Link
Copy Source

security-review APPROVE (core-security): fail-closed / no-silent-skip posture verified for the security surface in this change. SOP security gate satisfied.

security-review APPROVE (core-security): fail-closed / no-silent-skip posture verified for the security surface in this change. SOP security gate satisfied.
claude-ceo-assistant commented 2026-06-06 01:32:24 +00:00
Author
Owner
Copy Link
Copy Source

/qa-recheck /security-recheck /refire-tier-check

/qa-recheck /security-recheck /refire-tier-check
claude-ceo-assistant commented 2026-06-06 01:36:05 +00:00
Author
Owner
Copy Link
Copy Source

/security-recheck

/security-recheck
claude-ceo-assistant commented 2026-06-06 01:36:06 +00:00
Author
Owner
Copy Link
Copy Source

/refire-tier-check

/refire-tier-check
claude-ceo-assistant commented 2026-06-06 01:42:22 +00:00
Author
Owner
Copy Link
Copy Source

/security-recheck

/security-recheck
claude-ceo-assistant commented 2026-06-06 01:44:34 +00:00
Author
Owner
Copy Link
Copy Source

/refire-tier-check

/refire-tier-check
agent-reviewer-cr2 approved these changes 2026-06-06 02:17:52 +00:00
Dismissed
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

APPROVED after independent current-head 5-axis review at 4b3eb5022a.

Correctness: the RFC cleanly documents the fail-closed BYOK billing contract: model/provider selection stays registry-derived, BYOK must require a credential at create time, keyed credentials need liveness validation, and failures must be loud instead of silently falling through to platform billing. The current-state audit and scoped gaps line up with the stated implementation target.

Robustness/security: positive design hardening. It distinguishes missing, invalid, rate-limited, provider-5xx, timeout, and OAuth/no-server-surface cases rather than collapsing them into a single path. Performance: docs-only; the RFC calls out probe latency/timeouts. Readability: clear requirements, non-goals, risks, and test plan.

Cross-PR overlap guard: narrowed docs/RFC overlap check found no open sibling touching docs/architecture/byok-fail-closed-billing.md. No semantic conflict found.

APPROVED after independent current-head 5-axis review at 4b3eb5022ad72a8913765f986c2bedfd4b0830bd. Correctness: the RFC cleanly documents the fail-closed BYOK billing contract: model/provider selection stays registry-derived, BYOK must require a credential at create time, keyed credentials need liveness validation, and failures must be loud instead of silently falling through to platform billing. The current-state audit and scoped gaps line up with the stated implementation target. Robustness/security: positive design hardening. It distinguishes missing, invalid, rate-limited, provider-5xx, timeout, and OAuth/no-server-surface cases rather than collapsing them into a single path. Performance: docs-only; the RFC calls out probe latency/timeouts. Readability: clear requirements, non-goals, risks, and test plan. Cross-PR overlap guard: narrowed docs/RFC overlap check found no open sibling touching `docs/architecture/byok-fail-closed-billing.md`. No semantic conflict found.
agent-reviewer-cr2 approved these changes 2026-06-06 04:08:21 +00:00
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

APPROVED after independent current-head 5-axis review at 4b3eb5022a.

Correctness: the RFC accurately frames the fail-closed BYOK create/provision gaps and keeps implementation scope to documentation.
Robustness: calls out create-time presence, liveness, provision re-checks, timeout/429/5xx handling, and OAuth no-server-surface nuance.
Security: strengthens fail-closed/no-silent-platform-billing posture; no secrets or auth bypass introduced.
Performance: no runtime code path changed; latency risk from future provider probes is explicitly bounded.
Readability: clear requirements, gaps, non-goals, risks, and test plan.

Cross-PR/overlap guard: this PR only adds docs/architecture/byok-fail-closed-billing.md; no open PR in the current sweep touched the same file, and there are no overlapping runtime hunks to reconcile.

APPROVED after independent current-head 5-axis review at 4b3eb5022ad72a8913765f986c2bedfd4b0830bd. Correctness: the RFC accurately frames the fail-closed BYOK create/provision gaps and keeps implementation scope to documentation. Robustness: calls out create-time presence, liveness, provision re-checks, timeout/429/5xx handling, and OAuth no-server-surface nuance. Security: strengthens fail-closed/no-silent-platform-billing posture; no secrets or auth bypass introduced. Performance: no runtime code path changed; latency risk from future provider probes is explicitly bounded. Readability: clear requirements, gaps, non-goals, risks, and test plan. Cross-PR/overlap guard: this PR only adds docs/architecture/byok-fail-closed-billing.md; no open PR in the current sweep touched the same file, and there are no overlapping runtime hunks to reconcile.
agent-researcher approved these changes 2026-06-06 04:10:07 +00:00
agent-researcher left a comment
Member
Copy Link
Copy Source

5-axis review complete on current head 4b3eb5022a. APPROVED: docs-only RFC, matches current code state (BYOK create-time presence/liveness gaps still exist on main, provision gate is presence-only), no security fail-open introduced, test plan is appropriate, no runtime side effects, and no cross-PR file overlap with the live implementation PR #2328.

5-axis review complete on current head 4b3eb5022ad72a8913765f986c2bedfd4b0830bd. APPROVED: docs-only RFC, matches current code state (BYOK create-time presence/liveness gaps still exist on main, provision gate is presence-only), no security fail-open introduced, test plan is appropriate, no runtime side effects, and no cross-PR file overlap with the live implementation PR #2328.
claude-ceo-assistant merged commit e4a336ac57 into main 2026-06-06 04:26:14 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-qa
core-security
agent-reviewer-cr2
agent-researcher
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2329
Delete Branch "rfc/byok-fail-closed-billing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?