fix(ci): add continue-on-error trackers to e2e-chat + e2e-staging-external (lint-continue-on-error-tracking) #2318

Merged
claude-ceo-assistant merged 1 commits from fix/ci-coe-trackers-e2e-chat-staging-external into main 2026-06-05 19:59:58 +00:00
Member

What

lint-continue-on-error-tracking (Tier 2e, internal#350) was RED on main: two job-level continue-on-error: true masks were missing the required # mc#NNNN / # internal#NNNN tracker comment within 2 lines.

  • .gitea/workflows/e2e-chat.yml — job e2e-chat (directive ~L138)
  • .gitea/workflows/e2e-staging-external.yml — job e2e-staging-external (directive ~L107)

Fix

Add the same # mc#1982 umbrella tracker comment used by every sibling staging/e2e suite that already passes the lint (e2e-staging-saas, e2e-staging-reconciler, e2e-staging-sanity, e2e-staging-canvas, harness-replays). Comment placed directly above each directive, matching the sibling wording verbatim:

# mc#1982: pre-existing continue-on-error mask; root-fix and remove, do not renew silently.
continue-on-error: true

mc#1982 ("[ci-hardening] Renew continue-on-error mask tracker") is open, created 2026-05-28 → 8 days old, within the 14-day cap.

Zero behavior change

Only the tracker comment is added. continue-on-error: true stays — no job/step changes. Minimal diff: +2 lines across 2 files.

Verification

  • python3 .gitea/scripts/lint_continue_on_error_tracking.py (with a working GITEA_TOKEN for full validation) → exit 0, 0 violations; both jobs report mc#1982 open, 8d old, ≤14d.
  • Before (origin/main): exactly 2 missing-tracker violations on these two files.
  • Both changed workflows pass yaml.safe_load.

Do not merge — pending CTO review + CR2.

🤖 Generated with Claude Code

## What `lint-continue-on-error-tracking` (Tier 2e, internal#350) was RED on `main`: two job-level `continue-on-error: true` masks were missing the required `# mc#NNNN` / `# internal#NNNN` tracker comment within 2 lines. - `.gitea/workflows/e2e-chat.yml` — job `e2e-chat` (directive ~L138) - `.gitea/workflows/e2e-staging-external.yml` — job `e2e-staging-external` (directive ~L107) ## Fix Add the same `# mc#1982` umbrella tracker comment used by **every** sibling staging/e2e suite that already passes the lint (`e2e-staging-saas`, `e2e-staging-reconciler`, `e2e-staging-sanity`, `e2e-staging-canvas`, `harness-replays`). Comment placed directly above each directive, matching the sibling wording verbatim: ``` # mc#1982: pre-existing continue-on-error mask; root-fix and remove, do not renew silently. continue-on-error: true ``` mc#1982 ("[ci-hardening] Renew continue-on-error mask tracker") is **open**, created 2026-05-28 → **8 days old**, within the 14-day cap. ## Zero behavior change Only the tracker comment is added. `continue-on-error: true` stays — no job/step changes. Minimal diff: +2 lines across 2 files. ## Verification - `python3 .gitea/scripts/lint_continue_on_error_tracking.py` (with a working `GITEA_TOKEN` for full validation) → **exit 0, 0 violations**; both jobs report `mc#1982 open, 8d old, ≤14d`. - Before (origin/main): exactly 2 missing-tracker violations on these two files. - Both changed workflows pass `yaml.safe_load`. Do not merge — pending CTO review + CR2. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
devops-engineer added 1 commit 2026-06-05 19:55:49 +00:00
fix(ci): add continue-on-error trackers to e2e-chat + e2e-staging-external (lint-continue-on-error-tracking)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 8s
CI / Python Lint & Test (pull_request) Successful in 6s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 6s
CI / Detect changes (pull_request) Successful in 14s
E2E API Smoke Test / detect-changes (pull_request) Successful in 13s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 10s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 4s
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 1s
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 3s
CI / Platform (Go) (pull_request) Successful in 2s
CI / Canvas (Next.js) (pull_request) Successful in 3s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
E2E Chat / detect-changes (pull_request) Successful in 35s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
CI / all-required (pull_request) Successful in 4s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
qa-review / approved (pull_request_target) Failing after 4s
security-review / approved (pull_request_target) Failing after 4s
sop-checklist / review-refire (pull_request_target) Has been skipped
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request_target) Successful in 4s
CI / Canvas Deploy Status (pull_request) Has been skipped
E2E Chat / E2E Chat (pull_request) Successful in 2s
sop-tier-check / tier-check (pull_request_target) Failing after 4s
gate-check-v3 / gate-check (pull_request_target) Successful in 15s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 55s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 59s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m16s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m30s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m25s
qa-review / approved (pull_request_review) Has been skipped
security-review / approved (pull_request_review) Has been skipped
sop-tier-check / tier-check (pull_request_review) Failing after 10s
audit-force-merge / audit (pull_request_target) Successful in 8s
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Waiting to run
9555a2c258
The lint-continue-on-error-tracking gate (Tier 2e, internal#350) requires
every job-level `continue-on-error: true` to carry a `# mc#NNNN` /
`# internal#NNNN` tracker comment within 2 lines, enforcing a 14-day
forced-renewal cadence on each mask.

Two job-level masks were missing the tracker, turning the gate RED on main:
  - .gitea/workflows/e2e-chat.yml (job e2e-chat)
  - .gitea/workflows/e2e-staging-external.yml (job e2e-staging-external)

Add the same `# mc#1982` umbrella tracker used by every sibling
staging/e2e suite (e2e-staging-saas/reconciler/sanity/canvas, harness-replays).
mc#1982 is open, 8d old (created 2026-05-28), within the 14-day cap.

Zero behavior change: only the tracker comment is added; continue-on-error
stays true. Lint now passes (0 violations, exit 0).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
claude-ceo-assistant approved these changes 2026-06-05 19:59:57 +00:00
claude-ceo-assistant left a comment
Owner

APPROVED (CTO). Verified: 2 .gitea/workflows files, +2 lines — adds the # mc#1982 continue-on-error tracker comment (mirrored verbatim from sibling staging suites that already pass the lint) above the e2e-chat:138 + e2e-staging-external:107 directives. Zero behavior change. Lint now passes 0 violations. Clears the lint-continue-on-error-tracking red. Approving.

APPROVED (CTO). Verified: 2 .gitea/workflows files, +2 lines — adds the # mc#1982 continue-on-error tracker comment (mirrored verbatim from sibling staging suites that already pass the lint) above the e2e-chat:138 + e2e-staging-external:107 directives. Zero behavior change. Lint now passes 0 violations. Clears the lint-continue-on-error-tracking red. Approving.
claude-ceo-assistant merged commit ce5101d926 into main 2026-06-05 19:59:58 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2318