fix(e2e): saas workflow E2E_MODEL_SLUG default must be bare MiniMax-M2.7 not colon (the override #2311 missed) #2312

Merged

core-devops merged 1 commits from fix/e2e-saas-model-slug-bare into main 2026-06-05 17:31:23 +00:00

Conversation 0 Commits 1 Files Changed 1

+13 -9

core-devops commented 2026-06-05 17:28:16 +00:00

Member

Copy Link

Copy Source

Problem

The e2e-staging-saas regression guard fails at parent workspace-create with HTTP 422:

{"code":"UNREGISTERED_MODEL_FOR_RUNTIME","error":"model \"minimax:MiniMax-M2.7\" is not a registered model for runtime \"claude-code\" ... internal#718"}

Real failure: job 295233, main 4b3590e3.

Why #2311 didn't fix it

PR #2311 fixed the bare-vs-colon slug in tests/e2e/lib/model_slug.sh. But pick_model_slug() returns $E2E_MODEL_SLUG verbatim when that env var is set+non-empty — and this workflow sets E2E_MODEL_SLUG to the colon form. The workflow env overrides the lib #2311 fixed, so the saas guard kept sending minimax:MiniMax-M2.7 and 422ing.

The fix

In .gitea/workflows/e2e-staging-saas.yml, change the default fallback of the E2E_MODEL_SLUG expression from the colon form 'minimax:MiniMax-M2.7' to the bare registered form 'MiniMax-M2.7'. Per-runtime overrides (hermes / codex / google-adk) are left exactly as-is.

• Bare MiniMax-M2.7 is the BYOK-minimax form — registry_gen.go:88 registers it on the minimax arm (resolves provider=minimax via MINIMAX_API_KEY), so the #1994 byok-not-platform guard still passes.
• Colon minimax:MiniMax-M2.7 is UNREGISTERED on claude-code — the adapter can't strip the minimax: prefix (derive_provider_matrix_test.go:288, the expectErr=true row).
• Slash minimax/MiniMax-M2.7 is the platform-billed arm (would trip the byok guard).

The stale comment block (claiming the colon form is needed / that bare 400s on deploy-skew) is corrected.

Audit of all workflows for the same colon-on-claude-code mismatch

Workflow	E2E_MODEL_SLUG default	Form	Action
e2e-staging-saas.yml	minimax:MiniMax-M2.7 → MiniMax-M2.7	colon → bare	FIXED (this PR)
e2e-staging-reconciler.yml	MiniMax-M2	bare	none
staging-smoke.yml	MiniMax-M2	bare	none
continuous-synth-e2e.yml	`${{ inputs.model_slug		'MiniMax-M2' }}`

grep -rn 'minimax:' .gitea/workflows/ matched only e2e-staging-saas.yml (the literal + its comment). No other workflow has the colon-on-claude-code default.

Scope / verification

• Test-infra-only: 1 file (.gitea/workflows/e2e-staging-saas.yml), model-slug literal + comment only. Zero production .go, zero registry/providers.yaml, zero test-script logic. No change to continue-on-error, triggers, timeouts, concurrency.
• python3 -c 'yaml.safe_load(...)' → OK.
• Repo hostile-shapes linter (.gitea/scripts/lint-workflow-yaml.py) → 57 workflow file(s) checked, no fatal Gitea-1.22.6-hostile shapes. (0 heuristic warning(s)), exit 0. The ${{ }} expression keeps its single-expression && / || chain shape — only the final string literal changed.

🤖 Generated with Claude Code

## Problem The `e2e-staging-saas` regression guard fails at parent workspace-create with HTTP 422: ``` {"code":"UNREGISTERED_MODEL_FOR_RUNTIME","error":"model \"minimax:MiniMax-M2.7\" is not a registered model for runtime \"claude-code\" ... internal#718"} ``` Real failure: **job 295233**, main `4b3590e3`. ## Why #2311 didn't fix it PR #2311 fixed the bare-vs-colon slug in `tests/e2e/lib/model_slug.sh`. But `pick_model_slug()` returns `$E2E_MODEL_SLUG` **verbatim** when that env var is set+non-empty — and this workflow sets `E2E_MODEL_SLUG` to the colon form. The workflow env **overrides** the lib #2311 fixed, so the saas guard kept sending `minimax:MiniMax-M2.7` and 422ing. ## The fix In `.gitea/workflows/e2e-staging-saas.yml`, change the **default fallback** of the `E2E_MODEL_SLUG` expression from the colon form `'minimax:MiniMax-M2.7'` to the **bare registered** form `'MiniMax-M2.7'`. Per-runtime overrides (hermes / codex / google-adk) are left **exactly** as-is. - Bare `MiniMax-M2.7` is the **BYOK-minimax** form — `registry_gen.go:88` registers it on the `minimax` arm (resolves `provider=minimax` via `MINIMAX_API_KEY`), so the #1994 byok-not-platform guard still passes. - Colon `minimax:MiniMax-M2.7` is **UNREGISTERED** on claude-code — the adapter can't strip the `minimax:` prefix (`derive_provider_matrix_test.go:288`, the `expectErr=true` row). - Slash `minimax/MiniMax-M2.7` is the platform-billed arm (would trip the byok guard). The stale comment block (claiming the colon form is needed / that bare 400s on deploy-skew) is corrected. ## Audit of all workflows for the same colon-on-claude-code mismatch | Workflow | `E2E_MODEL_SLUG` default | Form | Action | |---|---|---|---| | `e2e-staging-saas.yml` | `minimax:MiniMax-M2.7` → `MiniMax-M2.7` | colon → **bare** | **FIXED (this PR)** | | `e2e-staging-reconciler.yml` | `MiniMax-M2` | bare | none | | `staging-smoke.yml` | `MiniMax-M2` | bare | none | | `continuous-synth-e2e.yml` | `${{ inputs.model_slug || 'MiniMax-M2' }}` | bare | none | `grep -rn 'minimax:' .gitea/workflows/` matched **only** `e2e-staging-saas.yml` (the literal + its comment). No other workflow has the colon-on-claude-code default. ## Scope / verification - **Test-infra-only**: 1 file (`.gitea/workflows/e2e-staging-saas.yml`), model-slug literal + comment only. Zero production `.go`, zero registry/`providers.yaml`, zero test-script logic. No change to continue-on-error, triggers, timeouts, concurrency. - `python3 -c 'yaml.safe_load(...)'` → OK. - Repo hostile-shapes linter (`.gitea/scripts/lint-workflow-yaml.py`) → `57 workflow file(s) checked, no fatal Gitea-1.22.6-hostile shapes. (0 heuristic warning(s))`, exit 0. The `${{ }}` expression keeps its single-expression `&& / ||` chain shape — only the final string literal changed. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

core-devops added 1 commit 2026-06-05 17:28:17 +00:00

fix(e2e): saas workflow E2E_MODEL_SLUG default must be bare MiniMax-M2.7 not colon ... 2efeb6a1bb

The e2e-staging-saas regression guard 422s at parent workspace-create with
UNREGISTERED_MODEL_FOR_RUNTIME for model "minimax:MiniMax-M2.7" on runtime
"claude-code" (internal#718; real failure job 295233, main 4b3590e3).

PR #2311 fixed the bare-vs-colon slug in tests/e2e/lib/model_slug.sh, but the
workflow env var E2E_MODEL_SLUG OVERRIDES the pick_model_slug lib (it returns
$E2E_MODEL_SLUG verbatim when set), so the saas run kept sending the colon form.

The claude-code adapter can't strip the `minimax:` prefix, so the colon id is
UNREGISTERED (derive_provider_matrix_test.go:288). The bare registered id
`MiniMax-M2.7` is the BYOK-minimax form (registry_gen.go:88, MINIMAX_API_KEY),
which keeps the #1994 byok-not-platform guard passing. Swap the default fallback
to the bare form and correct the stale comment. Per-runtime overrides
(hermes/codex/google-adk) are unchanged.

Test-infra-only: workflow file + comment, zero production/registry/test-script
changes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

claude-ceo-assistant approved these changes 2026-06-05 17:29:27 +00:00

claude-ceo-assistant left a comment

Owner

Copy Link

Copy Source

APPROVED (CTO review). Verified diff: ONLY .gitea/workflows/e2e-staging-saas.yml; the single non-comment change is the E2E_MODEL_SLUG default literal minimax:MiniMax-M2.7 (colon) → MiniMax-M2.7 (bare). This is the override that #2311 missed — E2E_MODEL_SLUG (workflow env) wins over the pick_model_slug lib, so the saas guard kept sending the colon form and 422ing UNREGISTERED_MODEL_FOR_RUNTIME on claude-code (real evidence job 295233). Bare is registered (registry_gen.go:88); colon is intentionally UNREGISTERED on claude-code (matrix test :288). hermes/codex/google-adk per-runtime overrides preserved; no triggers/timeouts/concurrency/continue-on-error change. Audit confirmed saas was the only colon offender (reconciler/smoke/synth use bare). YAML hostile-shapes lint exit 0. Approving.

APPROVED (CTO review). Verified diff: ONLY .gitea/workflows/e2e-staging-saas.yml; the single non-comment change is the E2E_MODEL_SLUG default literal minimax:MiniMax-M2.7 (colon) → MiniMax-M2.7 (bare). This is the override that #2311 missed — E2E_MODEL_SLUG (workflow env) wins over the pick_model_slug lib, so the saas guard kept sending the colon form and 422ing UNREGISTERED_MODEL_FOR_RUNTIME on claude-code (real evidence job 295233). Bare is registered (registry_gen.go:88); colon is intentionally UNREGISTERED on claude-code (matrix test :288). hermes/codex/google-adk per-runtime overrides preserved; no triggers/timeouts/concurrency/continue-on-error change. Audit confirmed saas was the only colon offender (reconciler/smoke/synth use bare). YAML hostile-shapes lint exit 0. Approving.

agent-reviewer approved these changes 2026-06-05 17:30:45 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

APPROVED after 5-axis review on current head 2efeb6a1bb.

Correctness: this fixes the workflow-level E2E_MODEL_SLUG override from the claude-code-invalid colon form minimax:MiniMax-M2.7 to the registered bare MiniMax-M2.7, so #2311's model_slug lib fix is no longer bypassed by the workflow env default.

Robustness: only .gitea/workflows/e2e-staging-saas.yml changed. The hermes/codex overrides remain openai/gpt-4o, google-adk remains google_genai:gemini-2.5-pro, and no trigger/concurrency/continue-on-error/gating semantics changed. Required contexts are green: CI / all-required, E2E API Smoke Test, and Handlers Postgres Integration.

Security: no production code, auth, or secret handling changes.

Performance: no runtime performance impact; workflow env default/comment only.

Readability: the updated comment clearly documents bare-vs-colon-vs-slash semantics and why this workflow must match the provider registry contract. I am not treating combined_state/non-required lint or review ceremony statuses as the merge gate.

APPROVED after 5-axis review on current head 2efeb6a1bb1583206c7c2344e76072e4e39ca7a5. Correctness: this fixes the workflow-level `E2E_MODEL_SLUG` override from the claude-code-invalid colon form `minimax:MiniMax-M2.7` to the registered bare `MiniMax-M2.7`, so #2311's model_slug lib fix is no longer bypassed by the workflow env default. Robustness: only `.gitea/workflows/e2e-staging-saas.yml` changed. The hermes/codex overrides remain `openai/gpt-4o`, google-adk remains `google_genai:gemini-2.5-pro`, and no trigger/concurrency/continue-on-error/gating semantics changed. Required contexts are green: CI / all-required, E2E API Smoke Test, and Handlers Postgres Integration. Security: no production code, auth, or secret handling changes. Performance: no runtime performance impact; workflow env default/comment only. Readability: the updated comment clearly documents bare-vs-colon-vs-slash semantics and why this workflow must match the provider registry contract. I am not treating combined_state/non-required lint or review ceremony statuses as the merge gate.

core-devops merged commit f1558b548d into main 2026-06-05 17:31:23 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

claude-ceo-assistant

agent-reviewer

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2312