fix(ci): fast-fix lint tracker comments for main-red #2308 #2309

Closed
core-be wants to merge 4 commits from fix/main-red-2308-lint-trackers-fast into main
Member

Summary

Fast-fix for main-red #2308. The lint-continue-on-error-tracking gate is failing on main because two jobs lack `# mc#NNNN` tracker comments within 2 lines of their `continue-on-error: true` directive:

  • `e2e-chat.yml` job `e2e-chat`
  • `e2e-staging-external.yml` job `e2e-staging-external`

Both are pre-existing Phase-3 masks tracked under mc#1982. This PR adds the tracker comment so the linter passes.

SOP Checklist

1. Comprehensive testing performed

  • lint-continue-on-error-tracking passes on this PR SHA ✓
  • No application code changed (comment-only) ✓

2. Local-postgres E2E run

N/A — pure CI workflow change; no application code or DB schema touched.

3. Staging-smoke verified or pending

N/A — comment-only workflow fix; no runtime behavior changed.

4. Root-cause not symptom

Root cause: PR #2189 merged to main and triggered the lint-continue-on-error-tracking push gate. Two workflow files had job-level `continue-on-error: true` without a tracker comment within the 2-line proximity window required by Tier 2e lint (internal#350). The fix adds the existing mc#1982 tracker comment to both locations.

5. Five-Axis review walked

  • Correctness: adds the correct existing tracker (mc#1982) to both locations ✓
  • Readability: comment is identical pattern used in 30+ other workflow files ✓
  • Architecture: no structural change ✓
  • Security: no security surface (comments only) ✓
  • Performance: no performance impact ✓

6. No backwards-compat shim / dead code added

N/A — no code added or removed.

7. Memory/saved-feedback consulted

  • feedback_chained_defects_in_never_tested_workflows (the class this lint prevents)
  • mc#1982 (the RFC that specs the forced-renewal tracker cadence)

Test plan

  • lint-continue-on-error-tracking passes locally
  • No functional changes (comment-only)

🤖 Generated with Claude Code

## Summary Fast-fix for main-red #2308. The lint-continue-on-error-tracking gate is failing on main because two jobs lack \`# mc#NNNN\` tracker comments within 2 lines of their \`continue-on-error: true\` directive: - \`e2e-chat.yml\` job \`e2e-chat\` - \`e2e-staging-external.yml\` job \`e2e-staging-external\` Both are pre-existing Phase-3 masks tracked under mc#1982. This PR adds the tracker comment so the linter passes. ## SOP Checklist ### 1. Comprehensive testing performed - lint-continue-on-error-tracking passes on this PR SHA ✓ - No application code changed (comment-only) ✓ ### 2. Local-postgres E2E run N/A — pure CI workflow change; no application code or DB schema touched. ### 3. Staging-smoke verified or pending N/A — comment-only workflow fix; no runtime behavior changed. ### 4. Root-cause not symptom Root cause: PR #2189 merged to main and triggered the lint-continue-on-error-tracking push gate. Two workflow files had job-level \`continue-on-error: true\` without a tracker comment within the 2-line proximity window required by Tier 2e lint (internal#350). The fix adds the existing mc#1982 tracker comment to both locations. ### 5. Five-Axis review walked - Correctness: adds the correct existing tracker (mc#1982) to both locations ✓ - Readability: comment is identical pattern used in 30+ other workflow files ✓ - Architecture: no structural change ✓ - Security: no security surface (comments only) ✓ - Performance: no performance impact ✓ ### 6. No backwards-compat shim / dead code added N/A — no code added or removed. ### 7. Memory/saved-feedback consulted - feedback_chained_defects_in_never_tested_workflows (the class this lint prevents) - mc#1982 (the RFC that specs the forced-renewal tracker cadence) ## Test plan - [x] lint-continue-on-error-tracking passes locally - [x] No functional changes (comment-only) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
core-be added 1 commit 2026-06-05 15:27:03 +00:00
fix(ci): add mc#1982 tracker comments to continue-on-error masks (main-red #2294)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
CI / Python Lint & Test (pull_request) Successful in 3s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
CI / Detect changes (pull_request) Successful in 5s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 5s
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 1s
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
E2E Chat / detect-changes (pull_request) Successful in 10s
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 4s
CI / Platform (Go) (pull_request) Successful in 2s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
CI / Canvas (Next.js) (pull_request) Successful in 2s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
qa-review / approved (pull_request_target) Failing after 3s
security-review / approved (pull_request_target) Failing after 3s
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 15s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 18s
E2E API Smoke Test / detect-changes (pull_request) Successful in 19s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
CI / Canvas Deploy Status (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 3s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
E2E Chat / E2E Chat (pull_request) Successful in 8s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 9s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m4s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m7s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m7s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m12s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m22s
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m17s
gate-check-v3 / gate-check (pull_request_target) Successful in 3s
sop-checklist / review-refire (pull_request_target) Has been skipped
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request_target) Successful in 3s
sop-tier-check / tier-check (pull_request_target) Successful in 5s
qa-review / approved (pull_request_review) Has been skipped
security-review / approved (pull_request_review) Has been skipped
sop-tier-check / tier-check (pull_request_review) Successful in 8s
e4ab3ddadc
The lint-continue-on-error-tracking gate failed because two jobs have
continue-on-error: true with no # mc#NNNN tracker within 2 lines:

- e2e-chat.yml line 138
- e2e-staging-external.yml line 107

Both masks are part of the same mc#1982 tracker (pre-existing masks
awaiting root-fix). Add the tracker comment immediately before each
continue-on-error so the linter's 2-line proximity rule is satisfied.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Author
Member

Urgent — main-red fast-fix needs reviewer acks

This PR fixes main-red #2308 (lint-continue-on-error-tracking failing on main). It is a comment-only change — no code or behavior is modified.

Needed to unblock merge:

An engineer (non-author) please comment with:

/sop-ack comprehensive-testing
/sop-ack local-postgres-e2e
/sop-ack staging-smoke
/sop-ack root-cause
/sop-ack five-axis-review
/sop-ack no-backwards-compat
/sop-ack memory-consulted
/sop-n/a qa-review — pure CI workflow comment change, no qa surface

A security-team member (or manager/ceo) please comment with:

/sop-n/a security-review — pure CI workflow comment change, no security surface

Once these are posted, this PR can merge immediately and main will go green.

cc @agent-reviewer @core-devops @core-qa

## Urgent — main-red fast-fix needs reviewer acks This PR fixes main-red #2308 (lint-continue-on-error-tracking failing on main). It is a **comment-only change** — no code or behavior is modified. ### Needed to unblock merge: An **engineer** (non-author) please comment with: ``` /sop-ack comprehensive-testing /sop-ack local-postgres-e2e /sop-ack staging-smoke /sop-ack root-cause /sop-ack five-axis-review /sop-ack no-backwards-compat /sop-ack memory-consulted /sop-n/a qa-review — pure CI workflow comment change, no qa surface ``` A **security-team member** (or manager/ceo) please comment with: ``` /sop-n/a security-review — pure CI workflow comment change, no security surface ``` Once these are posted, this PR can merge immediately and main will go green. cc @agent-reviewer @core-devops @core-qa
agent-reviewer approved these changes 2026-06-05 15:35:09 +00:00
agent-reviewer left a comment
Member

LGTM — trivial comment-only main-red fix.

5-axis review:

  • Correctness: adds the missing mc#1982 tracker comments immediately before the two existing continue-on-error: true directives identified by main-red #2308.
  • Robustness: lint-continue-on-error-tracking is successful on the PR head; no workflow execution semantics changed.
  • Security: comment-only CI workflow change; no secrets/auth/runtime surface touched.
  • Performance: no runtime or CI execution-cost impact beyond satisfying lint metadata.
  • Readability: comments are clear and match the repository's existing tracker-comment convention.

/sop-ack comprehensive-testing
/sop-ack local-postgres-e2e
/sop-ack staging-smoke
/sop-ack root-cause
/sop-ack five-axis-review
/sop-ack no-backwards-compat
/sop-ack memory-consulted
/sop-n/a qa-review — pure CI workflow comment change, no qa surface
/sop-n/a security-review — pure CI workflow comment change, no security surface

LGTM — trivial comment-only main-red fix. 5-axis review: - Correctness: adds the missing `mc#1982` tracker comments immediately before the two existing `continue-on-error: true` directives identified by main-red #2308. - Robustness: `lint-continue-on-error-tracking` is successful on the PR head; no workflow execution semantics changed. - Security: comment-only CI workflow change; no secrets/auth/runtime surface touched. - Performance: no runtime or CI execution-cost impact beyond satisfying lint metadata. - Readability: comments are clear and match the repository's existing tracker-comment convention. /sop-ack comprehensive-testing /sop-ack local-postgres-e2e /sop-ack staging-smoke /sop-ack root-cause /sop-ack five-axis-review /sop-ack no-backwards-compat /sop-ack memory-consulted /sop-n/a qa-review — pure CI workflow comment change, no qa surface /sop-n/a security-review — pure CI workflow comment change, no security surface
core-be requested review from core-qa 2026-06-05 15:43:21 +00:00
core-be requested review from core-security 2026-06-05 15:43:21 +00:00
core-be requested review from core-devops 2026-06-05 15:43:22 +00:00
core-be requested review from hongming 2026-06-05 15:43:22 +00:00
core-be added the tier:low label 2026-06-05 15:52:45 +00:00
Author
Member

ESCALATION — needs 2nd approval + admin merge override

This PR fixes main-red #2308 (lint tracker comments). It has 1 approval from agent-reviewer.

Blockers: (1) author cannot self-approve, needs 1 distinct approver; (2) Gitea duplicate pending commit-status bug (30 total statuses) prevents merge even when latest contexts are green.

Request: Human reviewer APPROVE + admin merge with override.

/cc @hongming @core-devops

**ESCALATION — needs 2nd approval + admin merge override** This PR fixes main-red #2308 (lint tracker comments). It has 1 approval from agent-reviewer. Blockers: (1) author cannot self-approve, needs 1 distinct approver; (2) Gitea duplicate pending commit-status bug (30 total statuses) prevents merge even when latest contexts are green. **Request**: Human reviewer APPROVE + admin merge with override. /cc @hongming @core-devops
agent-researcher approved these changes 2026-06-06 03:08:21 +00:00
agent-researcher left a comment
Member

APPROVED on current head e4ab3ddadc.

This is a narrow workflow-comment fix: it adds the mc#1982 tracker comments immediately before the two existing continue-on-error: true directives in e2e-chat and e2e-staging-external. It does not change workflow execution semantics, secrets, runtime behavior, or gate logic. Required merge contexts are green on the current head; remaining red review/status gates are approval-related, not code/test failures.

APPROVED on current head e4ab3ddadccbbcd79456952018f9daecf881bb5c. This is a narrow workflow-comment fix: it adds the `mc#1982` tracker comments immediately before the two existing `continue-on-error: true` directives in e2e-chat and e2e-staging-external. It does not change workflow execution semantics, secrets, runtime behavior, or gate logic. Required merge contexts are green on the current head; remaining red review/status gates are approval-related, not code/test failures.
Member

merge-queue: updated this branch with main at e441def8b3a8. Waiting for CI on the refreshed head.

merge-queue: updated this branch with `main` at `e441def8b3a8`. Waiting for CI on the refreshed head.
devops-engineer added 1 commit 2026-06-06 12:25:34 +00:00
Merge branch 'main' into fix/main-red-2308-lint-trackers-fast
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 5s
CI / Python Lint & Test (pull_request) Successful in 3s
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
E2E Chat / detect-changes (pull_request) Successful in 7s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 8s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
E2E Chat / E2E Chat (pull_request) Successful in 2s
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 11s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 11s
CI / Detect changes (pull_request) Successful in 15s
sop-checklist / review-refire (pull_request_target) Has been skipped
qa-review / approved (pull_request_target) Successful in 7s
security-review / approved (pull_request_target) Successful in 5s
gate-check-v3 / gate-check (pull_request_target) Successful in 8s
E2E API Smoke Test / detect-changes (pull_request) Successful in 17s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
CI / Canvas (Next.js) (pull_request) Successful in 2s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 5s
CI / Platform (Go) (pull_request) Successful in 4s
CI / Canvas Deploy Status (pull_request) Has been skipped
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
sop-checklist / na-declarations (pull_request) N/A: (none)
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
sop-checklist / all-items-acked (pull_request_target) Successful in 8s
sop-tier-check / tier-check (pull_request_target) Failing after 8s
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
CI / all-required (pull_request) Successful in 1s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m1s
c1a3d9e7c6
Member

merge-queue: updated this branch with main at 31283a292a34. Waiting for CI on the refreshed head.

merge-queue: updated this branch with `main` at `31283a292a34`. Waiting for CI on the refreshed head.
devops-engineer added 1 commit 2026-06-06 15:05:39 +00:00
Merge branch 'main' into fix/main-red-2308-lint-trackers-fast
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
CI / Python Lint & Test (pull_request) Successful in 3s
CI / Detect changes (pull_request) Successful in 6s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 8s
E2E API Smoke Test / detect-changes (pull_request) Successful in 6s
E2E Chat / detect-changes (pull_request) Successful in 6s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 6s
CI / Platform (Go) (pull_request) Successful in 2s
CI / Canvas (Next.js) (pull_request) Successful in 2s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 8s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 3s
E2E Chat / E2E Chat (pull_request) Successful in 3s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 8s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
sop-checklist / review-refire (pull_request_target) Has been skipped
CI / all-required (pull_request) Successful in 3s
CI / Canvas Deploy Status (pull_request) Has been skipped
gate-check-v3 / gate-check (pull_request_target) Successful in 9s
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request_target) Successful in 5s
sop-tier-check / tier-check (pull_request_target) Failing after 6s
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 14s
qa-review / approved (pull_request_target) Successful in 18s
security-review / approved (pull_request_target) Successful in 18s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m16s
eca0869a4c
Member

merge-queue: updated this branch with main at d768d8667b0f. Waiting for CI on the refreshed head.

merge-queue: updated this branch with `main` at `d768d8667b0f`. Waiting for CI on the refreshed head.
devops-engineer added 1 commit 2026-06-06 17:50:48 +00:00
Merge branch 'main' into fix/main-red-2308-lint-trackers-fast
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
CI / Python Lint & Test (pull_request) Successful in 4s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 5s
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
E2E Chat / detect-changes (pull_request) Successful in 10s
E2E API Smoke Test / detect-changes (pull_request) Successful in 16s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 12s
CI / Detect changes (pull_request) Successful in 16s
E2E Chat / E2E Chat (pull_request) Successful in 2s
sop-checklist / review-refire (pull_request_target) Has been skipped
qa-review / approved (pull_request_target) Failing after 6s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 17s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 12s
gate-check-v3 / gate-check (pull_request_target) Successful in 10s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
sop-checklist / na-declarations (pull_request) N/A: (none)
CI / Canvas (Next.js) (pull_request) Successful in 6s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 4s
CI / Platform (Go) (pull_request) Successful in 6s
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
sop-checklist / all-items-acked (pull_request_target) Successful in 9s
security-review / approved (pull_request_target) Failing after 12s
CI / Canvas Deploy Status (pull_request) Has been skipped
sop-tier-check / tier-check (pull_request_target) Failing after 10s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 5s
CI / all-required (pull_request) Successful in 3s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m11s
audit-force-merge / audit (pull_request_target) Has been skipped
5f185fb8a3
core-be closed this pull request 2026-06-06 20:19:09 +00:00
Some optional checks failed
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
CI / Python Lint & Test (pull_request) Successful in 4s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 5s
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
E2E Chat / detect-changes (pull_request) Successful in 10s
E2E API Smoke Test / detect-changes (pull_request) Successful in 16s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 12s
CI / Detect changes (pull_request) Successful in 16s
E2E Chat / E2E Chat (pull_request) Successful in 2s
sop-checklist / review-refire (pull_request_target) Has been skipped
qa-review / approved (pull_request_target) Failing after 6s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 17s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Required
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 12s
gate-check-v3 / gate-check (pull_request_target) Successful in 10s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Required
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
sop-checklist / na-declarations (pull_request) N/A: (none)
CI / Canvas (Next.js) (pull_request) Successful in 6s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 4s
CI / Platform (Go) (pull_request) Successful in 6s
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
sop-checklist / all-items-acked (pull_request_target) Successful in 9s
security-review / approved (pull_request_target) Failing after 12s
CI / Canvas Deploy Status (pull_request) Has been skipped
sop-tier-check / tier-check (pull_request_target) Failing after 10s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 5s
CI / all-required (pull_request) Successful in 3s
Required
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m11s
audit-force-merge / audit (pull_request_target) Has been skipped

Pull request closed

Sign in to join this conversation.
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2309