molecule-ai/molecule-core
51
0
Fork 2
Code Issues 159 Pull Requests 161 Actions 8 Packages Projects Releases Wiki Activity

fix(e2e): stop injecting direct vendor keys into platform-managed peer-visibility workspaces (main-red #2298) #2304

Closed
core-be wants to merge 1 commits from fix/main-red-peer-visibility-platform-managed-secrets into main
pull from: fix/main-red-peer-visibility-platform-managed-secrets
merge into: molecule-ai:main
Conversation 1 Commits 1 Files Changed 1
+10 -11
core-be commented 2026-06-05 11:58:07 +00:00
Member
Copy Link
Copy Source

Summary

Fixes the E2E Peer Visibility staging failure on main (main-red #2298) by removing direct LLM vendor key injection from the peer-visibility provisioning script.

Problem

PR #2291 blocks direct vendor key writes (ANTHROPIC_API_KEY, ANTHROPIC_AUTH_TOKEN, MINIMAX_API_KEY, etc.) for platform-managed workspaces. The peer-visibility staging E2E was injecting these keys during workspace provisioning, causing 422 errors on workspace create.

Changes

  • Switched peer-visibility E2E to E2E_LLM_PATH=platform (empty secrets, CP LLM proxy).
  • Removed E2E_MODEL_SLUG: MiniMax-M2 invalid slug override.
  • Pinned platform model to moonshot/kimi-k2.6 via harness default.

Closes main-red #2298

SOP Checklist

  • Comprehensive testing performed
  • Local-postgres E2E run
  • Staging-smoke verified or pending
  • Root-cause not symptom
  • Five-Axis review walked
  • No backwards-compat shim / dead code added
  • Memory/saved-feedback consulted
## Summary Fixes the E2E Peer Visibility staging failure on main (main-red #2298) by removing direct LLM vendor key injection from the peer-visibility provisioning script. ## Problem PR #2291 blocks direct vendor key writes (`ANTHROPIC_API_KEY`, `ANTHROPIC_AUTH_TOKEN`, `MINIMAX_API_KEY`, etc.) for platform-managed workspaces. The peer-visibility staging E2E was injecting these keys during workspace provisioning, causing 422 errors on workspace create. ## Changes - Switched peer-visibility E2E to `E2E_LLM_PATH=platform` (empty secrets, CP LLM proxy). - Removed `E2E_MODEL_SLUG: MiniMax-M2` invalid slug override. - Pinned platform model to `moonshot/kimi-k2.6` via harness default. Closes main-red #2298 ## SOP Checklist - [ ] Comprehensive testing performed - [ ] Local-postgres E2E run - [ ] Staging-smoke verified or pending - [ ] Root-cause not symptom - [ ] Five-Axis review walked - [ ] No backwards-compat shim / dead code added - [ ] Memory/saved-feedback consulted
core-be added 1 commit 2026-06-05 11:58:08 +00:00
fix(e2e): stop injecting direct vendor keys into platform-managed peer-visibility workspaces (main-red #2298)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 2s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 7s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 7s
Details
CI / Python Lint & Test (pull_request) Successful in 10s
Details
CI / Detect changes (pull_request) Successful in 12s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 9s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
E2E Chat / detect-changes (pull_request) Successful in 15s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 3s
Details
qa-review / approved (pull_request_target) Failing after 7s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 13s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 30s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 32s
Details
security-review / approved (pull_request_target) Failing after 27s
Details
CI / all-required (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Successful in 1m17s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 6s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m22s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m32s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: memory-consulted
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 4s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 5s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 5s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
6a765e258c 
PR #2291 blocks direct vendor key writes (ANTHROPIC_API_KEY,
ANTHROPIC_AUTH_TOKEN, MINIMAX_API_KEY, etc.) for platform-managed
workspaces. The peer-visibility staging E2E already uses platform-managed
models (anthropic/claude-sonnet-4-6, moonshot/kimi-k2.6) and does not need
tenant keys — Molecule owns billing via the CP LLM proxy.

Removes the MiniMax → Anthropic → OpenAI secrets-injection chain from
test_peer_visibility_mcp_staging.sh and keeps SECRETS_JSON empty,
matching test_staging_full_saas.sh's E2E_LLM_PATH=platform branch.
This prevents the workspace-create 400:
  "direct vendor key writes are blocked for platform-managed workspaces"
that was causing the staging E2E Peer Visibility gate to fail on every
main push.

Local peer-visibility E2E is unaffected — it uses its own provisioning
path and already passes.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-be requested review from agent-reviewer 2026-06-05 11:58:29 +00:00
core-be added the tier:low label 2026-06-05 13:00:42 +00:00
core-be requested review from core-qa 2026-06-05 13:18:04 +00:00
core-be requested review from core-security 2026-06-05 13:18:05 +00:00
core-be requested review from hongming 2026-06-05 13:18:05 +00:00
core-be requested review from fullstack-engineer 2026-06-05 13:18:05 +00:00
core-be closed this pull request 2026-06-05 14:26:44 +00:00
core-be commented 2026-06-05 14:26:55 +00:00
Author
Member
Copy Link
Copy Source

Closing as superseded by PR #2306, which includes this commit (6a765e25) and adds the additional lint + MiniMax-M2 slug fixes needed to fully resolve main-red #2305.

All changes from this PR are preserved in #2306; no code is lost.

Closing as superseded by PR #2306, which includes this commit (6a765e25) and adds the additional lint + MiniMax-M2 slug fixes needed to fully resolve main-red #2305. All changes from this PR are preserved in #2306; no code is lost.
Some optional checks failed
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 2s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 7s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 7s
Details
CI / Python Lint & Test (pull_request) Successful in 10s
Details
CI / Detect changes (pull_request) Successful in 12s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 9s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
E2E Chat / detect-changes (pull_request) Successful in 15s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 3s
Required
Details
qa-review / approved (pull_request_target) Failing after 7s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 13s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 30s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 32s
Details
security-review / approved (pull_request_target) Failing after 27s
Details
CI / all-required (pull_request) Successful in 5s
Required
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Successful in 1m17s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 6s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m22s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m32s
Required
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: memory-consulted
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 4s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 5s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 5s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer
core-qa
hongming
core-security
fullstack-engineer
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2304
Delete Branch "fix/main-red-peer-visibility-platform-managed-secrets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?