molecule-ai/molecule-core
51
0
Fork 2
Code Issues 160 Pull Requests 162 Actions 7 Packages Projects Releases Wiki Activity

fix(ci): add mc#1982 tracker comments to continue-on-error masks (main-red #2294) #2295

Closed
core-be wants to merge 1 commits from fix/main-red-lint-continue-on-error-2294 into main
pull from: fix/main-red-lint-continue-on-error-2294
merge into: molecule-ai:main
Conversation 3 Commits 1 Files Changed 2
+2
core-be commented 2026-06-05 08:14:18 +00:00
Member
Copy Link
Copy Source

Fixes main-red #2294.

The lint-continue-on-error-tracking gate failed because two jobs have continue-on-error: true with no # mc#NNNN tracker within 2 lines:

  • e2e-chat.yml line 138
  • e2e-staging-external.yml line 107

Both masks are part of the same mc#1982 tracker (pre-existing masks awaiting root-fix). Add the tracker comment immediately before each continue-on-error so the linter's 2-line proximity rule is satisfied.

Closes #2294

Comprehensive testing performed

  • lint-continue-on-error-tracking passes on this branch (verified in CI).
  • No functional code changes; only YAML comment additions.

Local-postgres E2E run

N/A — this change touches only Gitea workflow YAML; no database or backend code is modified.

Staging-smoke verified or pending

N/A — workflow lint fix with no runtime impact. The existing E2E jobs that exercise these workflows already run in this PR and pass.

Root-cause not symptom

Root cause: the lint-continue-on-error-tracking gate (added in internal#802) requires a # mc#NNNN or # internal#NNNN tracker comment within 2 lines of every continue-on-error: true. Two pre-existing masks lacked this proximity comment, causing main-red.

Five-Axis review walked

  • Correctness: comment-only, no logic change.
  • Readability: tracker comment mirrors the existing mc#1982 pattern used elsewhere.
  • Architecture: no structural change.
  • Security: no security surface (comments in CI YAML).
  • Performance: no performance impact.

No backwards-compat shim / dead code added

No shim or dead code. Only adds mandatory tracker comments to satisfy the linter.

Memory/saved-feedback consulted

mc#1982 (pre-existing continue-on-error mask tracking).

Fixes main-red #2294. The `lint-continue-on-error-tracking` gate failed because two jobs have `continue-on-error: true` with no `# mc#NNNN` tracker within 2 lines: - `e2e-chat.yml` line 138 - `e2e-staging-external.yml` line 107 Both masks are part of the same **mc#1982** tracker (pre-existing masks awaiting root-fix). Add the tracker comment immediately before each `continue-on-error` so the linter's 2-line proximity rule is satisfied. Closes #2294 ## Comprehensive testing performed - `lint-continue-on-error-tracking` passes on this branch (verified in CI). - No functional code changes; only YAML comment additions. ## Local-postgres E2E run N/A — this change touches only Gitea workflow YAML; no database or backend code is modified. ## Staging-smoke verified or pending N/A — workflow lint fix with no runtime impact. The existing E2E jobs that exercise these workflows already run in this PR and pass. ## Root-cause not symptom Root cause: the lint-continue-on-error-tracking gate (added in internal#802) requires a `# mc#NNNN` or `# internal#NNNN` tracker comment within 2 lines of every `continue-on-error: true`. Two pre-existing masks lacked this proximity comment, causing main-red. ## Five-Axis review walked - Correctness: comment-only, no logic change. - Readability: tracker comment mirrors the existing mc#1982 pattern used elsewhere. - Architecture: no structural change. - Security: no security surface (comments in CI YAML). - Performance: no performance impact. ## No backwards-compat shim / dead code added No shim or dead code. Only adds mandatory tracker comments to satisfy the linter. ## Memory/saved-feedback consulted mc#1982 (pre-existing continue-on-error mask tracking).
core-be added 1 commit 2026-06-05 08:14:18 +00:00
fix(ci): add mc#1982 tracker comments to continue-on-error masks (main-red #2294)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 1s
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 17s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 21s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 21s
Details
E2E Chat / detect-changes (pull_request) Successful in 21s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 7s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 19s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 19s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 28s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 28s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 14s
Details
security-review / approved (pull_request_target) Failing after 4s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m12s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m8s
Details
qa-review / approved (pull_request_target) Failing after 38s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m22s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m28s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 3s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Details
CI / Platform (Go) (pull_request) Successful in 36s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 2m20s
Details
CI / Canvas (Next.js) (pull_request) Successful in 36s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 4s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m6s
Details
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-tier-check / tier-check (pull_request_review) Successful in 9s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 3s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 3s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 6s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
ee1affa41f 
The lint-continue-on-error-tracking gate failed because two jobs have
continue-on-error: true with no # mc#NNNN tracker within 2 lines:

- e2e-chat.yml line 138
- e2e-staging-external.yml line 107

Both masks are part of the same mc#1982 tracker (pre-existing masks
awaiting root-fix). Add the tracker comment immediately before each
continue-on-error so the linter's 2-line proximity rule is satisfied.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-be added the tier:high label 2026-06-05 08:18:25 +00:00
core-be closed this pull request 2026-06-05 08:19:03 +00:00
core-be reopened this pull request 2026-06-05 08:19:06 +00:00
core-be commented 2026-06-05 08:29:18 +00:00
Author
Member
Copy Link
Copy Source

URGENT main-red fix — main is currently RED on lint-continue-on-error-tracking (#2294). This PR adds the missing # mc#1982 tracker comments to two workflow files.

Needs:

  • Any approving review (tier-check gate)
  • Security team ack (security-review gate)
  • QA team ack (qa-review gate)

The fix is a 2-line comment-only change (zero functional impact). Please review/ack when you can so we can unbreak main.

**URGENT main-red fix** — main is currently RED on `lint-continue-on-error-tracking` (#2294). This PR adds the missing `# mc#1982` tracker comments to two workflow files. Needs: - Any approving review (tier-check gate) - Security team ack (security-review gate) - QA team ack (qa-review gate) The fix is a 2-line comment-only change (zero functional impact). Please review/ack when you can so we can unbreak main.
agent-reviewer approved these changes 2026-06-05 08:32:00 +00:00
agent-reviewer left a comment
Member
Copy Link
Copy Source

5-axis review: APPROVED.

Correctness: This only annotates the two existing continue-on-error masks with the mc#1982 tracker and explicit root-fix/remove guidance. It does not add, broaden, or renew any masking behavior.

Robustness: The comments make the temporary nature of the masks more visible for future workflow edits. Security: no secrets, auth, or execution path changes. Performance: no runtime impact. Readability: the added comments are concise and placed directly beside the masked jobs they explain.

Required-context review: head ee1affa41f is mergeable; CI/all-required, E2E API Smoke, Handlers PG, and Platform Go are green. Combined red is unrelated ceremony/continue-on-error status and was not used as the merge gate.

5-axis review: APPROVED. Correctness: This only annotates the two existing continue-on-error masks with the mc#1982 tracker and explicit root-fix/remove guidance. It does not add, broaden, or renew any masking behavior. Robustness: The comments make the temporary nature of the masks more visible for future workflow edits. Security: no secrets, auth, or execution path changes. Performance: no runtime impact. Readability: the added comments are concise and placed directly beside the masked jobs they explain. Required-context review: head ee1affa41f9bba1faa7c769fd21e3fb5a711d02e is mergeable; CI/all-required, E2E API Smoke, Handlers PG, and Platform Go are green. Combined red is unrelated ceremony/continue-on-error status and was not used as the merge gate.
core-be closed this pull request 2026-06-05 14:31:38 +00:00
core-be commented 2026-06-05 14:31:55 +00:00
Author
Member
Copy Link
Copy Source

Closing as superseded by PR #2306.

Critical: this branch was based on an old main (pre-#2291/#2292/#2293/#2296). Merging it now would revert the fail-closed auth hardening and other merged work.

All lint tracker fixes from this PR are already present in #2306, which is correctly rebased onto current main HEAD (f78fef4c).

Closing as superseded by PR #2306. **Critical: this branch was based on an old main** (pre-#2291/#2292/#2293/#2296). Merging it now would revert the fail-closed auth hardening and other merged work. All lint tracker fixes from this PR are already present in #2306, which is correctly rebased onto current main HEAD (f78fef4c).
Some optional checks failed
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 1s
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 17s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 21s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 21s
Details
E2E Chat / detect-changes (pull_request) Successful in 21s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 7s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 19s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 19s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 28s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 28s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 14s
Details
security-review / approved (pull_request_target) Failing after 4s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m12s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m8s
Details
qa-review / approved (pull_request_target) Failing after 38s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m22s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m28s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 3s
Required
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Required
Details
CI / Platform (Go) (pull_request) Successful in 36s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 2m20s
Details
CI / Canvas (Next.js) (pull_request) Successful in 36s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 4s
Required
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m6s
Details
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-tier-check / tier-check (pull_request_review) Successful in 9s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 3s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 3s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 6s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:high
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2295
Delete Branch "fix/main-red-lint-continue-on-error-2294"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?