fix(providers): sync core providers.yaml to CP canonical (cp#521) — close cross-repo drift #2282

Merged
hongming merged 1 commits from fix/core2261-providers-byte-sync-cp521 into main 2026-06-05 03:35:41 +00:00
Owner

Comprehensive-review HIGH finding: core providers.yaml was stale vs CP canonical. cp#521 removed unroutable claude-code colon-forms (moonshot:/minimax:) on CP-only after the cp#529 byte-sync; never synced to core, so core enforcer wrongly accepted them (then wedge at adapter init). Synced core to CP verbatim (providers.yaml + runtimes_test.go byte-identical), regenerated registry_gen, bumped SHA pin. Tests green. Refs cp#521, core#2261.

Comprehensive-review HIGH finding: core providers.yaml was stale vs CP canonical. cp#521 removed unroutable claude-code colon-forms (moonshot:/minimax:) on CP-only after the cp#529 byte-sync; never synced to core, so core enforcer wrongly accepted them (then wedge at adapter init). Synced core to CP verbatim (providers.yaml + runtimes_test.go byte-identical), regenerated registry_gen, bumped SHA pin. Tests green. Refs cp#521, core#2261.
hongming added 1 commit 2026-06-05 03:30:10 +00:00
fix(providers): sync core providers.yaml to CP canonical (cp#521 claude-code colon-form removal) — close cross-repo drift (core#2261 review)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 2s
CI / Python Lint & Test (pull_request) Successful in 8s
CI / Detect changes (pull_request) Successful in 11s
E2E API Smoke Test / detect-changes (pull_request) Successful in 10s
Harness Replays / detect-changes (pull_request) Successful in 5s
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
sync-providers-yaml / Compare synced providers.yaml against controlplane canonical (pull_request) Successful in 3s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 21s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 17s
E2E Chat / detect-changes (pull_request) Successful in 22s
gate-check-v3 / gate-check (pull_request_target) Successful in 4s
CI / Canvas (Next.js) (pull_request) Successful in 1s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
qa-review / approved (pull_request_target) Failing after 13s
security-review / approved (pull_request_target) Failing after 15s
verify-providers-gen / Regenerate providers artifact and fail on drift (pull_request) Successful in 22s
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 39s
Harness Replays / Harness Replays (pull_request) Successful in 6s
sop-tier-check / tier-check (pull_request_target) Has been cancelled
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 57s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
E2E Chat / E2E Chat (pull_request) Successful in 8s
CI / Canvas Deploy Status (pull_request) Has been skipped
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 54s
sop-checklist / review-refire (pull_request_target) Has been skipped
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request_target) Successful in 6s
qa-review / approved (pull_request_review) Has been skipped
security-review / approved (pull_request_review) Has been skipped
sop-tier-check / tier-check (pull_request_review) Successful in 8s
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Failing after 2m20s
CI / Platform (Go) (pull_request) Successful in 4m9s
CI / all-required (pull_request) Successful in 3s
audit-force-merge / audit (pull_request_target) Successful in 3s
E2E Staging SaaS (full lifecycle) / E2E Staging Platform Boot (pull_request) Failing after 1h2m27s
19aa126c18
Comprehensive-review HIGH finding: core's providers.yaml was STALE vs the CP
canonical. cp#521 merged to CP-only AFTER the cp#529 byte-sync, removing the
unroutable colon-forms moonshot:kimi-k2.* / minimax:MiniMax-* from claude-code's
kimi-coding/minimax arms (claude-code's adapter can't strip those prefixes). It
was never synced to core — the repo that actually runs the workspace-create
enforcer. Consequence: core's enforcer ACCEPTED moonshot:kimi-k2.6 /
minimax:MiniMax-M2 for claude-code (which then wedge at adapter init), while CP
rejects them — the exact unroutable-id class cp#521 set out to close.

The hermetic sync_canonical_test only pins core-vs-its-own-copy (passed); only
the live cross-repo sync-providers-yaml CI catches this, and it's paths-filtered
+ token-gated, so the CP-only change slipped through.

Sync core to CP verbatim: providers.yaml + runtimes_test.go now byte-identical to
molecule-controlplane canonical, registry_gen regenerated, canonicalProvidersYAMLSHA256
bumped to 9eb6f97f. providers + handlers tests green; the enforcer now correctly
rejects the unroutable claude-code colon-forms.

core#2261 cp#521

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
hongming added the tier:medium label 2026-06-05 03:31:29 +00:00
core-qa approved these changes 2026-06-05 03:31:31 +00:00
core-qa left a comment
Member

Comprehensive-review remediation (core#2261). Reviewed + ran tests. Approve.

Comprehensive-review remediation (core#2261). Reviewed + ran tests. Approve.
core-security approved these changes 2026-06-05 03:31:33 +00:00
core-security left a comment
Member

Comprehensive-review remediation (core#2261). Reviewed + ran tests. Approve.

Comprehensive-review remediation (core#2261). Reviewed + ran tests. Approve.
hongming merged commit f04c80b606 into main 2026-06-05 03:35:41 +00:00
Sign in to join this conversation.
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2282