fix(e2e): reconciler e2e — platform create path + capture 400 body (core#2261) #2276

Merged

hongming merged 2 commits from fix/core2261-reconciler-e2e-create into main 2026-06-05 02:55:37 +00:00

Conversation 0 Commits 2 Files Changed 2

+32 -7

hongming commented 2026-06-05 02:22:06 +00:00

Owner

Copy Link

Copy Source

Unblocks the live reconciler e2e. It was failing at workspace-create (HTTP 400) because it used the BYOK path (MiniMax-M2 + secret); switched to the platform-managed path (moonshot/kimi-k2.6, no key) that test_staging_full_saas.sh creates cleanly with. Also fixes the set -e/--fail-with-body bug that hid the 400 body. Dispatched a live staging run to prove the reconciler heals a terminated EC2. Refs core#2261.

Unblocks the live reconciler e2e. It was failing at workspace-create (HTTP 400) because it used the BYOK path (MiniMax-M2 + secret); switched to the platform-managed path (moonshot/kimi-k2.6, no key) that test_staging_full_saas.sh creates cleanly with. Also fixes the set -e/--fail-with-body bug that hid the 400 body. Dispatched a live staging run to prove the reconciler heals a terminated EC2. Refs core#2261.

hongming added 1 commit 2026-06-05 02:22:07 +00:00

fix(e2e): reconciler e2e — use platform-managed create path + capture 400 body (core#2261) ... 6447edd2fd

Two fixes so the live reconciler e2e can actually reach its assertion:
1. The create 400'd because the script used the BYOK path (MiniMax-M2 +
   MINIMAX_API_KEY secret) — a combo that fails workspace-create. Add the
   E2E_LLM_PATH=platform branch (DEFAULT) mirroring test_staging_full_saas.sh:
   moonshot/kimi-k2.6, no tenant key — the create combo proven to succeed.
   This test only needs the workspace status=online (then it kills the EC2),
   so it doesn't need a real LLM completion.
2. set -e + curl --fail-with-body aborted the create command-substitution
   before the fail line could echo $WS_RESP, hiding the real HTTP-400 reason.
   Capture the body via `|| { fail "...$WS_RESP" }` so any future create
   failure is diagnosable.

core#2261

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

hongming added 1 commit 2026-06-05 02:51:22 +00:00

fix(e2e): reconciler e2e — fail fast on online-wait (900s) to avoid EC2 leak (core#2261) ... d8ff0b2503

Run 216031 hung ~32min in the boot-to-online poll (3600s default) and leaked a
running staging e2e-rec EC2 — the workspace never reached online (a staging
boot/serving issue, same root as the full-saas A2A failures, upstream of the
reconciler this test exercises). Reduce the online timeout default to 900s so a
non-booting workspace fails fast and the teardown trap terminates the EC2
instead of hanging ~1h. Does not change what the test proves once staging can
boot a workspace online.

core#2261

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

hongming referenced this pull request 2026-06-05 02:51:55 +00:00

Staging: workspaces not reaching status=online — blocks ALL staging e2e (full-saas + reconciler live-proof) #2280

hongming added the tier:low label 2026-06-05 02:55:06 +00:00

core-security approved these changes 2026-06-05 02:55:10 +00:00

core-security left a comment

Member

Copy Link

Copy Source

Security (core#2261). Test-only + e2e. Fail-fast + guaranteed teardown trap prevent leaked EC2s; no prod surface. Approve.

Security (core#2261). Test-only + e2e. Fail-fast + guaranteed teardown trap prevent leaked EC2s; no prod surface. Approve.

core-qa approved these changes 2026-06-05 02:55:34 +00:00

core-qa left a comment

Member

Copy Link

Copy Source

QA approve (core#2261 reconciler e2e fixes: create-path + fail-fast + diagnosability). Required CI green.

QA approve (core#2261 reconciler e2e fixes: create-path + fail-fast + diagnosability). Required CI green.

hongming merged commit 91c9893ad4 into main 2026-06-05 02:55:37 +00:00

hongming referenced this pull request 2026-06-05 03:02:19 +00:00

Staging: workspaces not reaching status=online — blocks ALL staging e2e (full-saas + reconciler live-proof) #2280

hongming referenced this pull request 2026-06-05 03:12:23 +00:00

Workspace registry can point at a terminated EC2 with status=online — no instance-state reconciler (root gap behind core#2247) #2261

Sign in to join this conversation.

Reviewers

No Reviewers

core-security

core-qa

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label tier:low

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2276