molecule-ai/molecule-core
52
0
Fork 2
Code Issues 178 Pull Requests 50 Actions 12 Packages Projects Releases Wiki Activity

feat(sop-checklist): add Owners to security-review N/A eligibility #2271

Closed
core-be wants to merge 1 commits from fix/security-review-owners-na-eligibility into main
pull from: fix/security-review-owners-na-eligibility
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 1
+2 -2
core-be commented 2026-06-05 01:26:08 +00:00
Member
Copy Link
Copy Source

Summary

Adds Owners to the security-review N/A gate required_teams list.

This is a governance-only config change: it widens who can declare security-review N/A on docs-only / pure-frontend / dependency-only PRs from {security, managers, ceo} → {security, managers, ceo, Owners}.

Why separate PR

This was originally bundled in PR #1408 (em-dash parser fix) but split out per CEO directive: changing WHO CAN WAIVE the security gate is significant enough to warrant its own review thread with explicit security/CTO sign-off.

Comprehensive testing performed

  • python3 .gitea/scripts/tests/test_sop_checklist.py passes (no script logic changed — only config YAML)
  • python3 .gitea/scripts/sop-checklist.py loads the updated config without error

Local-postgres E2E run

N/A — YAML config-only change.

Staging-smoke verified or pending

N/A — no runtime/deploy surface.

Root-cause not symptom

N/A — governance/policy change, not a bug fix.

Security/CTO review requested

@core-security @core-lead — please review the eligibility widening. Owners team has 1 member (per orchestrator preflight 2026-05-12). This PR requires your explicit sign-off before merge.

## Summary Adds Owners to the security-review N/A gate required_teams list. This is a **governance-only** config change: it widens who can declare security-review N/A on docs-only / pure-frontend / dependency-only PRs from {security, managers, ceo} → {security, managers, ceo, Owners}. ## Why separate PR This was originally bundled in PR #1408 (em-dash parser fix) but split out per CEO directive: changing WHO CAN WAIVE the security gate is significant enough to warrant its own review thread with explicit security/CTO sign-off. ## Comprehensive testing performed - [x] python3 .gitea/scripts/tests/test_sop_checklist.py passes (no script logic changed — only config YAML) - [x] python3 .gitea/scripts/sop-checklist.py loads the updated config without error ## Local-postgres E2E run N/A — YAML config-only change. ## Staging-smoke verified or pending N/A — no runtime/deploy surface. ## Root-cause not symptom N/A — governance/policy change, not a bug fix. ## Security/CTO review requested @core-security @core-lead — please review the eligibility widening. Owners team has 1 member (per orchestrator preflight 2026-05-12). This PR requires your explicit sign-off before merge.
core-be added 1 commit 2026-06-05 01:26:09 +00:00
feat(sop-checklist): add Owners to security-review N/A eligibility
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 2s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 10s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
qa-review / approved (pull_request_target) Failing after 4s
Details
security-review / approved (pull_request_target) Failing after 5s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: five-axis-review, no-backwards-compat, m
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
CI / Canvas (Next.js) (pull_request) Successful in 1s
Details
CI / Platform (Go) (pull_request) Successful in 1s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 3s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 13s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 13s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 12s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
E2E Chat / detect-changes (pull_request) Successful in 15s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 15s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 12s
Details
E2E Chat / E2E Chat (pull_request) Successful in 1s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 4s
Details
CI / all-required (pull_request) Successful in 1s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 57s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
4ac785e352 
Widens who can declare security-review N/A on docs-only / pure-frontend /
dependency-only PRs from {security, managers, ceo} → {security, managers,
ceo, Owners}. This is a governance change requiring explicit security/CTO
review and sign-off.

Extracted from PR #1408 per CEO directive: changing WHO CAN WAIVE the
security gate is significant enough to warrant its own review thread.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-be closed this pull request 2026-06-05 01:28:35 +00:00
Some checks are pending
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 2s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 10s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
qa-review / approved (pull_request_target) Failing after 4s
Details
security-review / approved (pull_request_target) Failing after 5s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: five-axis-review, no-backwards-compat, m
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
CI / Canvas (Next.js) (pull_request) Successful in 1s
Details
CI / Platform (Go) (pull_request) Successful in 1s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 3s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 13s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 13s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 12s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
E2E Chat / detect-changes (pull_request) Successful in 15s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 15s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Required
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 12s
Details
E2E Chat / E2E Chat (pull_request) Successful in 1s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 4s
Required
Details
CI / all-required (pull_request) Successful in 1s
Required
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 57s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2271
Delete Branch "fix/security-review-owners-na-eligibility"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?