molecule-ai/molecule-core
51
0
Fork 2
Code Issues 185 Pull Requests 48 Actions 1 Packages Projects Releases Wiki Activity

test(display): integration test for the take-control WS-proxy + signed-token path (core#2261) #2269

Merged
hongming merged 1 commits from feat/core2261-takecontrol-wsproxy-test into main 2026-06-05 00:47:14 +00:00
Conversation 2 Commits 1 Files Changed 1
+331
hongming commented 2026-06-05 00:40:52 +00:00
Owner
Copy Link
Copy Source

Adds a server-side integration test for the desktop take-control WS-proxy path in workspace-server's DisplaySession handler. It covers the WS-1006 regression surface from core#2247 — the display websocket proxy upgrade + signed-token handshake + bidirectional byte flow — entirely without EC2/desktop/noVNC.

What it exercises

  • Positive: a valid signDisplaySessionToken(...) + active control lock + display-enabled workspace → the WS upgrade succeeds (HTTP 101), the fake websockify backend's RFB 003.008 greeting arrives through the reverse proxy, and a client→server byte echoes back (proves the bidirectional proxy chain end-to-end).
  • Negative (table-driven): missing token → 403; tampered/garbage token → 403; expired lock → 403; display.mode=none → 404; empty instance_id → 503; proxyPath != /websockify → 404. Each asserts the upgrade does not happen and that the rejection never leaks to the upstream backend.

How it's wired (no network/EC2)

  • The injectable displayForward package var is overridden to return a fake httptest websockify backend URL (gorilla/websocket upgrader that writes the RFB greeting then echoes), restored via t.Cleanup.
  • The two DB reads (loadWorkspaceDisplaySessionTarget, loadActiveDisplayControl) are mocked with sqlmock, mirroring the sibling workspace_display_control_test.go harness; DISPLAY_SESSION_SIGNING_SECRET is set via t.Setenv.
  • DisplaySession is mounted on a gin router behind httptest.NewServer, dialed by a real websocket.Dialer with Sec-WebSocket-Protocol: binary, molecule-display-token.<token>.

Complements the canvas reconnect unit tests (DisplayTab.test.tsx); the real auto-heal is the core#2261 reconciler. Deterministic, fast, short timeouts, all servers/conns closed via t.Cleanup.

Refs core#2261, core#2247.

DO NOT MERGE — heavy core SOP gate.

🤖 Generated with Claude Code

Adds a server-side integration test for the desktop **take-control WS-proxy path** in workspace-server's `DisplaySession` handler. It covers the **WS-1006 regression surface** from core#2247 — the display websocket proxy upgrade + signed-token handshake + bidirectional byte flow — entirely **without EC2/desktop/noVNC**. ## What it exercises - **Positive**: a valid `signDisplaySessionToken(...)` + active control lock + display-enabled workspace → the WS upgrade **succeeds (HTTP 101)**, the fake websockify backend's `RFB 003.008` greeting arrives **through the reverse proxy**, and a client→server byte **echoes back** (proves the bidirectional proxy chain end-to-end). - **Negative (table-driven)**: missing token → 403; tampered/garbage token → 403; expired lock → 403; `display.mode=none` → 404; empty `instance_id` → 503; `proxyPath != /websockify` → 404. Each asserts the upgrade does **not** happen and that the rejection never leaks to the upstream backend. ## How it's wired (no network/EC2) - The injectable `displayForward` package var is overridden to return a fake `httptest` websockify backend URL (gorilla/websocket upgrader that writes the RFB greeting then echoes), restored via `t.Cleanup`. - The two DB reads (`loadWorkspaceDisplaySessionTarget`, `loadActiveDisplayControl`) are mocked with sqlmock, mirroring the sibling `workspace_display_control_test.go` harness; `DISPLAY_SESSION_SIGNING_SECRET` is set via `t.Setenv`. - `DisplaySession` is mounted on a gin router behind `httptest.NewServer`, dialed by a real `websocket.Dialer` with `Sec-WebSocket-Protocol: binary, molecule-display-token.<token>`. Complements the canvas reconnect unit tests (`DisplayTab.test.tsx`); the real auto-heal is the core#2261 reconciler. Deterministic, fast, short timeouts, all servers/conns closed via `t.Cleanup`. Refs core#2261, core#2247. DO NOT MERGE — heavy core SOP gate. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
hongming added 1 commit 2026-06-05 00:40:52 +00:00
test(display): integration test for the take-control WS-proxy + signed-token path (core#2261)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 1s
Details
Harness Replays / detect-changes (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 8s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 8s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
Details
security-review / approved (pull_request_target) Failing after 5s
Details
qa-review / approved (pull_request_target) Failing after 5s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 6s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 9s
Details
CI / Detect changes (pull_request) Successful in 14s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 13s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1s
Details
E2E Chat / detect-changes (pull_request) Successful in 14s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 4s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 3s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
E2E Chat / E2E Chat (pull_request) Successful in 4s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m1s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 57s
Details
sop-tier-check / tier-check (pull_request_target) Has been cancelled
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
qa-review / approved (pull_request_review) Has been skipped
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m12s
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 4s
Details
sop-tier-check / tier-check (pull_request_review) Successful in 5s
Details
CI / Platform (Go) (pull_request) Successful in 4m1s
Details
CI / all-required (pull_request) Successful in 8s
Details
audit-force-merge / audit (pull_request_target) Successful in 7s
Details
d7484f7df4 
Server-side integration test for the workspace-server DisplaySession
WS-proxy + signed-token handshake, covering the WS-1006 regression
surface (proxy upgrade + token validation + bidirectional bytes) from
core#2247 — without any EC2/desktop/noVNC.

Positive: valid signed token + active lock + enabled display upgrades
(HTTP 101), the fake websockify backend's RFB greeting arrives through
the proxy, and a client->server byte echoes back end-to-end.

Negative (table-driven): missing token (403), tampered token (403),
expired lock (403), display mode none (404), empty instance_id (503),
wrong proxyPath (404) — each asserts no upgrade and no leak to upstream.

displayForward is overridden to a fake httptest websockify backend and
DB reads are sqlmock-ed, mirroring the sibling display-control test
harness. Complements the canvas reconnect unit tests (DisplayTab).

Refs core#2261, core#2247.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
hongming added the tier:low label 2026-06-05 00:42:16 +00:00
core-qa approved these changes 2026-06-05 00:42:18 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

QA (core#2261 take-control WS-proxy test). Ran it myself: positive asserts 101 upgrade + RFB greeting through proxy + bidirectional echo; 6 rejections (missing/tampered/expired token, mode=none, empty instance_id, wrong path) each assert no-upgrade + never-reaches-upstream. Deterministic. Good fixture correction (mode=desktop-control/protocol=novnc). Approve.

QA (core#2261 take-control WS-proxy test). Ran it myself: positive asserts 101 upgrade + RFB greeting through proxy + bidirectional echo; 6 rejections (missing/tampered/expired token, mode=none, empty instance_id, wrong path) each assert no-upgrade + never-reaches-upstream. Deterministic. Good fixture correction (mode=desktop-control/protocol=novnc). Approve.
core-security approved these changes 2026-06-05 00:42:19 +00:00
core-security left a comment
Member
Copy Link
Copy Source

Security (core#2261). Test-only; no prod surface. Notably it locks in the token-auth guard: tampered/expired/missing signed tokens are proven to 403 and never reach the upstream proxy. Approve.

Security (core#2261). Test-only; no prod surface. Notably it locks in the token-auth guard: tampered/expired/missing signed tokens are proven to 403 and never reach the upstream proxy. Approve.
hongming merged commit d34d09db01 into main 2026-06-05 00:47:14 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-qa
core-security
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2269
Delete Branch "feat/core2261-takecontrol-wsproxy-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?