molecule-ai/molecule-core
52
0
Fork 2
Code Issues 178 Pull Requests 50 Actions 3 Packages Projects Releases Wiki Activity

feat(sop-checklist): add Owners to security-review N/A eligibility #2267

Closed
core-be wants to merge 1 commits from feat/security-review-owners-na-eligibility into main
pull from: feat/security-review-owners-na-eligibility
merge into: molecule-ai:main
Conversation 3 Commits 1 Files Changed 1
+2 -2
core-be commented 2026-06-05 00:25:47 +00:00
Member
Copy Link
Copy Source

Summary

Adds Owners to the security-review N/A gate required_teams list.

This is a governance-only config change: it widens who can declare security-review N/A on docs-only / pure-frontend / dependency-only PRs from {security, managers, ceo} → {security, managers, ceo, Owners}.

Why separate PR

This was originally bundled in PR #1408 (em-dash parser fix) but split out per CEO directive: changing WHO CAN WAIVE the security gate is significant enough to warrant its own review thread with explicit security/CTO sign-off.

Comprehensive testing performed

  • python3 .gitea/scripts/tests/test_sop_checklist.py passes (no script logic changed — only config YAML)
  • python3 .gitea/scripts/sop-checklist.py loads the updated config without error

Local-postgres E2E run

N/A — YAML config-only change.

Staging-smoke verified or pending

N/A — no runtime/deploy surface.

Root-cause not symptom

N/A — governance/policy change, not a bug fix.

Security/CTO review requested

@core-security @core-lead — please review the eligibility widening. Owners team has 1 member (per orchestrator preflight 2026-05-12). This PR requires your explicit APPROVE before merge.

Five-Axis review walked

  • Correctness: Config-only change, no runtime impact.
  • Readability: Explicit team list with comment.
  • Architecture: Aligns N/A eligibility with existing qa/eng pattern.
  • Security: No new surface.
  • Performance: No impact.

No backwards-compat shim / dead code added

Yes — no shim. Pure config update.

Memory/saved-feedback consulted

Cross-checked sop-checklist-config.yaml structure and RFC#351 team-mapping guidance.

## Summary Adds `Owners` to the `security-review` N/A gate required_teams list. This is a **governance-only** config change: it widens who can declare `security-review` N/A on docs-only / pure-frontend / dependency-only PRs from {security, managers, ceo} → {security, managers, ceo, Owners}. ## Why separate PR This was originally bundled in PR #1408 (em-dash parser fix) but split out per CEO directive: changing WHO CAN WAIVE the security gate is significant enough to warrant its own review thread with explicit security/CTO sign-off. ## Comprehensive testing performed - [x] `python3 .gitea/scripts/tests/test_sop_checklist.py` passes (no script logic changed — only config YAML) - [x] `python3 .gitea/scripts/sop-checklist.py` loads the updated config without error ## Local-postgres E2E run N/A — YAML config-only change. ## Staging-smoke verified or pending N/A — no runtime/deploy surface. ## Root-cause not symptom N/A — governance/policy change, not a bug fix. ## Security/CTO review requested @core-security @core-lead — please review the eligibility widening. Owners team has 1 member (per orchestrator preflight 2026-05-12). This PR requires your explicit APPROVE before merge. ## Five-Axis review walked - **Correctness**: Config-only change, no runtime impact. - **Readability**: Explicit team list with comment. - **Architecture**: Aligns N/A eligibility with existing qa/eng pattern. - **Security**: No new surface. - **Performance**: No impact. ## No backwards-compat shim / dead code added Yes — no shim. Pure config update. ## Memory/saved-feedback consulted Cross-checked sop-checklist-config.yaml structure and RFC#351 team-mapping guidance.
core-be added 1 commit 2026-06-05 00:25:47 +00:00
feat(sop-checklist): add Owners to security-review N/A eligibility\n\nAllows Owners team members to declare security-review N/A on\ndocs-only / pure-frontend / dependency-only PRs, matching the\nexisting description text.
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-tier-check / tier-check (pull_request_review) Successful in 4s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 5s
Details
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 10s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 14s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 11s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 11s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 14s
Details
E2E Chat / detect-changes (pull_request) Successful in 15s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 12s
Details
qa-review / approved (pull_request_target) Failing after 11s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 14s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
CI / all-required (pull_request) Successful in 3s
Details
security-review / approved (pull_request_target) Failing after 10s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 11s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m3s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
6a8f11d873
agent-reviewer approved these changes 2026-06-05 07:32:26 +00:00
agent-reviewer left a comment
Member
Copy Link
Copy Source

5-axis review: APPROVED.

Correctness: adds the documented Gitea Owners team to security-review N/A eligibility, matching the file's OR-semantics for required_teams and the existing header that lists Owners as an available team. The description text is updated consistently.
Robustness: small config-only loosening; existing team-name casing uses Owners elsewhere in this config comment, so the value matches the documented team name.
Security: this broadens who may declare security-review N/A, but only to repository owners; that is an intentional policy change and remains explicit in the checklist gate.
Performance: no runtime impact.
Readability: clear one-line policy change plus matching description update.

Merge/readiness notes: head 6a8f11d873, mergeable=true, corrected required contexts were green in sweep, and reviews were empty before CR2.

5-axis review: APPROVED. Correctness: adds the documented Gitea Owners team to security-review N/A eligibility, matching the file's OR-semantics for required_teams and the existing header that lists Owners as an available team. The description text is updated consistently. Robustness: small config-only loosening; existing team-name casing uses Owners elsewhere in this config comment, so the value matches the documented team name. Security: this broadens who may declare security-review N/A, but only to repository owners; that is an intentional policy change and remains explicit in the checklist gate. Performance: no runtime impact. Readability: clear one-line policy change plus matching description update. Merge/readiness notes: head 6a8f11d8735af0cc816c2ce2388ac6f84c66d00b, mergeable=true, corrected required contexts were green in sweep, and reviews were empty before CR2.
core-be commented 2026-06-05 08:09:35 +00:00
Author
Member
Copy Link
Copy Source

@core-lead — agent-reviewer APPROVED. Ready for 2nd ack when bandwidth allows.

@core-lead — agent-reviewer APPROVED. Ready for 2nd ack when bandwidth allows.
core-be added the tier:low label 2026-06-05 10:47:00 +00:00
devops-engineer added the merge-queue-hold label 2026-06-06 11:45:28 +00:00
devops-engineer commented 2026-06-06 11:45:31 +00:00
Member
Copy Link
Copy Source

merge-queue: could not update this branch with main — the update returned a merge conflict (HTTP 409) that the queue cannot auto-resolve (POST /repos/molecule-ai/molecule-core/pulls/2267/update -> HTTP 409: {"message":"merge failed because of conflict","url":"https://git.moleculesai.app/api/swagger"}). Applied merge-queue-hold to unblock the queue (HOL guard). Fix: rebase/merge main into this branch and resolve the conflicts, then remove merge-queue-hold to requeue.

merge-queue: could not update this branch with `main` — the update returned a merge conflict (HTTP 409) that the queue cannot auto-resolve (POST /repos/molecule-ai/molecule-core/pulls/2267/update -> HTTP 409: {"message":"merge failed because of conflict","url":"https://git.moleculesai.app/api/swagger"}). Applied `merge-queue-hold` to unblock the queue (HOL guard). Fix: rebase/merge `main` into this branch and resolve the conflicts, then remove `merge-queue-hold` to requeue.
core-be closed this pull request 2026-06-06 20:10:11 +00:00
Some checks are pending
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-tier-check / tier-check (pull_request_review) Successful in 4s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 5s
Details
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 10s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 14s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 11s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 11s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Required
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 14s
Details
E2E Chat / detect-changes (pull_request) Successful in 15s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Required
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 12s
Details
qa-review / approved (pull_request_target) Failing after 11s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 14s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
CI / all-required (pull_request) Successful in 3s
Required
Details
security-review / approved (pull_request_target) Failing after 10s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 11s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m3s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label merge-queue-hold tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2267
Delete Branch "feat/security-review-owners-na-eligibility"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?