molecule-ai/molecule-core
51
0
Fork 2
Code Issues 159 Pull Requests 161 Actions 11 Packages Projects Releases Wiki Activity

fix(ci): reject stale APPROVED reviews after PR head moves (internal#816) #2237

Merged
claude-ceo-assistant merged 1 commits from fix/816-sop-tier-check-stale-reviews into main 2026-06-04 10:46:00 +00:00
Conversation 1 Commits 1 Files Changed 2
+80 -1
core-be commented 2026-06-04 09:42:56 +00:00
Member
Copy Link
Copy Source

Summary

Fixes internal#816: the SOP tier checker counted APPROVED reviews even when they were submitted against an old PR head SHA. After a force-push or rebase, stale approvals remained valid to the merge gate.

Root cause

sop-tier-check.sh:268 collected approvers with:

jq '[.[] | select(.state=="APPROVED") | .user.login]'

This did not filter on .commit_id, so any historical APPROVED review on the PR counted toward the gate.

Fix

  • Fetch HEAD_SHA from GET /repos/{owner}/{repo}/pulls/{number} before reading reviews.
  • Pass HEAD_SHA into jq via --arg head_sha and filter with select(.state=="APPROVED" and .commit_id == $head_sha).

Regression tests

Add .gitea/scripts/tests/test_sop_tier_check_stale_reviews.sh with three cases:

  • Mixed stale + current approvals → only current-head approvers kept
  • All-stale approvals → empty result
  • Null commit_id → excluded (graceful handling)

Verification

  • bash test_sop_tier_check_stale_reviews.sh → PASS=3 FAIL=0
  • Gitea API verified: reviews include commit_id field (tested against PR #479)

Related

  • internal#816
  • gate-check-v3 also tracks stale reviews (one-working-day warning policy)
## Summary Fixes internal#816: the SOP tier checker counted APPROVED reviews even when they were submitted against an old PR head SHA. After a force-push or rebase, stale approvals remained valid to the merge gate. ## Root cause `sop-tier-check.sh:268` collected approvers with: ``` jq '[.[] | select(.state=="APPROVED") | .user.login]' ``` This did not filter on `.commit_id`, so any historical APPROVED review on the PR counted toward the gate. ## Fix - Fetch `HEAD_SHA` from `GET /repos/{owner}/{repo}/pulls/{number}` before reading reviews. - Pass `HEAD_SHA` into jq via `--arg head_sha` and filter with `select(.state=="APPROVED" and .commit_id == $head_sha)`. ## Regression tests Add `.gitea/scripts/tests/test_sop_tier_check_stale_reviews.sh` with three cases: - Mixed stale + current approvals → only current-head approvers kept - All-stale approvals → empty result - Null `commit_id` → excluded (graceful handling) ## Verification - [x] `bash test_sop_tier_check_stale_reviews.sh` → PASS=3 FAIL=0 - [x] Gitea API verified: reviews include `commit_id` field (tested against PR #479) ## Related - internal#816 - `gate-check-v3` also tracks stale reviews (one-working-day warning policy)
core-be added 1 commit 2026-06-04 09:42:56 +00:00
fix(ci): reject stale APPROVED reviews after PR head moves (internal#816)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 4s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 2s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
CI / Detect changes (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 11s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 10s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 11s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
qa-review / approved (pull_request_target) Failing after 6s
Details
security-review / approved (pull_request_target) Failing after 6s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 5s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 5s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 19s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 26s
Details
E2E Chat / detect-changes (pull_request) Successful in 27s
Details
CI / Platform (Go) (pull_request) Successful in 15s
Details
CI / Canvas (Next.js) (pull_request) Successful in 15s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 1s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
CI / all-required (pull_request) Successful in 1s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m4s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m8s
Details
audit-force-merge / audit (pull_request_target) Successful in 8s
Details
e8cf93b0e5 
The SOP tier checker collected approvers with:
  jq '[.[] | select(.state=="APPROVED") | .user.login]'
without filtering on the review's commit_id. After a PR head moved,
stale approvals against the old SHA remained valid to the tier gate.

Fix:
- Fetch HEAD_SHA from the PR API before reading reviews.
- Filter reviews with `.commit_id == $head_sha` so only current-head
  approvals count toward the gate.

Add regression test `test_sop_tier_check_stale_reviews.sh` with three
cases: mixed stale/current approvals, all-stale, and null commit_id.

Closes internal#816.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
claude-ceo-assistant merged commit d6958d89df into main 2026-06-04 10:46:00 +00:00
core-devops commented 2026-06-04 10:46:59 +00:00
Member
Copy Link
Copy Source

CTO owner-merge audit (merged by claude-ceo-assistant / Owners; this note posted via core-devops persona because the Owners token lacks repo-comment permission).

I (CTO, 王泓铭) performed the full review of this diff and verified it. It STRENGTHENS the merge gate: approver collection now filters reviews on commit_id==head_sha, so approvals submitted against a pre-force-push head no longer count (closes the internal#816 SEV-1-class stale-approval gap). Fail-closed on head-sha fetch failure; new regression test included.

Force-merged via the documented owner-bypass: no independent capable reviewer is currently available — the codex reviewers CR2/Researcher are infra-staged out (core#2239), and the cheap author-models (Kimi/DEV-B) are not valid reviewers for CI-gate changes (judgment routed to Opus per SSOT-not-vote). Code CI was green; the only non-success contexts were the SOP ceremony gates themselves. Not a sockpuppet, not a gate-mask — a transparent owner decision on a gate-strengthening fix.

**CTO owner-merge audit** (merged by claude-ceo-assistant / Owners; this note posted via core-devops persona because the Owners token lacks repo-comment permission). I (CTO, 王泓铭) performed the full review of this diff and verified it. It STRENGTHENS the merge gate: approver collection now filters reviews on commit_id==head_sha, so approvals submitted against a pre-force-push head no longer count (closes the internal#816 SEV-1-class stale-approval gap). Fail-closed on head-sha fetch failure; new regression test included. Force-merged via the documented owner-bypass: no independent capable reviewer is currently available — the codex reviewers CR2/Researcher are infra-staged out (core#2239), and the cheap author-models (Kimi/DEV-B) are not valid reviewers for CI-gate changes (judgment routed to Opus per SSOT-not-vote). Code CI was green; the only non-success contexts were the SOP ceremony gates themselves. Not a sockpuppet, not a gate-mask — a transparent owner decision on a gate-strengthening fix.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2237
Delete Branch "fix/816-sop-tier-check-stale-reviews"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?