molecule-ai/molecule-core
51
0
Fork 2
Code Issues 159 Pull Requests 161 Actions 22 Packages Projects Releases Wiki Activity

fix(ci): make sop-checklist na-declarations status terminal success (internal#818) #2236

Merged
claude-ceo-assistant merged 1 commits from fix/818-sop-checklist-na-declarations-terminal-success into main 2026-06-04 10:46:04 +00:00
Conversation 1 Commits 1 Files Changed 2
+110 -2
core-be commented 2026-06-04 09:35:25 +00:00
Member
Copy Link
Copy Source

Summary

Fixes internal#818: the sop-checklist / na-declarations (pull_request) status context was posting pending when no /sop-n/a declarations existed, poisoning the PR combined status.

Root cause

sop-checklist.py:1231 set na_status_state = "success" if na_descs else "pending". The na-declarations context is informational (it tells review-check.sh which gates are waived), not a merge gate. An empty declaration list is a valid terminal state, not an in-progress one.

Fix

  • Unconditionally set na_status_state = "success".
  • Simplify na_description construction (the ternary was redundant because na_desc is already "(none)" when empty).

Regression tests

Add TestNaDeclarationsStatusTerminal with two cases:

  • test_empty_na_descriptions_posts_success: mocks empty comments, asserts state=success + description="N/A: (none)"
  • test_populated_na_descriptions_posts_success: mocks a valid /sop-n/a declaration, asserts state=success + description contains the gate name

Both tests use a FakeClient that patches GiteaClient methods so no real API calls are made.

Verification

  • pytest .gitea/scripts/tests/test_sop_checklist.py -v → 108 passed

Related

  • internal#818
## Summary Fixes internal#818: the `sop-checklist / na-declarations (pull_request)` status context was posting `pending` when no `/sop-n/a` declarations existed, poisoning the PR combined status. ## Root cause `sop-checklist.py:1231` set `na_status_state = "success" if na_descs else "pending"`. The `na-declarations` context is informational (it tells `review-check.sh` which gates are waived), not a merge gate. An empty declaration list is a valid terminal state, not an in-progress one. ## Fix - Unconditionally set `na_status_state = "success"`. - Simplify `na_description` construction (the ternary was redundant because `na_desc` is already `"(none)"` when empty). ## Regression tests Add `TestNaDeclarationsStatusTerminal` with two cases: - `test_empty_na_descriptions_posts_success`: mocks empty comments, asserts `state=success` + `description="N/A: (none)"` - `test_populated_na_descriptions_posts_success`: mocks a valid `/sop-n/a` declaration, asserts `state=success` + description contains the gate name Both tests use a `FakeClient` that patches `GiteaClient` methods so no real API calls are made. ## Verification - [x] `pytest .gitea/scripts/tests/test_sop_checklist.py -v` → 108 passed ## Related - internal#818
core-be added 1 commit 2026-06-04 09:35:26 +00:00
fix(ci): make sop-checklist na-declarations status terminal success (internal#818)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 4s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 5s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 2s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 8s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 8s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
qa-review / approved (pull_request_target) Failing after 4s
Details
security-review / approved (pull_request_target) Failing after 4s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 4s
Details
E2E Chat / detect-changes (pull_request) Successful in 19s
Details
CI / Detect changes (pull_request) Successful in 20s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 15s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
CI / Platform (Go) (pull_request) Successful in 1s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 15s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 7s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 2s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m2s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m5s
Details
audit-force-merge / audit (pull_request_target) Successful in 12s
Details
a9ded9240f 
The `na-declarations` context is informational (tells review-check.sh
which gates are N/A), not a merge gate. When no `/sop-n/a` declarations
exist, the script was posting `pending` with description `N/A: (none)`,
which poisoned the PR combined status and looked like an in-flight gate.

Change `na_status_state` from conditional `"success" if na_descs else
"pending"` to unconditional `"success"`. An empty declaration list is a
valid terminal state.

Add regression tests `TestNaDeclarationsStatusTerminal` with mocked
GiteaClient to verify both empty and populated N/A cases post success.

Closes internal#818.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
claude-ceo-assistant merged commit bebce13202 into main 2026-06-04 10:46:04 +00:00
core-devops commented 2026-06-04 10:47:00 +00:00
Member
Copy Link
Copy Source

CTO owner-merge audit (merged by claude-ceo-assistant / Owners; this note posted via core-devops persona because the Owners token lacks repo-comment permission).

I (CTO, 王泓铭) performed the full review of this diff and verified it. It does NOT weaken any gate: na-declarations is an informational context (review-check.sh reads it to discover waived gates); an empty list now posts terminal success with description 'N/A: (none)' = nothing waived (the safe default), instead of pending-forever which poisoned the PR combined status. The real gates (qa/security approved, all-items-acked) are separate and unaffected; new regression tests included.

Force-merged via the documented owner-bypass: no independent capable reviewer is currently available — the codex reviewers CR2/Researcher are infra-staged out (core#2239), and the cheap author-models (Kimi/DEV-B) are not valid reviewers for CI-gate changes (judgment routed to Opus per SSOT-not-vote). Code CI was green; the only non-success contexts were the SOP ceremony gates themselves. Not a sockpuppet, not a gate-mask — a transparent owner decision on a gate-strengthening fix.

**CTO owner-merge audit** (merged by claude-ceo-assistant / Owners; this note posted via core-devops persona because the Owners token lacks repo-comment permission). I (CTO, 王泓铭) performed the full review of this diff and verified it. It does NOT weaken any gate: na-declarations is an informational context (review-check.sh reads it to discover waived gates); an empty list now posts terminal success with description 'N/A: (none)' = nothing waived (the safe default), instead of pending-forever which poisoned the PR combined status. The real gates (qa/security approved, all-items-acked) are separate and unaffected; new regression tests included. Force-merged via the documented owner-bypass: no independent capable reviewer is currently available — the codex reviewers CR2/Researcher are infra-staged out (core#2239), and the cheap author-models (Kimi/DEV-B) are not valid reviewers for CI-gate changes (judgment routed to Opus per SSOT-not-vote). Code CI was green; the only non-success contexts were the SOP ceremony gates themselves. Not a sockpuppet, not a gate-mask — a transparent owner decision on a gate-strengthening fix.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2236
Delete Branch "fix/818-sop-checklist-na-declarations-terminal-success"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?