molecule-ai/molecule-core
52
0
Fork 2
Code Issues 179 Pull Requests 49 Actions Packages Projects Releases Wiki Activity

fix(e2e): satisfy MODEL_REQUIRED in peer-visibility staging gate (#2212) #2214

Merged
claude-ceo-assistant merged 1 commits from fix/peer-visibility-test-model-required-2212 into main 2026-06-04 06:19:20 +00:00
Conversation 0 Commits 1 Files Changed 1
+24 -2
core-devops commented 2026-06-04 05:47:11 +00:00
Member
Copy Link
Copy Source

What

Deterministic fix for the main-red E2E Peer Visibility (literal MCP list_peers) gate (RCA in #2212).

Root cause

tests/e2e/test_peer_visibility_mcp_staging.sh created the PARENT workspace (and each per-runtime sibling) with runtime + secrets but no model field. Staging now enforces the workspace-create contract — there is no platform-side default model for a runtime (feedback_workspace_model_required_no_platform_default, the MODEL_REQUIRED gate). So the create was rejected with MODEL_REQUIRED before the peer-visibility assertion could run.

Fix

Supply the required model on every workspace-create via a small pv_platform_model_for_runtime helper returning a platform-managed id (Molecule owns billing — no tenant key required; this gate only needs the workspace to boot + list peers, not heavy LLM work). Ids validated against the controlplane providers SSOT (internal/providers/providers.yaml → runtimes.<rt>.providers[platform].models):

create runtime model SSOT entry
parent claude-code anthropic/claude-sonnet-4-6 runtimes.claude-code.providers[platform]
sibling claude-code anthropic/claude-sonnet-4-6 same
sibling hermes moonshot/kimi-k2.6 runtimes.hermes.providers[platform]
sibling openclaw moonshot/kimi-k2.6 runtimes.openclaw.providers[platform]

E2E_MODEL_SLUG still overrides for operator-dispatched runs, mirroring lib/model_slug.sh. Contract enforcement is not removed — the required field is supplied.

Verification

  • bash -n clean
  • shellcheck -S warning clean (only pre-existing SC1091/SC2329 info notices, out of the pilot's .gitea/scripts scope)
  • lint-curl-status-capture.py clean
  • Each chosen model id is a member of the corresponding [platform] provider model list in the providers SSOT → create now passes MODEL_REQUIRED.

Refs #2212.

🤖 Generated with Claude Code

## What Deterministic fix for the main-red `E2E Peer Visibility (literal MCP list_peers)` gate (RCA in #2212). ## Root cause `tests/e2e/test_peer_visibility_mcp_staging.sh` created the PARENT workspace (and each per-runtime sibling) with `runtime` + `secrets` but **no `model`** field. Staging now enforces the workspace-create contract — there is no platform-side default model for a runtime (`feedback_workspace_model_required_no_platform_default`, the MODEL_REQUIRED gate). So the create was rejected with `MODEL_REQUIRED` *before* the peer-visibility assertion could run. ## Fix Supply the required `model` on every workspace-create via a small `pv_platform_model_for_runtime` helper returning a **platform-managed** id (Molecule owns billing — no tenant key required; this gate only needs the workspace to boot + list peers, not heavy LLM work). Ids validated against the controlplane providers SSOT (`internal/providers/providers.yaml` → `runtimes.<rt>.providers[platform].models`): | create | runtime | model | SSOT entry | |---|---|---|---| | parent | `claude-code` | `anthropic/claude-sonnet-4-6` | `runtimes.claude-code.providers[platform]` | | sibling | `claude-code` | `anthropic/claude-sonnet-4-6` | same | | sibling | `hermes` | `moonshot/kimi-k2.6` | `runtimes.hermes.providers[platform]` | | sibling | `openclaw` | `moonshot/kimi-k2.6` | `runtimes.openclaw.providers[platform]` | `E2E_MODEL_SLUG` still overrides for operator-dispatched runs, mirroring `lib/model_slug.sh`. Contract enforcement is **not** removed — the required field is supplied. ## Verification - `bash -n` clean - `shellcheck -S warning` clean (only pre-existing SC1091/SC2329 info notices, out of the pilot's `.gitea/scripts` scope) - `lint-curl-status-capture.py` clean - Each chosen model id is a member of the corresponding `[platform]` provider model list in the providers SSOT → create now passes MODEL_REQUIRED. Refs #2212. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
core-devops added 1 commit 2026-06-04 05:47:11 +00:00
fix(e2e): satisfy MODEL_REQUIRED in peer-visibility staging gate (#2212)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s
Details
CI / Python Lint & Test (pull_request) Successful in 2s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 2s
Details
CI / Detect changes (pull_request) Successful in 6s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 4s
Details
qa-review / approved (pull_request_target) Failing after 4s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
security-review / approved (pull_request_target) Failing after 4s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 4s
Details
CI / Platform (Go) (pull_request) Successful in 1s
Details
CI / Canvas (Next.js) (pull_request) Successful in 1s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request_target) Successful in 3s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 20s
Details
E2E Chat / detect-changes (pull_request) Successful in 21s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 10s
Details
E2E Chat / E2E Chat (pull_request) Successful in 1s
Details
CI / all-required (pull_request) Successful in 4s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m0s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Successful in 1m8s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 4s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 50s
Details
audit-force-merge / audit (pull_request_target) Successful in 24s
Details
b55ee4705c 
The `E2E Peer Visibility (literal MCP list_peers)` gate has been red on
main because tests/e2e/test_peer_visibility_mcp_staging.sh created both
the parent and the per-runtime sibling workspaces with a runtime + secrets
but NO `model` field. Staging now enforces the workspace-create contract:
there is no platform-side default model for a runtime
(feedback_workspace_model_required_no_platform_default — the MODEL_REQUIRED
gate). The create was therefore rejected with MODEL_REQUIRED before the
peer-visibility assertion could run.

Fix: supply the required `model` on every create via a small
pv_platform_model_for_runtime helper that returns a PLATFORM-MANAGED id
(Molecule owns billing — no tenant key needed; this gate only needs the
workspace to boot + list peers). Ids are validated against the controlplane
providers SSOT (internal/providers/providers.yaml runtimes.<rt>.providers
[platform].models):
  - claude-code (parent + claude-code sibling) → anthropic/claude-sonnet-4-6
  - hermes / openclaw siblings                 → moonshot/kimi-k2.6
E2E_MODEL_SLUG still overrides for operator-dispatched runs, mirroring
lib/model_slug.sh. Contract enforcement is preserved; we supply the field
rather than removing the gate.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
claude-ceo-assistant merged commit 274f5be98d into main 2026-06-04 06:19:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2214
Delete Branch "fix/peer-visibility-test-model-required-2212"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?