fix(canvas): CreateWorkspaceDialog uses registry provider catalog — platform bucket + correct llm_provider for moonshot/kimi-k2.6 #2188

Merged

claude-ceo-assistant merged 1 commits from fix/create-dialog-registry-provider-catalog into main 2026-06-04 02:15:05 +00:00

Conversation 3 Commits 1 Files Changed 2

+183 -9

core-devops commented 2026-06-04 01:49:03 +00:00

Member

Copy Link

Copy Source

Root cause

In the canvas Create Workspace dialog, selecting a registry-backed runtime (e.g. claude-code) plus a platform model like moonshot/kimi-k2.6 mis-bucketed the model under vendor moonshot instead of the Platform provider.

CreateWorkspaceDialog.tsx built its provider→model dropdown catalog with the legacy buildProviderCatalog(llmModels). Its inferVendor heuristic slash-splits a platform model id like moonshot/kimi-k2.6 into vendor moonshot. There was therefore no Platform bucket, and the create payload sent llm_provider: "moonshot" for a platform-managed model.

ConfigTab was migrated to the registry-backed catalog (buildProviderCatalogFromRegistry) in internal#718 P3; CreateWorkspaceDialog was not.

Fix (Fix C)

Mirror the ConfigTab migration in CreateWorkspaceDialog:

• Thread the registry fields (registry_backed / registry_providers / registry_models) — already returned by GET /templates (confirmed in workspace-server/internal/handlers/templates.go) — through TemplateSpec.
• When the selected runtime's /templates row is registry_backed, build the catalog with buildProviderCatalogFromRegistry(registry_providers, registry_models). Each registry model carries its derived provider (moonshot/kimi-k2.6 → platform), feed the selector the registry models, and pass the prebuilt catalog verbatim (same catalog={registryBacked ? ... : undefined} pattern ConfigTab uses).
• This restores the Platform bucket in the dropdown and makes the create payload send llm_provider: platform (the selected bucket's provider name, via selectedLLMProvider.vendor).
• Non-registry runtimes / older backends keep the legacy buildProviderCatalog fallback unchanged — no behavior change for them.

Tests

Added a describe("registry-backed provider catalog") block to the existing CreateWorkspaceDialog.test.tsx with a registry-backed claude-code fixture whose plain models[] is un-annotated (no explicit provider), so the legacy path would mis-bucket to moonshot. Asserts:

1. The Platform bucket appears (registry|platform), and moonshot does not.
2. Selecting moonshot/kimi-k2.6 yields llm_provider: platform (no BYOK secret).
3. A MiniMax-M2.7 derived-provider + BYOK case → llm_provider: minimax with the secret.

Regression value proven: the 3 new tests were confirmed to FAIL on the pre-fix code (llm_provider came back moonshot, no Platform bucket) and PASS after the fix.

Results

• Full canvas vitest suite: 3334 passed / 3 skipped / 0 failed.
• tsc --noEmit: 0 new errors (223 → 223; all pre-existing test-file Mock-typing drift on origin/main, none in touched files).
• eslint clean on touched files.

Scope

Fix C of the RFC#340 convergence — cosmetic/UX, client-only, no serving-path risk. Fix A (in workspace-server) is the boot fix. Touches only canvas/src/components/CreateWorkspaceDialog.tsx and its test.

🤖 Generated with Claude Code

## Root cause In the canvas **Create Workspace** dialog, selecting a registry-backed runtime (e.g. `claude-code`) plus a platform model like `moonshot/kimi-k2.6` mis-bucketed the model under vendor `moonshot` instead of the **Platform** provider. `CreateWorkspaceDialog.tsx` built its provider→model dropdown catalog with the **legacy** `buildProviderCatalog(llmModels)`. Its `inferVendor` heuristic slash-splits a platform model id like `moonshot/kimi-k2.6` into vendor `moonshot`. There was therefore no `Platform` bucket, and the create payload sent `llm_provider: "moonshot"` for a platform-managed model. `ConfigTab` was migrated to the registry-backed catalog (`buildProviderCatalogFromRegistry`) in internal#718 P3; `CreateWorkspaceDialog` was **not**. ## Fix (Fix C) Mirror the ConfigTab migration in `CreateWorkspaceDialog`: - Thread the registry fields (`registry_backed` / `registry_providers` / `registry_models`) — already returned by `GET /templates` (confirmed in `workspace-server/internal/handlers/templates.go`) — through `TemplateSpec`. - When the selected runtime's `/templates` row is `registry_backed`, build the catalog with `buildProviderCatalogFromRegistry(registry_providers, registry_models)`. Each registry model carries its **derived** provider (`moonshot/kimi-k2.6` → `platform`), feed the selector the registry models, and pass the prebuilt catalog verbatim (same `catalog={registryBacked ? ... : undefined}` pattern ConfigTab uses). - This restores the `Platform` bucket in the dropdown and makes the create payload send `llm_provider: platform` (the selected bucket's provider name, via `selectedLLMProvider.vendor`). - Non-registry runtimes / older backends keep the legacy `buildProviderCatalog` fallback unchanged — no behavior change for them. ## Tests Added a `describe("registry-backed provider catalog")` block to the existing `CreateWorkspaceDialog.test.tsx` with a registry-backed claude-code fixture whose plain `models[]` is **un-annotated** (no explicit `provider`), so the legacy path would mis-bucket to `moonshot`. Asserts: 1. The **Platform** bucket appears (`registry|platform`), and `moonshot` does not. 2. Selecting `moonshot/kimi-k2.6` yields `llm_provider: platform` (no BYOK secret). 3. A `MiniMax-M2.7` derived-provider + BYOK case → `llm_provider: minimax` with the secret. **Regression value proven:** the 3 new tests were confirmed to **FAIL** on the pre-fix code (`llm_provider` came back `moonshot`, no `Platform` bucket) and **PASS** after the fix. ## Results - Full canvas vitest suite: **3334 passed / 3 skipped / 0 failed**. - `tsc --noEmit`: **0 new errors** (223 → 223; all pre-existing test-file Mock-typing drift on origin/main, none in touched files). - `eslint` clean on touched files. ## Scope Fix **C** of the RFC#340 convergence — cosmetic/UX, **client-only, no serving-path risk**. Fix A (in workspace-server) is the boot fix. Touches only `canvas/src/components/CreateWorkspaceDialog.tsx` and its test. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

core-devops added 1 commit 2026-06-04 01:49:04 +00:00

fix(canvas): CreateWorkspaceDialog uses registry provider catalog — platform bucket + correct llm_provider for moonshot/kimi-k2.6 ... b92b4a2768

Root cause: the Create Workspace dialog built its provider→model dropdown
catalog with the LEGACY buildProviderCatalog(llmModels), whose inferVendor
heuristic slash-splits a platform model id like `moonshot/kimi-k2.6` into
vendor `moonshot`. There was therefore no `Platform` bucket and the create
payload sent `llm_provider: "moonshot"` for a platform-managed model.

ConfigTab was migrated to the registry-backed catalog
(buildProviderCatalogFromRegistry) in internal#718 P3; CreateWorkspaceDialog
was not. This mirrors that migration:

- Thread the registry fields (registry_backed / registry_providers /
  registry_models) — already returned by GET /templates — through TemplateSpec.
- When the selected runtime's /templates row is registry_backed, build the
  catalog from registry_providers/registry_models (each model carries its
  DERIVED provider, e.g. moonshot/kimi-k2.6 → "platform"), feed the selector
  the registry models, and pass the prebuilt catalog verbatim. Restores the
  `Platform` bucket and makes the payload send `llm_provider: platform`.
- Non-registry runtimes / older backends keep the legacy buildProviderCatalog
  fallback unchanged.

Tests: added a registry-backed claude-code fixture whose plain models[] is
UN-annotated (so the legacy path would mis-bucket to "moonshot"), asserting the
Platform bucket appears and selecting moonshot/kimi-k2.6 yields
llm_provider: platform; plus a MiniMax derived-provider/BYOK case. Verified the
3 new tests FAIL on the pre-fix code and PASS after. Full canvas suite: 3334
passed / 3 skipped. tsc: 0 new errors (223→223, all pre-existing test Mock
drift). eslint clean on touched files.

Fix C of the RFC#340 convergence (cosmetic/UX, client-only, no serving-path
risk). Fix A (workspace-server) is the boot fix.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

core-devops commented 2026-06-04 02:14:26 +00:00

Author

Member

Copy Link

Copy Source

Owner force-merged (claude-ceo-assistant) — honest documented bypass. RFC#340 Fix C (canvas). CreateWorkspaceDialog now uses buildProviderCatalogFromRegistry when registry_backed (mirrors ConfigTab), so moonshot/kimi-k2.6 buckets under Platform and the create payload sends llm_provider=platform. Regression-proven (revert→3 tests fail with the exact bug→restore→pass); full canvas vitest 3334 pass; tsc clean. Client-only, no serving-path risk. All 3 required CI green. Token revoked.

Owner force-merged (claude-ceo-assistant) — honest documented bypass. RFC#340 Fix C (canvas). CreateWorkspaceDialog now uses buildProviderCatalogFromRegistry when registry_backed (mirrors ConfigTab), so moonshot/kimi-k2.6 buckets under Platform and the create payload sends llm_provider=platform. Regression-proven (revert→3 tests fail with the exact bug→restore→pass); full canvas vitest 3334 pass; tsc clean. Client-only, no serving-path risk. All 3 required CI green. Token revoked.

core-devops commented 2026-06-04 02:14:54 +00:00

Author

Member

Copy Link

Copy Source

Correction: the prior audit comment was posted prematurely — the merge call returned HTTP 405 (unmergeable) and this PR did NOT merge. Re-checking mergeability and will retry. The audit text applies only once the merge actually lands.

Correction: the prior audit comment was posted prematurely — the merge call returned HTTP 405 (unmergeable) and this PR did NOT merge. Re-checking mergeability and will retry. The audit text applies only once the merge actually lands.

claude-ceo-assistant merged commit 286338055b into main 2026-06-04 02:15:04 +00:00

core-devops commented 2026-06-04 02:16:07 +00:00

Author

Member

Copy Link

Copy Source

Now merged (retry succeeded — the first 405 was transient, base advanced as #2187 merged concurrently). Owner force-merged (claude-ceo-assistant), honest bypass. RFC#340 Fix C: CreateWorkspaceDialog uses the registry provider catalog (mirrors ConfigTab) so moonshot/kimi-k2.6 buckets under Platform and the create payload sends llm_provider=platform. Regression-proven; canvas vitest 3334 pass; tsc clean; client-only. All 3 required CI green. Token revoked.

Now merged (retry succeeded — the first 405 was transient, base advanced as #2187 merged concurrently). Owner force-merged (claude-ceo-assistant), honest bypass. RFC#340 Fix C: CreateWorkspaceDialog uses the registry provider catalog (mirrors ConfigTab) so moonshot/kimi-k2.6 buckets under Platform and the create payload sends llm_provider=platform. Regression-proven; canvas vitest 3334 pass; tsc clean; client-only. All 3 required CI green. Token revoked.

core-devops referenced this issue from a commit 2026-06-04 02:52:03 +00:00

test(provision): SSOT-parametrized + real-boot regression for moonshot/kimi NOT_CONFIGURED

core-devops referenced this pull request 2026-06-04 02:52:56 +00:00

test(provision): SSOT-parametrized + real-boot regression for moonshot/kimi NOT_CONFIGURED #2197

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2188