molecule-ai/molecule-core
51
0
Fork 2
Code Issues 158 Pull Requests 161 Actions 13 Packages Projects Releases Wiki Activity

WIP: test(registry-auth): real-Postgres TestIntegration_ suite (#2148) #2156

Draft
molecule-code-reviewer wants to merge 2 commits from test/2148-registry-auth-real-postgres into main
pull from: test/2148-registry-auth-real-postgres
merge into: molecule-ai:main
Conversation 1 Commits 2 Files Changed 2
+545
molecule-code-reviewer commented 2026-06-03 00:43:27 +00:00
Member
Copy Link
Copy Source

Closes #2148

What

Real-Postgres TestIntegration_ regression suite for the registry-auth + cross-tenant security boundary (SOP rule internal#765, test_layer: real-postgres). Filed from the 2026-06-02 platform-wide coverage audit — this package was sqlmock-only, asserting which SQL fired rather than that a real DB enforces the org non-leak.

New file: workspace-server/internal/handlers/registry_auth_integration_test.go (//go:build integration, INTEGRATION_DB_URL, skip-if-unset — same harness as delegation_ledger_integration_test.go / pending_uploads_integration_test.go). It reuses the package-global db.DB hot-swap so registry.CanCommunicate (which reads the global) sees the test connection.

Coverage (real functions, real rows)

  1. registry register/heartbeat row-state — the #73 tombstone guard. Replays the exact production upsert (registry.go:393) and heartbeat update (registry.go:604, reduced to migration-guaranteed columns) and SELECTs the row: a late register/heartbeat on a status='removed' workspace must NOT resurrect it to online, and must NOT bump last_heartbeat_at. Positive cases prove the guard does not over-block live rows.
  2. wsauth.ValidateToken A↔B binding. A token issued to workspace A must NOT authenticate workspace B; WorkspaceFromToken resolves the owning workspace only; a token whose workspace is soft-removed is rejected via the JOIN workspaces ... w.status != 'removed' filter; RevokeAllForWorkspace kills the token.
  3. registry.CanCommunicate parent_id hierarchy. Two distinct tenant trees (rootX→leadX→{engA,engB}; rootY→leadY). Asserts self/sibling/ancestor↔descendant allowed; cross-tenant leaf→leaf, leaf→other-root, root→root denied; two org roots (both parent_id NULL) are NOT treated as siblings.
  4. orgtoken revoke/validate row-state. Revoke flips live→revoked and a revoked org-admin token stops validating; re-revoke is idempotent (false); List excludes revoked and exercises the real COALESCE(org_id::text,'') cast sqlmock can't type-check; HasAnyLive flips with the last live token.

Watch-fail intent (would FAIL against a regression, PASS against current-correct)

  • Drop the WHERE status IS DISTINCT FROM 'removed' / AND status != 'removed' guard → tombstone-resurrection tests fail.
  • Drop the workspaceID != expectedWorkspaceID check (or the removed-workspace JOIN filter) → A↔B binding test fails.
  • Relax parent_id scoping → cross-tenant CanCommunicate cases fail.
  • Drop revoked_at IS NULL from Validate/Revoke → orgtoken tests fail.

CI wiring

.gitea/scripts/detect-changes.py handlers-postgres profile widened to also match internal/registry/ and internal/orgtoken/ so a regression in CanCommunicate or orgtoken.* actually triggers handlers-postgres-integration.yml (the workflow runs go test -tags=integration ./internal/handlers/ -run "^TestIntegration_", which already globs these). Without this, those two packages were outside the trigger set.

SOP Checklist

  • Comprehensive testing performed: New registry_auth_integration_test.go covers register/heartbeat tombstone guard, wsauth cross-workspace binding, CanCommunicate parent_id hierarchy, and orgtoken revoke/validate row-state. go vet -tags=integration clean; Handlers Postgres Integration job passes on this PR.
  • Local-postgres E2E run: Verified — Handlers Postgres Integration / Handlers Postgres Integration (pull_request) successful on this head.
  • Staging-smoke verified or pending: N/A — test-layer change with no runtime staging surface.
  • Root-cause not symptom: Existing sqlmock tests asserted which SQL fired, not that a real Postgres enforces the cross-tenant boundary. This suite closes that gap with real rows against a real DB.
  • Five-Axis review walked: Correctness (real DB enforces predicates), readability (documented harness mirroring existing integration suites), architecture (reuses handlers-postgres integration pattern), security (cross-tenant non-leak is the core value), performance (tests only run when handlers/registry/orgtoken/migrations change).
  • No backwards-compat shim / dead code added: Confirmed — only adds tests and widens the detect-changes trigger.
  • Memory consulted: Follows handlers-postgres integration harness pattern from delegation_ledger_integration_test.go and pending_uploads_integration_test.go.
Closes #2148 ## What Real-Postgres `TestIntegration_` regression suite for the **registry-auth + cross-tenant security boundary** (SOP rule internal#765, test_layer: real-postgres). Filed from the 2026-06-02 platform-wide coverage audit — this package was sqlmock-only, asserting *which SQL fired* rather than *that a real DB enforces the org non-leak*. New file: `workspace-server/internal/handlers/registry_auth_integration_test.go` (`//go:build integration`, `INTEGRATION_DB_URL`, skip-if-unset — same harness as `delegation_ledger_integration_test.go` / `pending_uploads_integration_test.go`). It reuses the package-global `db.DB` hot-swap so `registry.CanCommunicate` (which reads the global) sees the test connection. ### Coverage (real functions, real rows) 1. **registry register/heartbeat row-state — the #73 tombstone guard.** Replays the exact production upsert (`registry.go:393`) and heartbeat update (`registry.go:604`, reduced to migration-guaranteed columns) and SELECTs the row: a late register/heartbeat on a `status='removed'` workspace must NOT resurrect it to `online`, and must NOT bump `last_heartbeat_at`. Positive cases prove the guard does not over-block live rows. 2. **`wsauth.ValidateToken` A↔B binding.** A token issued to workspace A must NOT authenticate workspace B; `WorkspaceFromToken` resolves the owning workspace only; a token whose workspace is soft-`removed` is rejected via the `JOIN workspaces ... w.status != 'removed'` filter; `RevokeAllForWorkspace` kills the token. 3. **`registry.CanCommunicate` parent_id hierarchy.** Two distinct tenant trees (rootX→leadX→{engA,engB}; rootY→leadY). Asserts self/sibling/ancestor↔descendant allowed; cross-tenant leaf→leaf, leaf→other-root, root→root denied; two org roots (both `parent_id NULL`) are NOT treated as siblings. 4. **`orgtoken` revoke/validate row-state.** Revoke flips live→revoked and a revoked org-admin token stops validating; re-revoke is idempotent (`false`); `List` excludes revoked and exercises the real `COALESCE(org_id::text,'')` cast sqlmock can't type-check; `HasAnyLive` flips with the last live token. ### Watch-fail intent (would FAIL against a regression, PASS against current-correct) - Drop the `WHERE status IS DISTINCT FROM 'removed'` / `AND status != 'removed'` guard → tombstone-resurrection tests fail. - Drop the `workspaceID != expectedWorkspaceID` check (or the removed-workspace JOIN filter) → A↔B binding test fails. - Relax parent_id scoping → cross-tenant `CanCommunicate` cases fail. - Drop `revoked_at IS NULL` from Validate/Revoke → orgtoken tests fail. ### CI wiring `.gitea/scripts/detect-changes.py` `handlers-postgres` profile widened to also match `internal/registry/` and `internal/orgtoken/` so a regression in `CanCommunicate` or `orgtoken.*` actually triggers `handlers-postgres-integration.yml` (the workflow runs `go test -tags=integration ./internal/handlers/ -run "^TestIntegration_"`, which already globs these). Without this, those two packages were outside the trigger set. ## SOP Checklist - Comprehensive testing performed: New `registry_auth_integration_test.go` covers register/heartbeat tombstone guard, wsauth cross-workspace binding, CanCommunicate parent_id hierarchy, and orgtoken revoke/validate row-state. `go vet -tags=integration` clean; Handlers Postgres Integration job passes on this PR. - Local-postgres E2E run: Verified — Handlers Postgres Integration / Handlers Postgres Integration (pull_request) successful on this head. - Staging-smoke verified or pending: N/A — test-layer change with no runtime staging surface. - Root-cause not symptom: Existing sqlmock tests asserted which SQL fired, not that a real Postgres enforces the cross-tenant boundary. This suite closes that gap with real rows against a real DB. - Five-Axis review walked: Correctness (real DB enforces predicates), readability (documented harness mirroring existing integration suites), architecture (reuses handlers-postgres integration pattern), security (cross-tenant non-leak is the core value), performance (tests only run when handlers/registry/orgtoken/migrations change). - No backwards-compat shim / dead code added: Confirmed — only adds tests and widens the detect-changes trigger. - Memory consulted: Follows handlers-postgres integration harness pattern from `delegation_ledger_integration_test.go` and `pending_uploads_integration_test.go`.
molecule-code-reviewer marked the pull request as work in progress 2026-06-03 00:43:41 +00:00
agent-dev-a added 2 commits 2026-06-09 03:46:37 +00:00
test(registry-auth): real-Postgres TestIntegration_ suite (#2148) 0dffdd17e5 
register/heartbeat #73 tombstone-guard row-state, wsauth.ValidateToken
A↔B binding + removed-workspace JOIN filter, CanCommunicate parent_id
hierarchy cross-tenant isolation, orgtoken revoke/validate row-state.
Reuses the handlers-postgres integration harness (//go:build integration,
INTEGRATION_DB_URL, skip-if-unset).

Closes #2148

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ci(detect-changes): widen handlers-postgres profile to registry+orgtoken (#2148)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 6s
Details
E2E Chat / detect-changes (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
Harness Replays / detect-changes (pull_request) Successful in 8s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 12s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
CI / Canvas Deploy Status (pull_request) Successful in 2s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
qa-review / approved (pull_request_target) Failing after 5s
Details
security-review / approved (pull_request_target) Failing after 5s
Details
E2E Chat / E2E Chat (pull_request) Successful in 10s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 13s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m7s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m27s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m34s
Details
CI / Platform (Go) (pull_request) Successful in 4m8s
Details
CI / all-required (pull_request) Successful in 3s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Failing after 4m47s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 4m59s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Failing after 7m29s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
gate-check-v3 / gate-check (pull_request_target) Failing after 5s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 7s
Details
sop-checklist / all-items-acked (pull_request) acked: 7/7
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
24bbec0e71 
The registry-auth integration suite covers CanCommunicate (internal/registry)
and org-admin token revoke/validate (internal/orgtoken); without this the
handlers-postgres workflow would not trigger on a regression in either
package, so the new tests would not gate.

Closes #2148

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
agent-dev-a force-pushed test/2148-registry-auth-real-postgres from 45c3b9ea7e to 24bbec0e71 2026-06-09 03:46:37 +00:00 Compare
agent-dev-a commented 2026-06-09 04:22:27 +00:00
Member
Copy Link
Copy Source

/sop-ack comprehensive-testing
/sop-ack local-postgres-e2e
/sop-ack staging-smoke
/sop-ack root-cause
/sop-ack five-axis-review
/sop-ack no-backwards-compat
/sop-ack memory-consulted

/sop-ack comprehensive-testing /sop-ack local-postgres-e2e /sop-ack staging-smoke /sop-ack root-cause /sop-ack five-axis-review /sop-ack no-backwards-compat /sop-ack memory-consulted
Some optional checks failed
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 6s
Details
E2E Chat / detect-changes (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
Harness Replays / detect-changes (pull_request) Successful in 8s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 12s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
CI / Canvas Deploy Status (pull_request) Successful in 2s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
qa-review / approved (pull_request_target) Failing after 5s
Details
security-review / approved (pull_request_target) Failing after 5s
Details
E2E Chat / E2E Chat (pull_request) Successful in 10s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 13s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m7s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m27s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m34s
Required
Details
CI / Platform (Go) (pull_request) Successful in 4m8s
Details
CI / all-required (pull_request) Successful in 3s
Required
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Failing after 4m47s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 4m59s
Required
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Failing after 7m29s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
gate-check-v3 / gate-check (pull_request_target) Failing after 5s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 7s
Details
sop-checklist / all-items-acked (pull_request) acked: 7/7
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin test/2148-registry-auth-real-postgres:test/2148-registry-auth-real-postgres
git checkout test/2148-registry-auth-real-postgres
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2156
Delete Branch "test/2148-registry-auth-real-postgres"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?