molecule-ai/molecule-core
52
0
Fork 2
Code Issues 182 Pull Requests 52 Actions 1 Packages Projects Releases Wiki Activity

ci: un-mask required real-infra gates (mc#1982) — continue-on-error:false #2152

Closed
molecule-code-reviewer wants to merge 2 commits from ci/unmask-required-real-infra-gates-mc1982 into main
pull from: ci/unmask-required-real-infra-gates-mc1982
merge into: molecule-ai:main
Conversation 1 Commits 2 Files Changed 2
+30 -14
molecule-code-reviewer commented 2026-06-03 00:32:38 +00:00
Member
Copy Link
Copy Source

What

Flip continue-on-error: true -> false on both jobs (detect-changes + the integration/e2e job) in:

  • .gitea/workflows/handlers-postgres-integration.yml
  • .gitea/workflows/e2e-api.yml

Why (mc#1982)

These two real-infra contexts (Handlers Postgres Integration, E2E API Smoke Test) are already listed as required on branch protection. But continue-on-error: true made each job report success even when its steps failed — so the required gate could never actually block a bad merge. It was a green-on-red mask.

Flipping to false un-masks them: a failing run now reports failure and the required check does its job.

Expect red — that is the point

This PR's own CI will run both workflows. If the underlying real-infra tests are currently broken, this PR will go red, and that red is the signal we want — it surfaces the real failures the mask was hiding.

Merge requirement: do NOT merge until the underlying tests are green on this branch. If CI is red here, fix the underlying handlers-postgres / e2e-api failures first (separate change), then this un-mask lands clean.

Not a draft on purpose — we want the CI to run.

mc#1982 Phase 3 follow-through (root-fix + remove the mask, do not renew it silently).

## What Flip `continue-on-error: true` -> `false` on **both** jobs (`detect-changes` + the integration/e2e job) in: - `.gitea/workflows/handlers-postgres-integration.yml` - `.gitea/workflows/e2e-api.yml` ## Why (mc#1982) These two real-infra contexts (`Handlers Postgres Integration`, `E2E API Smoke Test`) are **already listed as required** on branch protection. But `continue-on-error: true` made each job report **success even when its steps failed** — so the required gate could never actually block a bad merge. It was a green-on-red mask. Flipping to `false` un-masks them: a failing run now reports failure and the required check does its job. ## Expect red — that is the point This PR's **own CI** will run both workflows. If the underlying real-infra tests are currently broken, **this PR will go red**, and that red is the signal we want — it surfaces the real failures the mask was hiding. **Merge requirement:** do NOT merge until the underlying tests are green on this branch. If CI is red here, fix the underlying handlers-postgres / e2e-api failures first (separate change), then this un-mask lands clean. Not a draft on purpose — we want the CI to run. mc#1982 Phase 3 follow-through (root-fix + remove the mask, do not renew it silently).
molecule-code-reviewer added 2 commits 2026-06-03 00:32:38 +00:00
ci: un-mask handlers-postgres-integration required gate (mc#1982) 84fb632a2a 
Flip continue-on-error true->false on both jobs so this already-required
real-infra context can actually block instead of posting a green status
on a red run.
ci: un-mask e2e-api required gate (mc#1982)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 8s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Failing after 1s
Details
E2E Chat / detect-changes (pull_request) Successful in 11s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 9s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 3s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 3s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
CI / Python Lint & Test (pull_request) Successful in 27s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 34s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 20s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 29s
Details
qa-review / approved (pull_request_target) Failing after 13s
Details
security-review / approved (pull_request_target) Failing after 13s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 18s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 52s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 58s
Details
CI / Canvas (Next.js) (pull_request) Successful in 1s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
CI / Platform (Go) (pull_request) Successful in 5s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-tier-check / tier-check (pull_request_target) Successful in 10s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 11s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Failing after 1m5s
Details
CI / all-required (pull_request) Successful in 9s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7s
Details
E2E Chat / E2E Chat (pull_request) Successful in 7s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m18s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m11s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m2s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m31s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
3b817346e1 
Flip continue-on-error true->false on both jobs so this already-required
real-infra context can actually block instead of posting a green status
on a red run.
molecule-code-reviewer commented 2026-06-03 03:20:54 +00:00
Author
Member
Copy Link
Copy Source

MECHANISM: PR #2165 demonstrates a gate-honesty edge in the continue-on-error burn-down path: CI / all-required (pull_request) can be green while the continue-on-error meta-lints are red, because the main sentinel in .gitea/workflows/ci.yml:528-534 aggregates only changes, platform-build, canvas-build, shellcheck, and python-lint. The two CoE workflows are separate BP-exempt meta-lints: .gitea/workflows/lint-continue-on-error-tracking.yml:91-102 and .gitea/workflows/lint-pre-flip-continue-on-error.yml:95-103 both still declare continue-on-error: true as Phase 3 surface-only gates.

EVIDENCE: Direct status read for #2165 head f2c56b38 showed CI / all-required (pull_request) success while lint-continue-on-error-tracking failed and Lint pre-flip continue-on-error failed. The logs reported continue-on-error: true ... mc#1982 ... and 2/4 flip(s) failed pre-flip verification. This is expected interim-red for #2165, but it means a PM/CTO digest must not treat CI / all-required green as sufficient during the CoE burn-down window.

RECOMMENDED FIX SHAPE: Keep #2165 sequencing explicit: either leave the CoE meta-lints BP-exempt until their Phase-4 flip is deliberately approved, or add a separate required aggregate/status for CoE burn-down readiness. The responsible surfaces are molecule-core/.gitea/workflows/lint-continue-on-error-tracking.yml, lint-pre-flip-continue-on-error.yml, and the branch-protection/digest contract, not application code. The invariant should be: any PR that changes CoE masks is not READY-TO-MERGE unless the CoE meta-lints are green or the CTO has explicitly accepted the Phase-3 exception.

MECHANISM: PR #2165 demonstrates a gate-honesty edge in the continue-on-error burn-down path: `CI / all-required (pull_request)` can be green while the continue-on-error meta-lints are red, because the main sentinel in `.gitea/workflows/ci.yml:528-534` aggregates only `changes`, `platform-build`, `canvas-build`, `shellcheck`, and `python-lint`. The two CoE workflows are separate BP-exempt meta-lints: `.gitea/workflows/lint-continue-on-error-tracking.yml:91-102` and `.gitea/workflows/lint-pre-flip-continue-on-error.yml:95-103` both still declare `continue-on-error: true` as Phase 3 surface-only gates. EVIDENCE: Direct status read for #2165 head `f2c56b38` showed `CI / all-required (pull_request)` success while `lint-continue-on-error-tracking` failed and `Lint pre-flip continue-on-error` failed. The logs reported `continue-on-error: true ... mc#1982 ...` and `2/4 flip(s) failed pre-flip verification`. This is expected interim-red for #2165, but it means a PM/CTO digest must not treat `CI / all-required` green as sufficient during the CoE burn-down window. RECOMMENDED FIX SHAPE: Keep #2165 sequencing explicit: either leave the CoE meta-lints BP-exempt until their Phase-4 flip is deliberately approved, or add a separate required aggregate/status for CoE burn-down readiness. The responsible surfaces are `molecule-core/.gitea/workflows/lint-continue-on-error-tracking.yml`, `lint-pre-flip-continue-on-error.yml`, and the branch-protection/digest contract, not application code. The invariant should be: any PR that changes CoE masks is not READY-TO-MERGE unless the CoE meta-lints are green or the CTO has explicitly accepted the Phase-3 exception.
core-be closed this pull request 2026-06-03 04:47:02 +00:00
Some checks are pending
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 8s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Failing after 1s
Details
E2E Chat / detect-changes (pull_request) Successful in 11s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 9s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 3s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 3s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
CI / Python Lint & Test (pull_request) Successful in 27s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 34s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 20s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 29s
Details
qa-review / approved (pull_request_target) Failing after 13s
Details
security-review / approved (pull_request_target) Failing after 13s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 18s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 52s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 58s
Details
CI / Canvas (Next.js) (pull_request) Successful in 1s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
CI / Platform (Go) (pull_request) Successful in 5s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-tier-check / tier-check (pull_request_target) Successful in 10s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 11s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Failing after 1m5s
Details
CI / all-required (pull_request) Successful in 9s
Required
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7s
Details
E2E Chat / E2E Chat (pull_request) Successful in 7s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m18s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m11s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m2s
Required
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m31s
Required
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2152
Delete Branch "ci/unmask-required-real-infra-gates-mc1982"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?