molecule-ai/molecule-core
53
0
Fork 2
Code Issues 194 Pull Requests 49 Actions Packages Projects Releases Wiki Activity

fix(workspace): make Pause/Resume cascade opt-in via ?cascade=true (#1991) #2120

Closed
core-be wants to merge 1 commits from fix/pause-resume-cascade-opt-in-1991 into main
pull from: fix/pause-resume-cascade-opt-in-1991
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 3
+214 -1
core-be commented 2026-06-02 01:47:10 +00:00
Member
Copy Link
Copy Source

Fixes #1991.

Problem

POST /workspaces/:id/pause and /resume currently implicitly cascade to all descendants. This caused incident internal#722 where a single Pause call terminated 5 EC2-backed workspaces (parent + 4 children).

Fix

  • Default behavior: single-workspace scope only.
  • If descendants exist and ?cascade=true is not set, return 409 Conflict with a descendants list so the caller can decide.
  • ?cascade=true preserves the old recursive behavior.

Changes

  • Pause: checks c.Query("cascade") before stopping descendants
  • Resume: mirrors Pause cascade contract
  • Updated TestPause_WithDescendants to use ?cascade=true
  • Added 4 new tests covering 409 + 200 paths for both handlers

Acceptance criteria verified

  • Pause without cascade=true on a parent workspace returns 409 + descendants list
  • Pause?cascade=true behaves as today (returns 200 with paused_count=N)
  • Resume mirrors Pause contract
  • Test: parent-with-2-children setup; Pause(parent) without cascade returns 409; Pause(parent)?cascade=true returns 200 with paused_count=3

Test plan

cd workspace-server && go test ./internal/handlers/ -run "TestPauseHandler_|TestResumeHandler_|TestPause_WithDescendants|TestResume_" -v

All 16 tests pass.

Fixes #1991. ## Problem POST /workspaces/:id/pause and /resume currently implicitly cascade to all descendants. This caused incident internal#722 where a single Pause call terminated 5 EC2-backed workspaces (parent + 4 children). ## Fix - Default behavior: single-workspace scope only. - If descendants exist and ?cascade=true is not set, return 409 Conflict with a descendants list so the caller can decide. - ?cascade=true preserves the old recursive behavior. ## Changes - Pause: checks c.Query("cascade") before stopping descendants - Resume: mirrors Pause cascade contract - Updated TestPause_WithDescendants to use ?cascade=true - Added 4 new tests covering 409 + 200 paths for both handlers ## Acceptance criteria verified - [x] Pause without cascade=true on a parent workspace returns 409 + descendants list - [x] Pause?cascade=true behaves as today (returns 200 with paused_count=N) - [x] Resume mirrors Pause contract - [x] Test: parent-with-2-children setup; Pause(parent) without cascade returns 409; Pause(parent)?cascade=true returns 200 with paused_count=3 ## Test plan ``` cd workspace-server && go test ./internal/handlers/ -run "TestPauseHandler_|TestResumeHandler_|TestPause_WithDescendants|TestResume_" -v ``` All 16 tests pass.
core-be added 1 commit 2026-06-02 01:47:10 +00:00
fix(workspace): make Pause/Resume cascade opt-in via ?cascade=true
audit-force-merge / audit (pull_request_target) Has been skipped
Details
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
Harness Replays / detect-changes (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 10s
Details
qa-review / approved (pull_request_target) Failing after 4s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 10s
Details
security-review / approved (pull_request_target) Failing after 4s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 11s
Details
CI / Detect changes (pull_request) Successful in 13s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 18s
Details
E2E Chat / detect-changes (pull_request) Successful in 18s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 7s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 5s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 56s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m0s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m6s
Details
CI / Platform (Go) (pull_request) Successful in 5m1s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m16s
Details
CI / all-required (pull_request) Successful in 2s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 7s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 17s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 17s
Details
a5b89524a6 
POST /workspaces/:id/pause and /resume currently implicitly cascade to
all descendants. This caused incident internal#722 where a single Pause
call terminated 5 EC2-backed workspaces.

Change default behavior to single-workspace scope. If descendants exist
and cascade=true is not set, return 409 Conflict with a descendants
list so the caller can decide. ?cascade=true preserves the old
recursive behavior.

- Pause: check c.Query(\"cascade\") before stopping descendants
- Resume: mirror Pause's cascade contract
- Update TestPause_WithDescendants to use ?cascade=true
- Add 4 new tests covering 409 + 200 paths for both handlers

Fixes #1991

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-be closed this pull request 2026-06-02 01:53:11 +00:00
Some optional checks failed
audit-force-merge / audit (pull_request_target) Has been skipped
Details
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
Harness Replays / detect-changes (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Required
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 10s
Details
qa-review / approved (pull_request_target) Failing after 4s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 10s
Details
security-review / approved (pull_request_target) Failing after 4s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 11s
Details
CI / Detect changes (pull_request) Successful in 13s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 18s
Details
E2E Chat / detect-changes (pull_request) Successful in 18s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 7s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 5s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 56s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m0s
Required
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m6s
Required
Details
CI / Platform (Go) (pull_request) Successful in 5m1s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m16s
Details
CI / all-required (pull_request) Successful in 2s
Required
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 7s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 17s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 17s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2120
Delete Branch "fix/pause-resume-cascade-opt-in-1991"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?