molecule-ai/molecule-core
51
0
Fork 2
Code Issues 158 Pull Requests 160 Actions 11 Packages Projects Releases Wiki Activity

test: make tests hermetic against CI runner env vars #2101

Closed
core-be wants to merge 2 commits from fix/staging-test-hermetic-env into staging
pull from: fix/staging-test-hermetic-env
merge into: molecule-ai:staging
Conversation 2 Commits 2 Files Changed 8
+40 -9
core-be commented 2026-06-01 14:08:32 +00:00
Member
Copy Link
Copy Source

Fixes 22 pre-existing test failures on staging caused by CI runner env var pollution (ADMIN_TOKEN + MOLECULE_ORG_ID).

  • ADMIN_TOKEN set → AdminAuth closes fail-open, requires bearer
  • MOLECULE_ORG_ID set → saasMode() true → RFC-1918 allowed in SSRF checks

Adds t.Setenv to affected tests across handlers, middleware, and router so they explicitly control the env state they depend on.

Test plan:

  • Full ./... test suite passes (37 packages, 0 failures)
Fixes 22 pre-existing test failures on staging caused by CI runner env var pollution (ADMIN_TOKEN + MOLECULE_ORG_ID). - ADMIN_TOKEN set → AdminAuth closes fail-open, requires bearer - MOLECULE_ORG_ID set → saasMode() true → RFC-1918 allowed in SSRF checks Adds t.Setenv to affected tests across handlers, middleware, and router so they explicitly control the env state they depend on. Test plan: - [ ] Full `./...` test suite passes (37 packages, 0 failures)
core-be added 1 commit 2026-06-01 14:08:32 +00:00
test: make tests hermetic against CI runner env vars
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 13s
Details
CI / Detect changes (pull_request) Successful in 10s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1m18s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 17s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Waiting to run
Details
E2E Chat / detect-changes (pull_request) Successful in 20s
Details
E2E Chat / E2E Chat (pull_request) Waiting to run
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Waiting to run
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
Harness Replays / Harness Replays (pull_request) Waiting to run
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m28s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 13s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Waiting to run
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 7s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 5s
Details
qa-review / approved (pull_request_target) Successful in 13s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 6s
Details
security-review / approved (pull_request_target) Successful in 10s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 5s
Details
CI / Platform (Go) (pull_request) Failing after 5m53s
Details
CI / all-required (pull_request) Failing after 4m14s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m44s
Details
CI / Canvas Deploy Reminder (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 7m50s
Details
1bc8452911 
The CI runners set ADMIN_TOKEN and MOLECULE_ORG_ID in the environment.
These leak into test processes and flip security posture gates:

- ADMIN_TOKEN set → AdminAuth skip fail-open, require bearer
- MOLECULE_ORG_ID set → saasMode() true → RFC-1918 allowed in SSRF checks

Add t.Setenv to 22 affected tests across handlers, middleware, and router
so they explicitly control the env state they depend on.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-be added 1 commit 2026-06-01 15:29:04 +00:00
fix(lint): remove unused canvasUserMessage type
CI / Detect changes (pull_request) Successful in 23s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 25s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 37s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 54s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 12s
Details
E2E Chat / detect-changes (pull_request) Successful in 15s
Details
Harness Replays / detect-changes (pull_request) Successful in 12s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 33s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 11s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 7s
Details
qa-review / approved (pull_request_target) Successful in 8s
Details
security-review / approved (pull_request_target) Successful in 6s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m19s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 7s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 9s
Details
CI / Platform (Go) (pull_request) Successful in 5m21s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m29s
Details
CI / Python Lint & Test (pull_request) Successful in 7m23s
Details
CI / all-required (pull_request) Successful in 7m26s
Details
Harness Replays / Harness Replays (pull_request) Successful in 22s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 15s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m16s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m40s
Details
E2E Chat / E2E Chat (pull_request) Failing after 6m30s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
4146812d5d 
The struct was introduced alongside extractCanvasUserMessage but the
function returns map[string]interface{} and never uses the typed
variant. golangci-lint unused check fails on it, blocking CI.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
devops-engineer commented 2026-06-01 18:28:34 +00:00
Member
Copy Link
Copy Source

Closing — based on the dead staging fork; this fix is already on main. the hermetic env guards this PR adds already exist (equal or superset) on main: mcp_test.go (6× MOLECULE_ORG_ID), registry_test.go TestValidateAgentURL (MOLECULE_ORG_ID + MOLECULE_DEPLOY_MODE), wsauth_middleware_test.go (11× ADMIN_TOKEN), security_regression__test.go (2×), workspace_provision_test.go (4×). The admin_test_token_test.go hunks target staging-only files that do not exist on main. Per the staging-deprecation cleanup; target main for future PRs.

Closing — based on the dead `staging` fork; this fix is already on `main`. the hermetic env guards this PR adds already exist (equal or superset) on main: mcp_test.go (6× MOLECULE_ORG_ID), registry_test.go TestValidateAgentURL (MOLECULE_ORG_ID + MOLECULE_DEPLOY_MODE), wsauth_middleware_test.go (11× ADMIN_TOKEN), security_regression_*_test.go (2×), workspace_provision_test.go (4×). The admin_test_token*_test.go hunks target staging-only files that do not exist on main. Per the staging-deprecation cleanup; target `main` for future PRs.
devops-engineer closed this pull request 2026-06-01 18:28:35 +00:00
core-be commented 2026-06-02 00:00:00 +00:00
Author
Member
Copy Link
Copy Source

superseded by main; staging fork dead per CTO investigation (main lapped staging by 648 commits, #1743 self-sync). Test hermeticity fixes are already present on main (#1703 and subsequent commits).

superseded by main; staging fork dead per CTO investigation (main lapped staging by 648 commits, #1743 self-sync). Test hermeticity fixes are already present on main (#1703 and subsequent commits).
Some required checks failed
CI / Detect changes (pull_request) Successful in 23s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 25s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 37s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 54s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 12s
Details
E2E Chat / detect-changes (pull_request) Successful in 15s
Details
Harness Replays / detect-changes (pull_request) Successful in 12s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 33s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 11s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 7s
Details
qa-review / approved (pull_request_target) Successful in 8s
Details
security-review / approved (pull_request_target) Successful in 6s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m19s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Required
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 7s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 9s
Details
CI / Platform (Go) (pull_request) Successful in 5m21s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m29s
Details
CI / Python Lint & Test (pull_request) Successful in 7m23s
Details
CI / all-required (pull_request) Successful in 7m26s
Required
Details
Harness Replays / Harness Replays (pull_request) Successful in 22s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 15s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m16s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m40s
Details
E2E Chat / E2E Chat (pull_request) Failing after 6m30s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2101
Delete Branch "fix/staging-test-hermetic-env"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?