molecule-ai/molecule-core
51
0
Fork 2
Code Issues 158 Pull Requests 160 Actions 11 Packages Projects Releases Wiki Activity

fix(audit): add missing rows.Err() check after rows.Next() loop #2099

Closed
core-be wants to merge 2 commits from fix/audit-rows-err-check into main
pull from: fix/audit-rows-err-check
merge into: molecule-ai:main
Conversation 1 Commits 2 Files Changed 2
+6
core-be commented 2026-06-01 10:54:06 +00:00
Member
Copy Link
Copy Source

Summary

Adds the missing rows.Err() check required after rows.Next() iteration in scanAuditRows() (audit.go). Go documentation explicitly requires this check; omission is a CWE-78 candidate.

Builds on the same fix pattern already applied to llm_billing_mode.go (PR#2097).

Test plan

  • Code compiles (go build ./...)
  • Existing handler tests pass

🤖 Generated with Claude Code

## Summary Adds the missing `rows.Err()` check required after `rows.Next()` iteration in `scanAuditRows()` (audit.go). Go documentation explicitly requires this check; omission is a CWE-78 candidate. Builds on the same fix pattern already applied to `llm_billing_mode.go` (PR#2097). ## Test plan - [x] Code compiles (`go build ./...`) - [x] Existing handler tests pass 🤖 Generated with Claude Code
core-be added 2 commits 2026-06-01 10:54:07 +00:00
fix(handlers): add missing rows.Err() check in llm_billing_mode
sop-tier-check / tier-check (pull_request_target) Successful in 4s
Details
sop-tier-check / tier-check (pull_request_review) Successful in 4s
Details
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 4s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 10s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 13s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 8s
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 5s
Details
E2E Chat / detect-changes (pull_request) Successful in 17s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 14s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 15s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 7s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
qa-review / approved (pull_request_target) Failing after 5s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 14s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 9s
Details
security-review / approved (pull_request_target) Failing after 10s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 6s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 4s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E Chat / E2E Chat (pull_request) Successful in 7s
Details
verify-providers-gen / Regenerate providers artifact and fail on drift (pull_request) Successful in 27s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m11s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m0s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m10s
Details
CI / Platform (Go) (pull_request) Successful in 3m59s
Details
CI / all-required (pull_request) Successful in 5m5s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
d287eb56a6 
readWorkspaceDeriveInputs iterated workspace_secrets via rows.Next()
but never checked rows.Err() after the loop. A transient iteration
error (network, cursor failure) would silently be ignored, causing
the resolver to derive billing mode from a partial secret set.

Add the standard post-Next rows.Err() check, logging the error and
continuing with whatever was gathered (fail-closed: incomplete inputs
cause DeriveProvider to default to platform_managed).

Closes internal#734 CWE-78 follow-up (last missing check in handlers).
fix(audit): add missing rows.Err() check after rows.Next() loop
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
E2E Chat / detect-changes (pull_request) Failing after 1s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
E2E Chat / E2E Chat (pull_request) Has been skipped
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 7s
Details
qa-review / approved (pull_request_target) Failing after 6s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
CI / Python Lint & Test (pull_request) Successful in 11s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 12s
Details
security-review / approved (pull_request_target) Failing after 6s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 5s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 4s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 14s
Details
verify-providers-gen / Regenerate providers artifact and fail on drift (pull_request) Successful in 23s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 23s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 25s
Details
CI / Detect changes (pull_request) Successful in 27s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 15s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
CI / Canvas (Next.js) (pull_request) Successful in 15s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m14s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m28s
Details
CI / Platform (Go) (pull_request) Successful in 3m56s
Details
CI / all-required (pull_request) Successful in 4m34s
Details
Harness Replays / detect-changes (pull_request) Failing after 1s
Details
Harness Replays / Harness Replays (pull_request) Has been skipped
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 17s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m22s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
bb52d43dc1 
scanAuditRows now surfaces iteration errors instead of silently
returning partial results.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
devops-engineer commented 2026-06-01 19:13:37 +00:00
Member
Copy Link
Copy Source

Superseded — the unique llm_billing_mode rows.Err fix will land via #2097; the audit.go part is already covered on main (audit.go:209). Closing as redundant.

Superseded — the unique llm_billing_mode rows.Err fix will land via #2097; the audit.go part is already covered on main (audit.go:209). Closing as redundant.
devops-engineer closed this pull request 2026-06-01 19:13:40 +00:00
Some optional checks failed
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
E2E Chat / detect-changes (pull_request) Failing after 1s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
E2E Chat / E2E Chat (pull_request) Has been skipped
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 7s
Details
qa-review / approved (pull_request_target) Failing after 6s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
CI / Python Lint & Test (pull_request) Successful in 11s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 12s
Details
security-review / approved (pull_request_target) Failing after 6s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 5s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 4s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 14s
Details
verify-providers-gen / Regenerate providers artifact and fail on drift (pull_request) Successful in 23s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 23s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 25s
Details
CI / Detect changes (pull_request) Successful in 27s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 15s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
CI / Canvas (Next.js) (pull_request) Successful in 15s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m14s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m28s
Required
Details
CI / Platform (Go) (pull_request) Successful in 3m56s
Details
CI / all-required (pull_request) Successful in 4m34s
Required
Details
Harness Replays / detect-changes (pull_request) Failing after 1s
Details
Harness Replays / Harness Replays (pull_request) Has been skipped
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 17s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m22s
Required
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2099
Delete Branch "fix/audit-rows-err-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?