fix(rowserr): add missing rows.Err() checks in memory, schedules, and audit #2092

Closed
core-be wants to merge 3 commits from fix/rowserr-memory-schedules-audit into staging
Member

Prevent silent data truncation when a cursor/connection error occurs mid-iteration.

Affected handlers:

  • memory.go: List
  • schedules.go: History
  • audit.go: scanAuditRows
Prevent silent data truncation when a cursor/connection error occurs mid-iteration. Affected handlers: - memory.go: List - schedules.go: History - audit.go: scanAuditRows
core-be added 2 commits 2026-06-01 05:31:43 +00:00
fix(broadcast): correct org-root CTE for non-root senders (#1959)
gate-check-v3 / gate-check (pull_request) Waiting to run
qa-review / approved (pull_request) Waiting to run
security-review / approved (pull_request) Waiting to run
sop-tier-check / tier-check (pull_request) Waiting to run
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 15s
CI / Detect changes (pull_request) Successful in 20s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 29s
E2E API Smoke Test / detect-changes (pull_request) Successful in 20s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 9s
E2E Chat / detect-changes (pull_request) Successful in 17s
Harness Replays / detect-changes (pull_request) Successful in 9s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 20s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 8s
gate-check-v3 / gate-check (pull_request_target) Successful in 9s
qa-review / approved (pull_request_target) Successful in 7s
security-review / approved (pull_request_target) Successful in 8s
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request_target) Successful in 7s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m11s
sop-tier-check / tier-check (pull_request_target) Successful in 9s
CI / Platform (Go) (pull_request) Failing after 6m5s
CI / all-required (pull_request) Failing after 4m54s
CI / Canvas (Next.js) (pull_request) Successful in 7m31s
CI / Canvas Deploy Reminder (pull_request) Waiting to run
CI / Python Lint & Test (pull_request) Successful in 7m35s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m17s
Harness Replays / Harness Replays (pull_request) Successful in 1s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m32s
E2E Chat / E2E Chat (pull_request) Failing after 7m22s
d0a2facf44
fix(rowserr): add missing rows.Err() checks in memory, schedules, and audit
Block internal-flavored paths / Block forbidden paths (pull_request) Waiting to run
CI / Detect changes (pull_request) Waiting to run
CI / Platform (Go) (pull_request) Waiting to run
CI / Canvas (Next.js) (pull_request) Waiting to run
CI / Shellcheck (E2E scripts) (pull_request) Waiting to run
CI / Canvas Deploy Reminder (pull_request) Blocked by required conditions
CI / Python Lint & Test (pull_request) Waiting to run
CI / all-required (pull_request) Waiting to run
E2E API Smoke Test / detect-changes (pull_request) Waiting to run
E2E API Smoke Test / E2E API Smoke Test (pull_request) Blocked by required conditions
E2E Chat / detect-changes (pull_request) Waiting to run
E2E Chat / E2E Chat (pull_request) Blocked by required conditions
Handlers Postgres Integration / detect-changes (pull_request) Waiting to run
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions
Harness Replays / detect-changes (pull_request) Waiting to run
Harness Replays / Harness Replays (pull_request) Blocked by required conditions
lint-required-no-paths / lint-required-no-paths (pull_request) Waiting to run
Runtime PR-Built Compatibility / detect-changes (pull_request) Waiting to run
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Blocked by required conditions
Secret scan / Scan diff for credential-shaped strings (pull_request) Waiting to run
gate-check-v3 / gate-check (pull_request) Waiting to run
qa-review / approved (pull_request) Waiting to run
security-review / approved (pull_request) Waiting to run
sop-checklist / all-items-acked (pull_request) Waiting to run
sop-tier-check / tier-check (pull_request) Waiting to run
8f8f526d36
Prevent silent data truncation when a cursor/connection error occurs
mid-iteration. Affected handlers:

- memory.go: List
- schedules.go: History
- audit.go: scanAuditRows

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-be force-pushed fix/rowserr-memory-schedules-audit from 8f8f526d36 to de71fce5c5 2026-06-01 05:32:39 +00:00 Compare
core-be added 1 commit 2026-06-01 12:37:06 +00:00
ci: remove unused canvasUserMessage type to fix lint on staging
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
CI / Detect changes (pull_request) Successful in 26s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 34s
E2E API Smoke Test / detect-changes (pull_request) Successful in 18s
CI / Platform (Go) (pull_request) Successful in 5m56s
CI / Canvas (Next.js) (pull_request) Successful in 7m32s
CI / Python Lint & Test (pull_request) Successful in 7m24s
CI / all-required (pull_request) Successful in 7m0s
E2E Chat / detect-changes (pull_request) Successful in 14s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Harness Replays / detect-changes (pull_request) Successful in 8s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 9s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 9s
gate-check-v3 / gate-check (pull_request_target) Successful in 8s
qa-review / approved (pull_request_target) Successful in 5s
security-review / approved (pull_request_target) Successful in 5s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m8s
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request_target) Successful in 6s
sop-tier-check / tier-check (pull_request_target) Successful in 5s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m23s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Harness Replays / Harness Replays (pull_request) Successful in 21s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 20s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m38s
E2E Chat / E2E Chat (pull_request) Failing after 7m34s
audit-force-merge / audit (pull_request_target) Has been skipped
00cab17c73
internal/handlers/a2a_proxy_helpers.go:412 had an unused struct that
causes golangci-lint `unused` failure on every PR targeting staging.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Member

Superseded — the #1959 broadcast org-root CTE fix is merged on main via #2105 (with a real Postgres regression test). Closing as redundant. Target main for future PRs.

Superseded — the #1959 broadcast org-root CTE fix is merged on main via #2105 (with a real Postgres regression test). Closing as redundant. Target main for future PRs.
devops-engineer closed this pull request 2026-06-01 19:13:16 +00:00
Some required checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
CI / Detect changes (pull_request) Successful in 26s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 34s
E2E API Smoke Test / detect-changes (pull_request) Successful in 18s
CI / Platform (Go) (pull_request) Successful in 5m56s
CI / Canvas (Next.js) (pull_request) Successful in 7m32s
CI / Python Lint & Test (pull_request) Successful in 7m24s
CI / all-required (pull_request) Successful in 7m0s
Required
Details
E2E Chat / detect-changes (pull_request) Successful in 14s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Harness Replays / detect-changes (pull_request) Successful in 8s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 9s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 9s
gate-check-v3 / gate-check (pull_request_target) Successful in 8s
qa-review / approved (pull_request_target) Successful in 5s
security-review / approved (pull_request_target) Successful in 5s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m8s
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Required
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request_target) Successful in 6s
sop-tier-check / tier-check (pull_request_target) Successful in 5s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m23s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Harness Replays / Harness Replays (pull_request) Successful in 21s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 20s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m38s
E2E Chat / E2E Chat (pull_request) Failing after 7m34s
audit-force-merge / audit (pull_request_target) Has been skipped

Pull request closed

Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2092