molecule-ai/molecule-core
51
0
Fork 2
Code Issues 159 Pull Requests 160 Actions 14 Packages Projects Releases Wiki Activity

fix(discovery): check rows.Err() after iteration in queryPeerMaps #2089

Closed
core-be wants to merge 2 commits from fix/discovery-rows-err-check into staging
pull from: fix/discovery-rows-err-check
merge into: molecule-ai:staging
Conversation 1 Commits 2 Files Changed 2
+4 -9
core-be commented 2026-06-01 05:15:16 +00:00
Member
Copy Link
Copy Source

queryPeerMaps iterated rows.Next() without checking rows.Err() after the loop. A broken connection or cursor error during iteration would silently return a partial result set instead of surfacing the error.

Add rows.Err() check after the for-loop and return the error so callers (ListPeers, CheckAccess) fail closed instead of receiving truncated peer data.

Fixes #1171

queryPeerMaps iterated rows.Next() without checking rows.Err() after the loop. A broken connection or cursor error during iteration would silently return a partial result set instead of surfacing the error. Add rows.Err() check after the for-loop and return the error so callers (ListPeers, CheckAccess) fail closed instead of receiving truncated peer data. Fixes #1171
core-be added 1 commit 2026-06-01 05:15:17 +00:00
fix(discovery): check rows.Err() after iteration in queryPeerMaps
gate-check-v3 / gate-check (pull_request) Waiting to run
Details
qa-review / approved (pull_request) Waiting to run
Details
security-review / approved (pull_request) Waiting to run
Details
sop-tier-check / tier-check (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 16s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 10s
Details
E2E Chat / detect-changes (pull_request) Successful in 9s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 6s
Details
Harness Replays / detect-changes (pull_request) Successful in 4s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 11s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 7s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 5s
Details
qa-review / approved (pull_request_target) Successful in 4s
Details
security-review / approved (pull_request_target) Successful in 5s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 6s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 9s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m11s
Details
CI / Platform (Go) (pull_request) Failing after 5m9s
Details
CI / all-required (pull_request) Failing after 4m3s
Details
CI / Canvas (Next.js) (pull_request) Successful in 7m14s
Details
CI / Canvas Deploy Reminder (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 7m4s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m26s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 3s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m0s
Details
E2E Chat / E2E Chat (pull_request) Failing after 5m48s
Details
f62d37d6e5 
queryPeerMaps iterated rows.Next() without checking rows.Err() after
the loop. A broken connection or cursor error during iteration would
silently return a partial result set instead of surfacing the error.

Add rows.Err() check after the for-loop and return the error so
callers (ListPeers, CheckAccess) fail closed instead of receiving
truncated peer data.

Fixes #1171
core-be added 1 commit 2026-06-01 12:37:10 +00:00
ci: remove unused canvasUserMessage type to fix lint on staging
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
CI / Detect changes (pull_request) Successful in 12s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 21s
Details
CI / Platform (Go) (pull_request) Successful in 5m24s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
E2E Chat / detect-changes (pull_request) Successful in 11s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Details
Harness Replays / detect-changes (pull_request) Successful in 10s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 8s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m52s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 6s
Details
qa-review / approved (pull_request_target) Successful in 6s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
security-review / approved (pull_request_target) Successful in 8s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 7s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 6s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m18s
Details
CI / Python Lint & Test (pull_request) Successful in 7m17s
Details
CI / all-required (pull_request) Successful in 6m26s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m55s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m40s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 4s
Details
E2E Chat / E2E Chat (pull_request) Failing after 5m21s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
b2da94931e 
internal/handlers/a2a_proxy_helpers.go:412 had an unused struct that
causes golangci-lint `unused` failure on every PR targeting staging.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
devops-engineer commented 2026-06-01 18:28:32 +00:00
Member
Copy Link
Copy Source

Closing — based on the dead staging fork; this fix is already on main. main already checks rows.Err() after the iteration loop in queryPeerMaps (discovery.go:398-399). Per the staging-deprecation cleanup; target main for future PRs.

Closing — based on the dead `staging` fork; this fix is already on `main`. main already checks rows.Err() after the iteration loop in queryPeerMaps (discovery.go:398-399). Per the staging-deprecation cleanup; target `main` for future PRs.
devops-engineer closed this pull request 2026-06-01 18:28:33 +00:00
Some required checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
CI / Detect changes (pull_request) Successful in 12s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 21s
Details
CI / Platform (Go) (pull_request) Successful in 5m24s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
E2E Chat / detect-changes (pull_request) Successful in 11s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Details
Harness Replays / detect-changes (pull_request) Successful in 10s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 8s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m52s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 6s
Details
qa-review / approved (pull_request_target) Successful in 6s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Required
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
security-review / approved (pull_request_target) Successful in 8s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 7s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 6s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m18s
Details
CI / Python Lint & Test (pull_request) Successful in 7m17s
Details
CI / all-required (pull_request) Successful in 6m26s
Required
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m55s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m40s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 4s
Details
E2E Chat / E2E Chat (pull_request) Failing after 5m21s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2089
Delete Branch "fix/discovery-rows-err-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?