molecule-ai/molecule-core
51
0
Fork 2
Code Issues 157 Pull Requests 160 Actions 12 Packages Projects Releases Wiki Activity

fix(restart_context): defer rows.Close() instead of explicit close in loadRestartContextData #2049

Closed
core-be wants to merge 2 commits from fix/restart-context-defer-rows-close into staging
pull from: fix/restart-context-defer-rows-close
merge into: molecule-ai:staging
Conversation 1 Commits 2 Files Changed 2
+2 -11
core-be commented 2026-06-01 03:36:55 +00:00
Member
Copy Link
Copy Source
No description provided.
core-be added 1 commit 2026-06-01 03:36:56 +00:00
fix(restart_context): defer rows.Close() instead of explicit close in loadRestartContextData
sop-checklist / review-refire (pull_request) Waiting to run
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Waiting to run
Details
branch-protection drift check / Branch protection drift (pull_request) Waiting to run
Details
cascade-list-drift-gate / check (pull_request) Waiting to run
Details
Check merge_group trigger on required workflows / Required workflows have merge_group trigger (pull_request) Waiting to run
Details
Check migration collisions / Migration version collision check (pull_request) Waiting to run
Details
CodeQL / Analyze (${{ matrix.language }}) (go) (pull_request) Waiting to run
Details
CodeQL / Analyze (${{ matrix.language }}) (javascript-typescript) (pull_request) Waiting to run
Details
CodeQL / Analyze (${{ matrix.language }}) (python) (pull_request) Waiting to run
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Waiting to run
Details
Runtime Pin Compatibility / PyPI-latest install + import smoke (pull_request) Waiting to run
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Waiting to run
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Waiting to run
Details
gate-check-v3 / gate-check (pull_request) Waiting to run
Details
qa-review / approved (pull_request) Waiting to run
Details
security-review / approved (pull_request) Waiting to run
Details
sop-checklist / all-items-acked (pull_request) Waiting to run
Details
sop-tier-check / tier-check (pull_request) Waiting to run
Details
audit-force-merge / audit (pull_request) Waiting to run
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Has been cancelled
Details
Harness Replays / Harness Replays (pull_request) Has been cancelled
Details
CI / Platform (Go) (pull_request) Has been cancelled
Details
CI / Canvas (Next.js) (pull_request) Has been cancelled
Details
CI / Shellcheck (E2E scripts) (pull_request) Has been cancelled
Details
CI / Canvas Deploy Reminder (pull_request) Has been cancelled
Details
CI / Python Lint & Test (pull_request) Has been cancelled
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Has been cancelled
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Has been cancelled
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Has been cancelled
Details
Handlers Postgres Integration / detect-changes (pull_request) Has been cancelled
Details
Harness Replays / detect-changes (pull_request) Has been cancelled
Details
CI / Detect changes (pull_request) Has been cancelled
Details
E2E API Smoke Test / detect-changes (pull_request) Has been cancelled
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Has been cancelled
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Has been cancelled
Details
7ba854f741 
Changes explicit rows.Close() calls to deferred closes in both global
and workspace secret key queries. Prevents cursor leaks on panic or
early return between QueryContext and the explicit close.
core-be changed target branch from main to staging 2026-06-01 03:40:24 +00:00
core-be force-pushed fix/restart-context-defer-rows-close from 7ba854f741 to c997cfa230 2026-06-01 05:04:00 +00:00 Compare
core-be added 1 commit 2026-06-01 12:56:56 +00:00
ci: remove unused canvasUserMessage type to fix lint
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 22s
Details
CI / Detect changes (pull_request) Successful in 18s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 43s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 16s
Details
E2E Chat / detect-changes (pull_request) Successful in 13s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 6s
Details
Harness Replays / detect-changes (pull_request) Successful in 9s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m13s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 8s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 7s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 6s
Details
qa-review / approved (pull_request_target) Successful in 13s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 6s
Details
security-review / approved (pull_request_target) Successful in 7s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 9s
Details
CI / Platform (Go) (pull_request) Successful in 5m17s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m45s
Details
CI / Python Lint & Test (pull_request) Successful in 7m14s
Details
CI / all-required (pull_request) Successful in 7m36s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 14s
Details
Harness Replays / Harness Replays (pull_request) Successful in 15s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m32s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m41s
Details
E2E Chat / E2E Chat (pull_request) Failing after 6m48s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
01157fdbfa 
internal/handlers/a2a_proxy_helpers.go:412 had an unused struct that
causes golangci-lint `unused` failure.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
devops-engineer commented 2026-06-01 18:28:24 +00:00
Member
Copy Link
Copy Source

Closing — based on the dead staging fork; this fix is already on main. main already uses defer rows.Close() in both loops of loadRestartContextData (restart_context.go:136,150), so the explicit-Close cursor-leak path this PR targets no longer exists. Per the staging-deprecation cleanup; target main for future PRs.

Closing — based on the dead `staging` fork; this fix is already on `main`. main already uses `defer rows.Close()` in both loops of loadRestartContextData (restart_context.go:136,150), so the explicit-Close cursor-leak path this PR targets no longer exists. Per the staging-deprecation cleanup; target `main` for future PRs.
devops-engineer closed this pull request 2026-06-01 18:28:25 +00:00
Some required checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 22s
Details
CI / Detect changes (pull_request) Successful in 18s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 43s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 16s
Details
E2E Chat / detect-changes (pull_request) Successful in 13s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 6s
Details
Harness Replays / detect-changes (pull_request) Successful in 9s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m13s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 8s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 7s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 6s
Details
qa-review / approved (pull_request_target) Successful in 13s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Required
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 6s
Details
security-review / approved (pull_request_target) Successful in 7s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 9s
Details
CI / Platform (Go) (pull_request) Successful in 5m17s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m45s
Details
CI / Python Lint & Test (pull_request) Successful in 7m14s
Details
CI / all-required (pull_request) Successful in 7m36s
Required
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 14s
Details
Harness Replays / Harness Replays (pull_request) Successful in 15s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m32s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m41s
Details
E2E Chat / E2E Chat (pull_request) Failing after 6m48s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2049
Delete Branch "fix/restart-context-defer-rows-close"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?